Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Subject: [i-g-t 4/4] tests/kms_vrr: Fix virtual mode for CMRR subtest
Date: Fri, 21 Jun 2024 14:17:11 +0530	[thread overview]
Message-ID: <20240621084711.68444-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240621084711.68444-1-bhanuprakash.modem@intel.com>

Instead of tweaking the mode->clock, change the mode->vtotal
to create the virtual mode.

Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_vrr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 6f90f4729..f12d23c3c 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -809,9 +809,9 @@ test_cmrr(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	kmstest_dump_mode(&mode);
 
 	if (!found) {
-		igt_info("No CMRR mode found on %s, try to tweak the clock.\n", output->name);
+		igt_info("No CMRR mode found on %s, try to tweak the mode.\n", output->name);
 
-		mode.clock = (mode.htotal * mode.vtotal * (mode.vrefresh + VREFRESH_MODIFIER)) / 1000;
+		virtual_rr_vrr_range_mode(&mode, mode.vrefresh + VREFRESH_MODIFIER);
 
 		igt_info("Tweaked mode: ");
 		kmstest_dump_mode(&mode);
-- 
2.43.2


  parent reply	other threads:[~2024-06-21  8:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  8:47 [i-g-t 0/4] VRR test Cleanup Bhanuprakash Modem
2024-06-21  8:47 ` [i-g-t 1/4] tests/kms_vrr: Skip low RR mode check for seamless-virtual subtest Bhanuprakash Modem
2024-06-24  9:26   ` Golani, Mitulkumar Ajitkumar
2024-06-21  8:47 ` [i-g-t 2/4] tests/kms_vrr: Fix hardcoded step size Bhanuprakash Modem
2024-06-24 12:12   ` Golani, Mitulkumar Ajitkumar
2024-06-21  8:47 ` [i-g-t 3/4] tests/kms_vrr: Cleanup in creating the virtual mode Bhanuprakash Modem
2024-06-24  4:06   ` [i-g-t V2 " Bhanuprakash Modem
2024-07-03  5:11     ` Golani, Mitulkumar Ajitkumar
2024-06-21  8:47 ` Bhanuprakash Modem [this message]
2024-07-03  5:20   ` [i-g-t 4/4] tests/kms_vrr: Fix virtual mode for CMRR subtest Golani, Mitulkumar Ajitkumar
2024-06-21  9:34 ` ✗ CI.xeBAT: failure for VRR test cleanup (rev4) Patchwork
2024-06-21  9:40 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-21 11:18 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-22 14:04 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-24  4:40 ` ✓ CI.xeBAT: success for VRR test cleanup (rev5) Patchwork
2024-06-24  4:50 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-24  5:39 ` ✓ CI.xeFULL: " Patchwork
2024-06-24 16:14 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621084711.68444-5-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox