From: <vitaly.prosyak@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Jesse Zhang <Jesse.Zhang@amd.com>
Subject: [PATCH 2/2] tests/amdgpu/gang_cs: skip test for some chips
Date: Sat, 22 Jun 2024 18:52:16 -0400 [thread overview]
Message-ID: <20240622225216.108985-2-vitaly.prosyak@amd.com> (raw)
In-Reply-To: <20240622225216.108985-1-vitaly.prosyak@amd.com>
From: Vitaly Prosyak <vitaly.prosyak@amd.com>
Check if gang tests are enabled based on GPU information.
Gang tests are supported starting with Vega10, but are broken
on Navi10 and Navi14. This function mirrors the logic in amdgpu.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Jesse Zhang <Jesse.Zhang@amd.com>
Suggested-by: Christian Koenig <christian.koenig@amd.com>
Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
---
tests/amdgpu/amd_gang_cs.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/tests/amdgpu/amd_gang_cs.c b/tests/amdgpu/amd_gang_cs.c
index 722c376ee..699862670 100644
--- a/tests/amdgpu/amd_gang_cs.c
+++ b/tests/amdgpu/amd_gang_cs.c
@@ -9,10 +9,38 @@
#include "lib/amdgpu/amd_ip_blocks.h"
#include "lib/amdgpu/amd_memory.h"
#include "lib/amdgpu/amd_cs_radv.h"
+#include "lib/amdgpu/amd_family.h"
#define IB_SIZE 4096
+/**
+ * Check if gang tests are enabled based on GPU information.
+ *
+ * Gang tests are supported starting with Vega10 but are broken on Navi10 and Navi14.
+ * This function mirrors the logic in the following amdgpu code:
+ *
+ * void amdgpu_vm_manager_init(struct amdgpu_device *adev) {
+ * adev->vm_manager.concurrent_flush = !(adev->asic_type < CHIP_VEGA10 ||
+ * adev->asic_type == CHIP_NAVI10 ||
+ * adev->asic_type == CHIP_NAVI14);
+ * }
+ *
+ * @param gpu_info: Pointer to the structure containing GPU information.
+ * @return: True if gang tests are enabled, false otherwise.
+ */
+static bool is_gang_tests_enable(const struct chip_info *pChip)
+{
+ /* Concurrent flushes are supported only on Vega10 and newer,
+ * excluding Navi10 and Navi14 due to known issues.
+ */
+ if (pChip->family < CHIP_VEGA10 ||
+ pChip->family == CHIP_NAVI10 ||
+ pChip->family == CHIP_NAVI14) {
+ return false;
+ }
+ return true;
+}
static void
prepare_compute_cp_packet(amdgpu_device_handle device,
@@ -233,6 +261,7 @@ igt_main
igt_assert_eq(r, 0);
r = setup_amdgpu_ip_blocks(major, minor, &gpu_info, device);
igt_assert_eq(r, 0);
+ igt_skip_on(!is_gang_tests_enable(g_pChip));
asic_rings_readness(device, 1, arr_cap);
}
--
2.25.1
next prev parent reply other threads:[~2024-06-22 22:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 22:52 [PATCH 1/2] lib/amdgpu: allow usage convenient chip info vitaly.prosyak
2024-06-22 22:52 ` vitaly.prosyak [this message]
2024-06-24 1:57 ` [PATCH 2/2] tests/amdgpu/gang_cs: skip test for some chips Zhang, Jesse(Jie)
2024-06-24 9:44 ` Christian König
2024-06-23 0:00 ` ✓ CI.xeBAT: success for series starting with [1/2] lib/amdgpu: allow usage convenient chip info Patchwork
2024-06-23 0:09 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-23 0:53 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-23 1:38 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-24 1:57 ` [PATCH 1/2] " Zhang, Jesse(Jie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240622225216.108985-2-vitaly.prosyak@amd.com \
--to=vitaly.prosyak@amd.com \
--cc=Jesse.Zhang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox