Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [i-g-t] lib/igt_kms: Format cleanup in DRM mode printing
Date: Mon, 24 Jun 2024 20:40:28 +0530	[thread overview]
Message-ID: <20240624151028.205562-1-bhanuprakash.modem@intel.com> (raw)

While printing the DRM mode, align the style with the
Kernel logs, so that it would be easy to compare & debug.

Example:
 Old:- 2880x1800 60 2880 2928 2960 3040 1800 1803 1809 1906 0xa 0x48 347710
 New:- "2880x1800": 60 347710 2880 2928 2960 3040 1800 1803 1809 1906 0x48 0xa

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/igt_kms.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 2e6f44e3c..1c096ec5b 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1144,13 +1144,13 @@ void kmstest_dump_mode(drmModeModeInfo *mode)
 	const char *stereo = mode_stereo_name(mode);
 	const char *aspect = mode_picture_aspect_name(mode);
 
-	igt_info("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x %d%s%s%s%s%s%s\n",
-		 mode->name, mode->vrefresh,
+	igt_info("  \"%s\": %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x %s%s%s%s%s%s\n",
+		 mode->name, mode->vrefresh, mode->clock,
 		 mode->hdisplay, mode->hsync_start,
 		 mode->hsync_end, mode->htotal,
 		 mode->vdisplay, mode->vsync_start,
 		 mode->vsync_end, mode->vtotal,
-		 mode->flags, mode->type, mode->clock,
+		 mode->type, mode->flags,
 		 stereo ? " (3D:" : "",
 		 stereo ? stereo : "", stereo ? ")" : "",
 		 aspect ? " (PAR:" : "",
-- 
2.43.2


             reply	other threads:[~2024-06-24 15:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 15:10 Bhanuprakash Modem [this message]
2024-06-24 18:00 ` [i-g-t] lib/igt_kms: Format cleanup in DRM mode printing B, Jeevan
2024-06-25  3:39   ` Modem, Bhanuprakash
2024-06-24 18:04 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-06-24 18:05 ` ✓ CI.xeBAT: " Patchwork
2024-06-24 21:56 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-26  2:06 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624151028.205562-1-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox