Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	Mohammed Thasleem <mohammed.thasleem@intel.com>
Subject: [i-g-t 2/2] tests/kms_hdr: Add more logs to skips
Date: Tue, 25 Jun 2024 10:01:36 +0530	[thread overview]
Message-ID: <20240625043136.257253-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240625043136.257253-1-bhanuprakash.modem@intel.com>

It would be easy to debug if we have some logs in case of
test failures/skips.

V2: - Rebase

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
 tests/kms_hdr.c | 34 ++++++++++++++++++++++++++++------
 1 file changed, 28 insertions(+), 6 deletions(-)

diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index 36ebb4f4e..f123c6b36 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -266,11 +266,16 @@ static void test_bpc_switch(data_t *data, uint32_t flags)
 	for_each_connected_output(display, output) {
 		enum pipe pipe;
 
-		if (!has_max_bpc(output))
+		if (!has_max_bpc(output)) {
+			igt_info("%s: Doesn't support IGT_CONNECTOR_MAX_BPC.\n",
+				 igt_output_name(output));
 			continue;
+		}
 
-		if (igt_get_output_max_bpc(data->fd, output->name) < 10)
+		if (igt_get_output_max_bpc(data->fd, output->name) < 10) {
+			igt_info("%s: Doesn't support 10 bpc.\n", igt_output_name(output));
 			continue;
+		}
 
 		for_each_pipe(display, pipe) {
 			igt_output_set_pipe(output, pipe);
@@ -283,6 +288,9 @@ static void test_bpc_switch(data_t *data, uint32_t flags)
 
 			if (is_intel_device(data->fd) &&
 			    !igt_max_bpc_constraint(display, pipe, output, 10)) {
+				igt_info("%s: No suitable mode found to use 10 bpc.\n",
+					 igt_output_name(output));
+
 				test_fini(data);
 				break;
 			}
@@ -629,18 +637,29 @@ static void test_hdr(data_t *data, uint32_t flags)
 		 * set MAX_BPC property to 10bpc prior to setting
 		 * HDR metadata property. Therefore, checking.
 		 */
-		if (!has_max_bpc(output) || !has_hdr(output))
+		if (!has_max_bpc(output) || !has_hdr(output)) {
+			igt_info("%s: Doesn't support IGT_CONNECTOR_MAX_BPC or IGT_CONNECTOR_HDR_OUTPUT_METADATA.\n",
+				 igt_output_name(output));
 			continue;
+		}
 
 		/* For negative test, panel should be non-hdr. */
-		if ((flags & TEST_INVALID_HDR) && is_panel_hdr(data, output))
+		if ((flags & TEST_INVALID_HDR) && is_panel_hdr(data, output)) {
+			igt_info("%s: Can't run negative test on HDR panel.\n",
+				 igt_output_name(output));
 			continue;
+		}
 
-		if ((flags & ~TEST_INVALID_HDR) && !is_panel_hdr(data, output))
+		if ((flags & ~TEST_INVALID_HDR) && !is_panel_hdr(data, output)) {
+			igt_info("%s: Can't run HDR tests on non-HDR panel.\n",
+				 igt_output_name(output));
 			continue;
+		}
 
-		if (igt_get_output_max_bpc(data->fd, output->name) < 10)
+		if (igt_get_output_max_bpc(data->fd, output->name) < 10) {
+			igt_info("%s: Doesn't support 10 bpc.\n", igt_output_name(output));
 			continue;
+		}
 
 		for_each_pipe(display, pipe) {
 			igt_output_set_pipe(output, pipe);
@@ -653,6 +672,9 @@ static void test_hdr(data_t *data, uint32_t flags)
 
 			if (is_intel_device(data->fd) &&
 			    !igt_max_bpc_constraint(display, pipe, output, 10)) {
+				igt_info("%s: No suitable mode found to use 10 bpc.\n",
+					 igt_output_name(output));
+
 				test_fini(data);
 				break;
 			}
-- 
2.43.2


  reply	other threads:[~2024-06-25  4:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  4:31 [i-g-t 1/2] tests/kms_hdr: Fix bpc-switch subtests Bhanuprakash Modem
2024-06-25  4:31 ` Bhanuprakash Modem [this message]
2024-06-25  4:44 ` Karthik B S
2024-06-25  5:21 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] " Patchwork
2024-06-25  5:31 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-25  5:58   ` Modem, Bhanuprakash
2024-06-25  9:25     ` Illipilli, TejasreeX
2024-06-25  7:06 ` ✓ CI.xeFULL: success " Patchwork
2024-06-25  8:52 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-26  8:17 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625043136.257253-2-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox