Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 3/6] tests/kms_frontbuffer_tracking: Use igt_create_fb()
Date: Tue, 25 Jun 2024 20:40:29 +0300	[thread overview]
Message-ID: <20240625174032.10398-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240625174032.10398-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Calling igt_calc_fb_size() and igt_create_fb_with_bo_size() like
this back to back is the same as just calling igt_create_fb().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index e45d17dd692d..da593c3aacc7 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -1630,8 +1630,7 @@ static void create_fb(enum pixel_format pformat, int width, int height,
 		      enum tiling_type tiling, int plane, struct igt_fb *fb)
 {
 	uint32_t format;
-	uint64_t size, modifier;
-	unsigned int stride;
+	uint64_t modifier;
 
 	switch (pformat) {
 	case FORMAT_RGB888:
@@ -1665,13 +1664,7 @@ static void create_fb(enum pixel_format pformat, int width, int height,
 
 	igt_warn_on(plane == PLANE_CUR && tiling != TILING_LINEAR);
 
-	igt_calc_fb_size(drm.fd, width, height, format, modifier, &size,
-			 &stride);
-
-	igt_create_fb_with_bo_size(drm.fd, width, height, format, modifier,
-				   IGT_COLOR_YCBCR_BT709,
-				   IGT_COLOR_YCBCR_LIMITED_RANGE,
-				   fb, size, stride);
+	igt_create_fb(drm.fd, width, height, format, modifier, fb);
 }
 
 static uint32_t pick_color(struct igt_fb *fb, enum color ecolor)
-- 
2.44.2


  parent reply	other threads:[~2024-06-25 17:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 17:40 [PATCH i-g-t 0/6] lib: igt_fb/rendercopy fixes/cleanups Ville Syrjala
2024-06-25 17:40 ` [PATCH i-g-t 1/6] lib/rendercopy: Add deltas to all surface relocs Ville Syrjala
2024-06-27 11:22   ` [PATCH i-g-t v2 " Ville Syrjala
2024-07-02  5:49     ` Zbigniew Kempczyński
2024-07-02 22:53       ` Ville Syrjälä
2024-06-25 17:40 ` [PATCH i-g-t 2/6] tests/kms_big_fb: Use igt_fb_create_intel_buf() Ville Syrjala
2024-07-02  5:57   ` Zbigniew Kempczyński
2024-06-25 17:40 ` Ville Syrjala [this message]
2024-06-25 17:40 ` [PATCH i-g-t 4/6] lib/igt_fb: Make igt_calc_fb_size() somewhat usable Ville Syrjala
2024-06-25 17:40 ` [PATCH i-g-t 5/6] lib/rendercopy: Always setup clear color for TGL Ville Syrjala
2024-06-25 17:40 ` [PATCH i-g-t 6/6] lib/rendercopy: Enable clear color consistently Ville Syrjala
2024-07-02 17:20   ` Ville Syrjälä
2024-06-25 18:52 ` ✓ CI.xeBAT: success for lib: igt_fb/rendercopy fixes/cleanups Patchwork
2024-06-25 18:55 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-25 22:35 ` ✗ CI.xeFULL: " Patchwork
2024-06-26 11:22 ` ✗ Fi.CI.BAT: failure for lib: igt_fb/rendercopy fixes/cleanups (rev2) Patchwork
2024-06-26 11:41 ` ✓ CI.xeBAT: success " Patchwork
2024-06-26 15:24 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-28 12:03 ` ✓ CI.xeBAT: success for lib: igt_fb/rendercopy fixes/cleanups (rev3) Patchwork
2024-06-28 12:11 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-28 13:33 ` ✓ CI.xeFULL: success " Patchwork
2024-06-29 13:53 ` ✓ CI.xeBAT: success for lib: igt_fb/rendercopy fixes/cleanups (rev4) Patchwork
2024-06-29 14:02 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-29 14:54 ` ✓ CI.xeFULL: success " Patchwork
2024-07-02 19:37 ` ✓ CI.xeBAT: success for lib: igt_fb/rendercopy fixes/cleanups (rev5) Patchwork
2024-07-02 19:46 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-07-02 20:36 ` ✓ CI.xeFULL: success " Patchwork
2024-07-03 12:30 ` ✓ Fi.CI.BAT: success for lib: igt_fb/rendercopy fixes/cleanups (rev6) Patchwork
2024-07-03 12:33 ` ✓ CI.xeBAT: " Patchwork
2024-07-03 14:40 ` ✓ CI.xeFULL: " Patchwork
2024-07-04  0:09 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625174032.10398-4-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox