Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: [PATCH i-g-t 02/37] lib/rendercopy: Add deltas to all surface relocs
Date: Wed,  3 Jul 2024 02:27:42 +0300	[thread overview]
Message-ID: <20240702232817.31147-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240702232817.31147-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

In order to copy stuff not at offset 0 in the BO we need
to include the delta in the relocs/etc.

v2: fix the address in the command packets
v3: Fix intel_bb_offset_reloc_with_delta() argument order on gen7

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/rendercopy_gen4.c | 11 ++++++-----
 lib/rendercopy_gen6.c | 11 ++++++-----
 lib/rendercopy_gen7.c | 11 ++++++-----
 lib/rendercopy_gen8.c | 13 +++++++------
 lib/rendercopy_gen9.c | 13 +++++++------
 lib/rendercopy_i830.c | 10 +++++++---
 lib/rendercopy_i915.c |  6 ++++--
 7 files changed, 43 insertions(+), 32 deletions(-)

diff --git a/lib/rendercopy_gen4.c b/lib/rendercopy_gen4.c
index 8536d6b632c5..8582e0efb886 100644
--- a/lib/rendercopy_gen4.c
+++ b/lib/rendercopy_gen4.c
@@ -148,11 +148,12 @@ gen4_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst)
 	ss->ss0.data_return_format = SURFACERETURNFORMAT_FLOAT32;
 	ss->ss0.color_blend = 1;
 
-	address = intel_bb_offset_reloc(ibb, buf->handle,
-					read_domain, write_domain,
-					intel_bb_offset(ibb) + 4,
-					buf->addr.offset);
-	ss->ss1.base_addr = (uint32_t) address;
+	address = intel_bb_offset_reloc_with_delta(ibb, buf->handle,
+						   read_domain, write_domain,
+						   buf->surface[0].offset,
+						   intel_bb_offset(ibb) + 4,
+						   buf->addr.offset);
+	ss->ss1.base_addr = address + buf->surface[0].offset;
 
 	ss->ss2.height = intel_buf_height(buf) - 1;
 	ss->ss2.width  = intel_buf_width(buf) - 1;
diff --git a/lib/rendercopy_gen6.c b/lib/rendercopy_gen6.c
index e941257eb606..ec197661702f 100644
--- a/lib/rendercopy_gen6.c
+++ b/lib/rendercopy_gen6.c
@@ -91,11 +91,12 @@ gen6_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst)
 	ss->ss0.data_return_format = SURFACERETURNFORMAT_FLOAT32;
 	ss->ss0.color_blend = 1;
 
-	address = intel_bb_offset_reloc(ibb, buf->handle,
-					read_domain, write_domain,
-					intel_bb_offset(ibb) + 4,
-					buf->addr.offset);
-	ss->ss1.base_addr = (uint32_t) address;
+	address = intel_bb_offset_reloc_with_delta(ibb, buf->handle,
+						   read_domain, write_domain,
+						   buf->surface[0].offset,
+						   intel_bb_offset(ibb) + 4,
+						   buf->addr.offset);
+	ss->ss1.base_addr = address + buf->surface[0].offset;
 
 	ss->ss2.height = intel_buf_height(buf) - 1;
 	ss->ss2.width  = intel_buf_width(buf) - 1;
diff --git a/lib/rendercopy_gen7.c b/lib/rendercopy_gen7.c
index 9fadb0772e9e..e3657b5d1035 100644
--- a/lib/rendercopy_gen7.c
+++ b/lib/rendercopy_gen7.c
@@ -86,11 +86,12 @@ gen7_bind_buf(struct intel_bb *ibb,
 		 gen7_tiling_bits(buf->tiling) |
 		format << GEN7_SURFACE_FORMAT_SHIFT);
 
-	address = intel_bb_offset_reloc(ibb, buf->handle,
-					read_domain, write_domain,
-					intel_bb_offset(ibb) + 4,
-					buf->addr.offset);
-	ss[1] = address;
+	address = intel_bb_offset_reloc_with_delta(ibb, buf->handle,
+						   read_domain, write_domain,
+						   buf->surface[0].offset,
+						   intel_bb_offset(ibb) + 4,
+						   buf->addr.offset);
+	ss[1] = address + buf->surface[0].offset;
 	ss[2] = ((intel_buf_width(buf) - 1)  << GEN7_SURFACE_WIDTH_SHIFT |
 		 (intel_buf_height(buf) - 1) << GEN7_SURFACE_HEIGHT_SHIFT);
 	ss[3] = (buf->surface[0].stride - 1) << GEN7_SURFACE_PITCH_SHIFT;
diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
index bbfa6d28f525..23bea56ad1ba 100644
--- a/lib/rendercopy_gen8.c
+++ b/lib/rendercopy_gen8.c
@@ -109,12 +109,13 @@ gen8_bind_buf(struct intel_bb *ibb,
 		ss->ss1.memory_object_control = BDW_MOCS_PTE |
 			BDW_MOCS_TC_L3_PTE | BDW_MOCS_AGE(0);
 
-	address = intel_bb_offset_reloc(ibb, buf->handle,
-					read_domain, write_domain,
-					intel_bb_offset(ibb) + 4 * 8,
-					buf->addr.offset);
-	ss->ss8.base_addr = address;
-	ss->ss9.base_addr_hi = address >> 32;
+	address = intel_bb_offset_reloc_with_delta(ibb, buf->handle,
+						   read_domain, write_domain,
+						   buf->surface[0].offset,
+						   intel_bb_offset(ibb) + 4 * 8,
+						   buf->addr.offset);
+	ss->ss8.base_addr = (address + buf->surface[0].offset);
+	ss->ss9.base_addr_hi = (address + buf->surface[0].offset) >> 32;
 
 	ss->ss2.height = intel_buf_height(buf) - 1;
 	ss->ss2.width  = intel_buf_width(buf) - 1;
diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index 62a365f3c2f4..5ee4c89f5cdb 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -210,12 +210,13 @@ gen9_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst,
 	if (intel_buf_pxp(buf))
 		ss->ss1.pxp = 1;
 
-	address = intel_bb_offset_reloc(ibb, buf->handle,
-					read_domain, write_domain,
-					intel_bb_offset(ibb) + 4 * 8,
-					buf->addr.offset);
-	ss->ss8.base_addr = address;
-	ss->ss9.base_addr_hi = address >> 32;
+	address = intel_bb_offset_reloc_with_delta(ibb, buf->handle,
+						   read_domain, write_domain,
+						   buf->surface[0].offset,
+						   intel_bb_offset(ibb) + 4 * 8,
+						   buf->addr.offset);
+	ss->ss8.base_addr = (address + buf->surface[0].offset);
+	ss->ss9.base_addr_hi = (address + buf->surface[0].offset) >> 32;
 
 	ss->ss2.height = intel_buf_height(buf) - 1;
 	ss->ss2.width  = intel_buf_width(buf) - 1;
diff --git a/lib/rendercopy_i830.c b/lib/rendercopy_i830.c
index 4c4271493b4b..4b0ea3b859e2 100644
--- a/lib/rendercopy_i830.c
+++ b/lib/rendercopy_i830.c
@@ -158,8 +158,10 @@ static void gen2_emit_target(struct intel_bb *ibb,
 	intel_bb_out(ibb, _3DSTATE_BUF_INFO_CMD);
 	intel_bb_out(ibb, BUF_3D_ID_COLOR_BACK | tiling |
 		     BUF_3D_PITCH(dst->surface[0].stride));
-	intel_bb_emit_reloc(ibb, dst->handle, I915_GEM_DOMAIN_RENDER,
-			    I915_GEM_DOMAIN_RENDER, 0, dst->addr.offset);
+	intel_bb_emit_reloc(ibb, dst->handle,
+			    I915_GEM_DOMAIN_RENDER, I915_GEM_DOMAIN_RENDER,
+			    dst->surface[0].offset,
+			    dst->addr.offset);
 
 	intel_bb_out(ibb, _3DSTATE_DST_BUF_VARS_CMD);
 	intel_bb_out(ibb, format |
@@ -199,7 +201,9 @@ static void gen2_emit_texture(struct intel_bb *ibb,
 		tiling |= TM0S1_TILE_WALK;
 
 	intel_bb_out(ibb, _3DSTATE_LOAD_STATE_IMMEDIATE_2 | LOAD_TEXTURE_MAP(unit) | 4);
-	intel_bb_emit_reloc(ibb, src->handle, I915_GEM_DOMAIN_SAMPLER, 0, 0,
+	intel_bb_emit_reloc(ibb, src->handle,
+			    I915_GEM_DOMAIN_SAMPLER, 0,
+			    src->surface[0].offset,
 			    src->addr.offset);
 	intel_bb_out(ibb, (intel_buf_height(src) - 1) << TM0S1_HEIGHT_SHIFT |
 		     (intel_buf_width(src) - 1) << TM0S1_WIDTH_SHIFT |
diff --git a/lib/rendercopy_i915.c b/lib/rendercopy_i915.c
index 3e421301e6a6..94cdfb99af9a 100644
--- a/lib/rendercopy_i915.c
+++ b/lib/rendercopy_i915.c
@@ -112,7 +112,8 @@ void gen3_render_copyfunc(struct intel_bb *ibb,
 		intel_bb_out(ibb, (1 << TEX_COUNT) - 1);
 		intel_bb_emit_reloc(ibb, src->handle,
 				    I915_GEM_DOMAIN_SAMPLER, 0,
-				    0, src->addr.offset);
+				    src->surface[0].offset,
+				    src->addr.offset);
 		intel_bb_out(ibb, format_bits | tiling_bits |
 			     (intel_buf_height(src) - 1) << MS3_HEIGHT_SHIFT |
 			     (intel_buf_width(src) - 1) << MS3_WIDTH_SHIFT);
@@ -155,7 +156,8 @@ void gen3_render_copyfunc(struct intel_bb *ibb,
 			     BUF_3D_PITCH(dst->surface[0].stride));
 		intel_bb_emit_reloc(ibb, dst->handle,
 				    I915_GEM_DOMAIN_RENDER, I915_GEM_DOMAIN_RENDER,
-				    0, dst->addr.offset);
+				    dst->surface[0].offset,
+				    dst->addr.offset);
 
 		intel_bb_out(ibb, _3DSTATE_DST_BUF_VARS_CMD);
 		intel_bb_out(ibb, format_bits |
-- 
2.44.2


  parent reply	other threads:[~2024-07-02 23:28 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 23:27 [PATCH i-g-t 00/37] Intel CCS + 10bpc/fp16 stuff Ville Syrjala
2024-07-02 23:27 ` [PATCH i-g-t 01/37] lib/intel_aux_pgtable: Library to add support for RGB16161616_64B format Ville Syrjala
2024-08-27 15:16   ` Juha-Pekka Heikkila
2024-08-28 13:03     ` Ville Syrjälä
2024-07-02 23:27 ` Ville Syrjala [this message]
2024-07-02 23:27 ` [PATCH i-g-t 03/37] tests/kms_big_fb: Use igt_fb_create_intel_buf() Ville Syrjala
2024-07-02 23:27 ` [PATCH i-g-t 04/37] tests/kms_frontbuffer_tracking: Use igt_create_fb() Ville Syrjala
2024-08-27 15:17   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 05/37] lib/igt_fb: Make igt_calc_fb_size() somewhat usable Ville Syrjala
2024-07-02 23:27 ` [PATCH i-g-t 06/37] lib/rendercopy: Always setup clear color for TGL Ville Syrjala
2024-07-02 23:27 ` [PATCH i-g-t 07/37] lib/rendercopy: Don't skip clearcolor on flat CCS Ville Syrjala
2024-08-27 15:16   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 08/37] lib/rendercopy: Fix fastclear scaling Ville Syrjala
2024-08-27 15:17   ` Juha-Pekka Heikkila
2024-08-29 15:11     ` Ville Syrjälä
2024-07-02 23:27 ` [PATCH i-g-t 09/37] lib/rendercopy: Extract gen4_surface_format() Ville Syrjala
2024-08-27 15:22   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 10/37] lib/rendercopy: Extract {dg2, lnl}_compression_format() Ville Syrjala
2024-08-27 15:24   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 11/37] lib/rendercopy: Add specific support for 2:10:10:10 formats Ville Syrjala
2024-08-27 16:03   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 12/37] lib/rendercopy: Use the proper compression format for 10bpc on dg2/lnl+ Ville Syrjala
2024-08-27 16:04   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 13/37] lib/rendercopy: Use the proper compression format for 16bpc " Ville Syrjala
2024-08-27 16:25   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 14/37] lib/igt_fb: Extract is_gen12_rc_ccs_cc_modifier() Ville Syrjala
2024-08-27 16:26   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 15/37] lib/igt_fb: Extract ccs_needs_enginecopy() Ville Syrjala
2024-08-27 16:34   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 16/37] lib/igt_fb: Require enginecopy for clear color Ville Syrjala
2024-08-27 16:37   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 17/37] lib/igt_fb: Expose igt_fb_is_ccs_modifier() Ville Syrjala
2024-08-27 16:43   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 18/37] lib/igt_fb: Expose igt_fb_is_gen12_rc_ccs_cc_modifier() Ville Syrjala
2024-08-27 16:45   ` Juha-Pekka Heikkila
2024-07-02 23:27 ` [PATCH i-g-t 19/37] lib/igt_fb: Expose igt_fb_is_gen12_mc_ccs_modifier() Ville Syrjala
2024-08-27 16:46   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 20/37] lib/igt_fb: Adjust how we pick the blitter compression format Ville Syrjala
2024-08-27 16:50   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 21/37] lib/igt_fb: Add DRM_FORMAT_XRGB2101010 compression format for the Ville Syrjala
2024-08-27 16:52   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 22/37] lib/igt_fb: Add 16bpc compression format for the blitter Ville Syrjala
2024-08-27 16:53   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 23/37] lib/igt_fb: Fix planar block copy Ville Syrjala
2024-08-27 16:55   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 24/37] lib/igt_fb: Fix blitter compression format handling Ville Syrjala
2024-08-27 17:00   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 25/37] lib/igt_fb: Try to fix block copy media compression handling Ville Syrjala
2024-08-27 17:04   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 26/37] lib/igt_fb: Assert that we have no clear color when using the bltter Ville Syrjala
2024-08-27 17:09   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 27/37] lib/vebox: Add support for fp16 RGB formats Ville Syrjala
2024-08-27 17:20   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 28/37] lib/vebox: Add 10bpc support Ville Syrjala
2024-08-27 17:39   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 29/37] lib/igt_fb: Treat 2:10:10:10 properly Ville Syrjala
2024-08-27 17:41   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 30/37] tests/kms_plane: Extract skip_format_mod() Ville Syrjala
2024-08-27 17:44   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 31/37] tests/kms_plane: Skip 10bpc formats with media compression Ville Syrjala
2024-08-27 17:46   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 32/37] tests/kms_ccs: Reuse igt_fb_is_gen12_rc_ccs_cc_modifier() Ville Syrjala
2024-08-27 17:47   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 33/37] tests/kms_ccs: Correctly check clear color for 10bpc formats Ville Syrjala
2024-08-27 17:48   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 34/37] tests/kms_ccs: Correctly check clear color for fp16 formats Ville Syrjala
2024-07-02 23:28 ` [PATCH i-g-t 35/37] tests/kms_ccs: Skip 10bpc formats with media compression Ville Syrjala
2024-07-02 23:28 ` [PATCH i-g-t 36/37] tests/kms_ccs: Skip testing on identical plane types Ville Syrjala
2024-08-27 17:50   ` Juha-Pekka Heikkila
2024-07-02 23:28 ` [PATCH i-g-t 37/37] tests/kms_ccs: Provide a hint as to what we're testing Ville Syrjala
2024-08-27 17:51   ` Juha-Pekka Heikkila
2024-07-03 12:55 ` ✓ CI.xeBAT: success for Intel CCS + 10bpc/fp16 stuff Patchwork
2024-07-03 13:10 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-07-03 13:17   ` Ville Syrjälä
2024-07-03 15:31 ` ✓ CI.xeFULL: success " Patchwork
2024-07-05 16:38 ` ✓ Fi.CI.BAT: success for Intel CCS + 10bpc/fp16 stuff (rev2) Patchwork
2024-07-05 16:43 ` ✓ CI.xeBAT: " Patchwork
2024-07-05 20:04 ` ✓ CI.xeFULL: " Patchwork
2024-07-06 19:07 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-07-13 13:29 ` ✓ CI.xeBAT: success for Intel CCS + 10bpc/fp16 stuff (rev3) Patchwork
2024-07-13 13:39 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-13 14:22 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-15  7:46 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240702232817.31147-3-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox