From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org, lucas.demarchi@intel.com
Subject: [PATCH i-g-t v2 10/10] tests/intel/xe_drm_fdinfo: Ensure queue destroy records load correctly
Date: Tue, 2 Jul 2024 17:25:32 -0700 [thread overview]
Message-ID: <20240703002532.3156277-11-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20240703002532.3156277-1-umesh.nerlige.ramappa@intel.com>
If the exec queue is destroyed before recording the utilization, make
sure the load is correctly captured.
v2:
- s/measured_usleep/usleep
- remove xe_ prefix from helpers/structures
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/intel/xe_drm_fdinfo.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tests/intel/xe_drm_fdinfo.c b/tests/intel/xe_drm_fdinfo.c
index f1e06991c..b3c865757 100644
--- a/tests/intel/xe_drm_fdinfo.c
+++ b/tests/intel/xe_drm_fdinfo.c
@@ -70,6 +70,9 @@
* SUBTEST: drm-parallel-busy-idle-isolation
* Description: Check that parallel engine load does not spill over to other drm clients
*
+ * SUBTEST: drm-busy-exec-queue-destroy-idle
+ * Description: Destroy exec queue before idle and ensure load is accurate
+ *
* SUBTEST: drm-total-resident
* Description: Create and compare total and resident memory consumption by client
*
@@ -567,6 +570,32 @@ check_results(struct pceu_cycles *s1, struct pceu_cycles *s2,
igt_assert(!percent);
}
+static void
+single_destroy_queue(int fd, struct drm_xe_engine_class_instance *hwe)
+{
+ struct pceu_cycles pceu1[DRM_XE_ENGINE_CLASS_COMPUTE + 1];
+ struct pceu_cycles pceu2[DRM_XE_ENGINE_CLASS_COMPUTE + 1];
+ struct spin_ctx *ctx = NULL;
+ uint32_t vm;
+
+ vm = xe_vm_create(fd, 0, 0);
+ ctx = spin_ctx_init(fd, hwe, vm, 1, 1);
+ spin_sync_start(fd, ctx);
+
+ read_engine_cycles(fd, pceu1);
+ usleep(batch_duration_ns / 1000);
+
+ /* destroy queue before sampling again */
+ spin_sync_end(fd, ctx);
+ spin_ctx_destroy(fd, ctx);
+
+ read_engine_cycles(fd, pceu2);
+
+ xe_vm_destroy(fd, vm);
+
+ check_results(pceu1, pceu2, hwe->engine_class, 1, TEST_BUSY);
+}
+
static void
single(int fd, struct drm_xe_engine_class_instance *hwe, int width, int count,
unsigned int flags)
@@ -837,6 +866,10 @@ igt_main
xe_for_each_multi_engine(xe, hwe, count)
single(xe, hwe, count, 1, TEST_BUSY | TEST_TRAILING_IDLE | TEST_ISOLATION);
+ igt_subtest("drm-busy-exec-queue-destroy-idle")
+ xe_for_each_engine(xe, hwe)
+ single_destroy_queue(xe, hwe);
+
igt_describe("Create and compare total and resident memory consumption by client");
igt_subtest("drm-total-resident")
test_total_resident(xe);
--
2.38.1
next prev parent reply other threads:[~2024-07-03 0:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 0:25 [PATCH i-g-t v2 00/10] Add per-client engine utilization tests Umesh Nerlige Ramappa
2024-07-03 0:25 ` [PATCH i-g-t v2 01/10] tests/intel/xe_drm_fdinfo: Rename basic to basic-memory test Umesh Nerlige Ramappa
2024-07-11 12:00 ` Lucas De Marchi
2024-07-11 17:39 ` Umesh Nerlige Ramappa
2024-07-11 20:36 ` Lucas De Marchi
2024-07-30 12:41 ` Kamil Konieczny
2024-07-03 0:25 ` [PATCH i-g-t v2 02/10] tests/intel/xe_drm_fdinfo: Add basic-engine-utilization test Umesh Nerlige Ramappa
2024-07-11 12:03 ` Lucas De Marchi
2024-07-31 3:40 ` Lucas De Marchi
2024-07-03 0:25 ` [PATCH i-g-t v2 03/10] tests/intel/xe_drm_fdinfo: Add helper to read utilization for all classes Umesh Nerlige Ramappa
2024-07-11 13:40 ` Lucas De Marchi
2024-07-11 19:54 ` Umesh Nerlige Ramappa
2024-07-30 0:23 ` Lucas De Marchi
2024-07-03 0:25 ` [PATCH i-g-t v2 04/10] tests/intel/xe_drm_fdinfo: Add helpers for spinning batches Umesh Nerlige Ramappa
2024-07-11 12:46 ` Lucas De Marchi
2024-07-11 18:29 ` Umesh Nerlige Ramappa
2024-07-12 0:04 ` Matthew Brost
2024-08-15 16:46 ` Lucas De Marchi
2024-07-03 0:25 ` [PATCH i-g-t v2 05/10] tests/intel/xe_drm_fdinfo: Add single engine tests Umesh Nerlige Ramappa
2024-07-11 13:20 ` Lucas De Marchi
2024-07-11 19:13 ` Umesh Nerlige Ramappa
2024-07-11 21:34 ` Lucas De Marchi
2024-07-11 22:45 ` Umesh Nerlige Ramappa
2024-07-03 0:25 ` [PATCH i-g-t v2 06/10] tests/intel/xe_drm_fdinfo: Add tests to verify all class utilization Umesh Nerlige Ramappa
2024-07-03 0:25 ` [PATCH i-g-t v2 07/10] tests/intel/xe_drm_fdinfo: Add an iterator for virtual engines Umesh Nerlige Ramappa
2024-07-11 13:34 ` Lucas De Marchi
2024-07-11 18:31 ` Umesh Nerlige Ramappa
2024-07-11 22:30 ` Lucas De Marchi
2024-07-12 0:17 ` Matthew Brost
2024-07-03 0:25 ` [PATCH i-g-t v2 08/10] tests/intel/xe_drm_fdinfo: Add tests " Umesh Nerlige Ramappa
2024-07-03 0:25 ` [PATCH i-g-t v2 09/10] tests/intel/xe_drm_fdinfo: Add tests for parallel engines Umesh Nerlige Ramappa
2024-07-03 0:25 ` Umesh Nerlige Ramappa [this message]
2024-07-03 14:41 ` ✗ Fi.CI.BUILD: failure for Add per-client engine utilization tests (rev3) Patchwork
2024-07-04 17:14 ` ✓ CI.xeBAT: success for Add per-client engine utilization tests (rev4) Patchwork
2024-07-04 17:24 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-07-04 22:18 ` ✓ CI.xeFULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703002532.3156277-11-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox