Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: zbigniew.kempczynski@intel.com, kamil.konieczny@linux.intel.com,
	michal.wajdeczko@intel.com
Subject: [PATCH i-g-t] lib/igt_device_scan: Skip attributes in subdirectories
Date: Fri,  5 Jul 2024 16:10:44 +0200	[thread overview]
Message-ID: <20240705141044.115059-1-marcin.bernatowicz@linux.intel.com> (raw)

Skip reading attributes in subdirectories as they are not used for
filtering. This change improves speed and reduces the impact of
non-DRM related component bugs on testing, such as the ASPM exposed
link/l1_aspm attribute issue. After removing a Virtual Function (VF),
accessing the link/l1_aspm attribute on the Physical Function (PF)
leads to NPD.

v2: removed unrelated changes, improved description (Michal)

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
---
 lib/igt_device_scan.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 9a2da3d62..8e2297087 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -448,6 +448,10 @@ static bool is_on_blacklist(const char *what)
 	if (what == NULL)
 		return false;
 
+	/* Skip attributes in subdirectories */
+	if (strchr(what, '/') != NULL)
+		return true;
+
 	while ((key = keys[i++])) {
 		if (strcmp(key, what) == 0)
 			return true;
-- 
2.31.1


             reply	other threads:[~2024-07-05 14:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 14:10 Marcin Bernatowicz [this message]
2024-07-05 16:00 ` ✓ CI.xeBAT: success for lib/igt_device_scan: Skip attributes in subdirectories (rev2) Patchwork
2024-07-05 16:07 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-05 18:32 ` ✓ CI.xeFULL: " Patchwork
2024-07-06 18:59 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-07-08  7:00 ` [PATCH i-g-t] lib/igt_device_scan: Skip attributes in subdirectories Zbigniew Kempczyński
  -- strict thread matches above, loose matches on Subject: below --
2024-07-04 16:44 Marcin Bernatowicz
2024-07-08  6:58 ` Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240705141044.115059-1-marcin.bernatowicz@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox