Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
	Adam Miszczak <adam.miszczak@linux.intel.com>,
	Lukasz Laguna <lukasz.laguna@intel.com>,
	Jakub Kolakowski <jakub1.kolakowski@intel.com>,
	Michal Wajdeczko <Michal.Wajdeczko@intel.com>
Subject: [PATCH i-g-t 2/2] tests/sriov_basic: Extract enable-vfs-bind-unbind-each-numvfs-all subtest
Date: Wed, 10 Jul 2024 17:24:46 +0200	[thread overview]
Message-ID: <20240710152446.827476-3-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20240710152446.827476-1-marcin.bernatowicz@linux.intel.com>

Extract the 'enable-vfs-bind-unbind-each-numvfs-all' subtest to
simplify blocklist management. Currently, there is no straightforward
method to block dynamic subsubtests, and running all of them becomes
too time-consuming.

Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Michal Wajdeczko <Michal.Wajdeczko@intel.com>
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
---
 tests/sriov_basic.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/tests/sriov_basic.c b/tests/sriov_basic.c
index 95a462709..36bca4149 100644
--- a/tests/sriov_basic.c
+++ b/tests/sriov_basic.c
@@ -62,7 +62,12 @@ static void enable_vfs_autoprobe_on(int pf_fd, unsigned int num_vfs)
 /**
  * SUBTEST: enable-vfs-bind-unbind-each
  * Description:
- *   Verify VFs enabling with binding and unbinding the driver one be one to each of them
+ *   Verify VFs enabling with binding and unbinding the driver one by one to each of them.
+ *   Version includes dynamic subtests that allow specifying the number of enabled VFs as numvfs-N.
+ *
+ * SUBTEST: enable-vfs-bind-unbind-each-numvfs-all
+ * Description:
+ *   Verify the enabling of all VFs and the sequential binding and unbinding of the driver to each one.
  */
 static void enable_vfs_bind_unbind_each(int pf_fd, unsigned int num_vfs)
 {
@@ -176,10 +181,12 @@ igt_main
 				enable_vfs_bind_unbind_each(pf_fd, num_vfs);
 			}
 		}
+	}
+
+	igt_describe("Verify the enabling of all VFs and the sequential binding and unbinding of the driver to each one");
+	igt_subtest("enable-vfs-bind-unbind-each-numvfs-all") {
 		for_max_sriov_num_vfs(pf_fd, num_vfs) {
-			igt_dynamic_f("numvfs-all") {
-				enable_vfs_bind_unbind_each(pf_fd, num_vfs);
-			}
+			enable_vfs_bind_unbind_each(pf_fd, num_vfs);
 		}
 	}
 
-- 
2.31.1


  parent reply	other threads:[~2024-07-10 15:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 15:24 [PATCH i-g-t 0/2] Refactor sriov_basic test and blocklisting Marcin Bernatowicz
2024-07-10 15:24 ` [PATCH i-g-t 1/2] tests/intel-ci/xe.blocklist: Blocklist SR-IOV stress tests Marcin Bernatowicz
2024-07-10 19:00   ` Cavitt, Jonathan
2024-07-11  9:36     ` Bernatowicz, Marcin
2024-07-10 15:24 ` Marcin Bernatowicz [this message]
2024-07-10 19:03   ` [PATCH i-g-t 2/2] tests/sriov_basic: Extract enable-vfs-bind-unbind-each-numvfs-all subtest Cavitt, Jonathan
2024-07-10 17:02 ` ✓ CI.xeBAT: success for Refactor sriov_basic test and blocklisting Patchwork
2024-07-10 17:12 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-10 18:57 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-11  9:38 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240710152446.827476-3-marcin.bernatowicz@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=Michal.Wajdeczko@intel.com \
    --cc=adam.miszczak@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jakub1.kolakowski@intel.com \
    --cc=lukasz.laguna@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox