Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jeevan.b@intel.com, suraj.kandpal@intel.com,
	Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Subject: [PATCH i-g-t 1/3] tests/intel/kms_pm_dc:Add basic validation checks to achieve deep-pkgc
Date: Wed, 17 Jul 2024 19:32:23 +0530	[thread overview]
Message-ID: <20240717140225.640086-2-ramanaidu.naladala@intel.com> (raw)
In-Reply-To: <20240717140225.640086-1-ramanaidu.naladala@intel.com>

Add connector checks and test requirement validations for deep-pkgc

v2: Correct indentation and update comments (Suraj, Jeevan)

Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
---
 tests/intel/kms_pm_dc.c | 30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index e1318bfa6..8fb35a2df 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -592,31 +592,43 @@ static unsigned int read_pkgc_counter(int debugfs_root_fd)
 static void test_deep_pkgc_state(data_t *data)
 {
 	unsigned int pre_val = 0, cur_val = 0;
-	time_t start = time(NULL), duration = 2, delay;
+	time_t start = time(NULL), duration = 2, vb_delay, delay;
 	enum pipe pipe;
 	bool pkgc_flag = false;
-	bool vrr_supported = false, flip = true;
+	bool flip = true;
 
 	igt_display_t *display = &data->display;
 	igt_plane_t *primary;
 	igt_output_t *output = NULL;
 
 	for_each_pipe_with_valid_output(display, pipe, output) {
-		/* Check VRR capabilities before setting up */
+
+		if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
+			igt_skip("No eDP output found, skipping the test.\n");
+		/* DEEP PKG_C_LATENCY can be configured only for fixed refresh rates */
 		if (igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE) &&
 		    igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE)) {
-			vrr_supported = true;
+			igt_pipe_set_prop_value(display, pipe,
+						IGT_CRTC_VRR_ENABLED, false);
+			igt_assert(igt_display_try_commit_atomic(display,
+								 DRM_MODE_ATOMIC_ALLOW_MODESET,
+								 NULL) == 0);
 			break;
 		}
 	}
 
-	/* Skip the test if no VRR capable output is found */
-	if (!vrr_supported)
-		igt_skip("No VRR capable output found, skipping the test.\n");
-
 	igt_display_reset(display);
-
 	igt_output_set_pipe(output, pipe);
+	for_each_connector_mode(output) {
+		data->mode = &output->config.connector->modes[j__];
+		vb_delay = 1 * (MSECS / (data->mode->vrefresh));
+		/*
+		 * At least 5ms vblank time required to program higher
+		 * watermark levels
+		 */
+		if (vb_delay > (5 * MSEC))
+			break;
+	}
 
 	data->output = output;
 	data->mode = igt_output_get_mode(output);
-- 
2.43.0


  reply	other threads:[~2024-07-17 13:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 14:02 [PATCH i-g-t 0/3] tests/intel/kms_pm_dc: Improvise the deep-pkgc Naladala Ramanaidu
2024-07-17 14:02 ` Naladala Ramanaidu [this message]
2024-07-17 14:02 ` [PATCH i-g-t 2/3] tests/intel/kms_pm_dc: Update deep-pkgc function Naladala Ramanaidu
2024-07-17 14:02 ` [PATCH i-g-t 3/3] HAX patch do not merge Naladala Ramanaidu
2024-07-17 15:23 ` ✓ Fi.CI.BAT: success for tests/intel/kms_pm_dc: Improvise the deep-pkgc Patchwork
2024-07-17 15:24 ` ✓ CI.xeBAT: " Patchwork
2024-07-17 20:36 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-18  6:15 ` ✗ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-07-17 14:05 [PATCH i-g-t 0/3] Improvise-the-deep-pkgc Naladala Ramanaidu
2024-07-17 14:05 ` [PATCH i-g-t 1/3] tests/intel/kms_pm_dc:Add basic validation checks to achieve deep-pkgc Naladala Ramanaidu
2024-07-17 15:26   ` Kamil Konieczny
2024-07-19  9:09     ` Naladala, Ramanaidu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717140225.640086-2-ramanaidu.naladala@intel.com \
    --to=ramanaidu.naladala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox