From: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, kunal1.joshi@intel.com,
Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Subject: [PATCH i-g-t v6 2/5] tests/kms_plane_scaling: Update the multi plane scaling function arguments
Date: Thu, 18 Jul 2024 16:38:48 +0530 [thread overview]
Message-ID: <20240718110851.665102-3-ramanaidu.naladala@intel.com> (raw)
In-Reply-To: <20240718110851.665102-1-ramanaidu.naladala@intel.com>
Update the helper test_planes_scaling_combo to use a scaling_factor
for plane1 and plane2 instead of explicit width and height parameters.
This change simplifies the function interfaces and allows for testing
scenarios, where we need to recalculate the width and height based on
the display mode. Adjusted all function calls to match new argument
order.
v2: Update the function arguments (Ankit)
Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
---
tests/kms_plane_scaling.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index bd38513ab..8a69aacfd 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -913,19 +913,27 @@ static void setup_fb(int fd, int width, int height, struct igt_fb *fb)
}
static void
-test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
- enum pipe pipe, igt_output_t *output,
+test_planes_scaling_combo(data_t *d, double sf_plane1,
+ double sf_plane2,
+ enum pipe pipe,
+ igt_output_t *output,
enum scaler_combo_test_type test_type)
{
igt_display_t *display = &d->display;
drmModeModeInfo *mode;
int n_planes;
+ int w1, h1, w2, h2;
cleanup_crtc(d);
igt_output_set_pipe(output, pipe);
mode = igt_output_get_mode(output);
+ w1 = get_width(mode, sf_plane1);
+ h1 = get_height(mode, sf_plane1);
+ w2 = get_width(mode, sf_plane2);
+ h2 = get_height(mode, sf_plane2);
+
n_planes = display->pipes[pipe].n_planes;
igt_require(n_planes >= 2);
@@ -1458,14 +1466,12 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
continue;
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
- drmModeModeInfo *mode = igt_output_get_mode(output);
test_planes_scaling_combo(&data,
- get_width(mode, scaler_with_2_planes_tests[index].sf_plane1),
- get_height(mode, scaler_with_2_planes_tests[index].sf_plane1),
- get_width(mode, scaler_with_2_planes_tests[index].sf_plane2),
- get_height(mode, scaler_with_2_planes_tests[index].sf_plane2),
- pipe, output, scaler_with_2_planes_tests[index].test_type);
+ scaler_with_2_planes_tests[index].sf_plane1,
+ scaler_with_2_planes_tests[index].sf_plane2,
+ pipe, output,
+ scaler_with_2_planes_tests[index].test_type);
}
break;
}
--
2.43.0
next prev parent reply other threads:[~2024-07-18 11:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 11:08 [PATCH i-g-t v6 0/5] tests/kms_plane_scaling: Improvise the Naladala Ramanaidu
2024-07-18 11:08 ` [PATCH i-g-t v6 1/5] tests/kms_plane_scaling: Update the single plane scaling function arguments Naladala Ramanaidu
2024-07-18 11:08 ` Naladala Ramanaidu [this message]
2024-07-18 11:08 ` [PATCH i-g-t v6 3/5] tests/kms_plane_scaling: Find display mode fitting in BW Naladala Ramanaidu
2024-07-18 11:08 ` [PATCH i-g-t v6 4/5] tests/kms_plane_scaling: Find display mode fitting in BW for rotations Naladala Ramanaidu
2024-07-18 11:08 ` [PATCH i-g-t v6 5/5] HAX patch do not merge Naladala Ramanaidu
2024-07-18 12:53 ` ✗ CI.xeBAT: failure for tests/kms_plane_scaling: Improvise the Patchwork
2024-07-18 16:42 ` ✗ CI.xeFULL: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-07-18 11:11 [PATCH i-g-t v6 0/5] tests/kms_plane_scaling: Improvise the scaling BW issues Naladala Ramanaidu
2024-07-18 11:11 ` [PATCH i-g-t v6 2/5] tests/kms_plane_scaling: Update the multi plane scaling function arguments Naladala Ramanaidu
2024-07-18 12:20 ` Nautiyal, Ankit K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718110851.665102-3-ramanaidu.naladala@intel.com \
--to=ramanaidu.naladala@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox