Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	Ashutosh Dixit <ashutosh.dixit@intel.com>
Subject: [PATCH i-g-t] lib/xe/oa: Handle SIMD16_EU_PER_DSS
Date: Mon, 22 Jul 2024 12:07:17 -0700	[thread overview]
Message-ID: <20240722190717.57192-1-lucas.demarchi@intel.com> (raw)

Handle SIMD16_EU_PER_DSS the same way EU_PER_DSS is. Since this function
is mixing information from hwconfig and the topo query, this should be
more correct as now the numbers from the query match the hwconfig.

This fixes the assert triggering in the default case because
SIMD16_EU_PER_DSS was not handled:

	(xe_oa:4511) CRITICAL: Test assertion failure function xe_fill_topology_info, file ../lib/xe/xe_oa.c:532:
	(xe_oa:4511) CRITICAL: Failed assertion: 0
	(xe_oa:4511) CRITICAL: Last errno: 2, No such file or directory
	Test xe_oa failed.

Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/xe/xe_oa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/xe/xe_oa.c b/lib/xe/xe_oa.c
index 797458439..4764ed1fc 100644
--- a/lib/xe/xe_oa.c
+++ b/lib/xe/xe_oa.c
@@ -521,6 +521,7 @@ xe_fill_topology_info(int drm_fd, uint32_t device_id, uint32_t *topology_size)
 			ptr += ptopo->subslice_stride;
 			break;
 		case DRM_XE_TOPO_EU_PER_DSS:
+		case DRM_XE_TOPO_SIMD16_EU_PER_DSS:
 			for (i = 0; i < ptopo->max_subslices; i++) {
 				memcpy(ptr, topo->mask, ptopo->eu_stride);
 				ptr += ptopo->eu_stride;
-- 
2.43.0


             reply	other threads:[~2024-07-22 19:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 19:07 Lucas De Marchi [this message]
2024-07-22 18:53 ` [PATCH i-g-t] lib/xe/oa: Handle SIMD16_EU_PER_DSS Dixit, Ashutosh
2024-07-22 20:48 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-07-22 20:49 ` ✓ CI.xeBAT: " Patchwork
2024-07-22 23:01 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-23 12:28 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722190717.57192-1-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox