From: Pallavi Mishra <pallavi.mishra@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Pallavi Mishra <pallavi.mishra@intel.com>
Subject: [PATCH] tests/intel/xe_exec_store: Modify test for Priority Mem Read feature
Date: Thu, 25 Jul 2024 01:10:06 +0530 [thread overview]
Message-ID: <20240724194006.1201429-1-pallavi.mishra@intel.com> (raw)
Now that KMD supports Priority Mem Read feature, care needs to
be taken to avoid RAW hazards which may get introduced due to
unordered read and writes. Inorder to prevent this insert
MI_MEM_FENCE which will ensure data coherency in such
scenarios.
KMD patch to enable Priority Mem Read:
https://patchwork.freedesktop.org/series/134038/
Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
include/intel_gpu_commands.h | 2 ++
tests/intel/xe_exec_store.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/intel_gpu_commands.h b/include/intel_gpu_commands.h
index fe734c4bb..cd281ba89 100644
--- a/include/intel_gpu_commands.h
+++ b/include/intel_gpu_commands.h
@@ -89,6 +89,7 @@
#define MI_DISPLAY_FLIP_SKL_PLANE_3_A (7 << 8)
#define MI_DISPLAY_FLIP_SKL_PLANE_3_B (8 << 8)
#define MI_DISPLAY_FLIP_SKL_PLANE_3_C (9 << 8)
+#define MI_MEM_FENCE MI_INSTR(0x09, 0)
#define MI_SEMAPHORE_MBOX MI_INSTR(0x16, 1) /* gen6, gen7 */
#define MI_SEMAPHORE_GLOBAL_GTT (1<<22)
#define MI_SEMAPHORE_UPDATE (1<<21)
@@ -192,6 +193,7 @@
#define MI_OPCODE(x) (((x) >> 23) & 0x3f)
#define IS_MI_LRI_CMD(x) (MI_OPCODE(x) == MI_OPCODE(MI_INSTR(0x22, 0)))
#define MI_LRI_LEN(x) (((x) & 0xff) + 1)
+#define MI_WRITE_FENCE (3 << 0)
/*
* 3D instructions used by the kernel
diff --git a/tests/intel/xe_exec_store.c b/tests/intel/xe_exec_store.c
index c872c22d5..fb99e53b7 100644
--- a/tests/intel/xe_exec_store.c
+++ b/tests/intel/xe_exec_store.c
@@ -63,6 +63,7 @@ static void cond_batch(struct data *data, uint64_t addr, int value)
data->batch[b++] = MI_ATOMIC | MI_ATOMIC_INC;
data->batch[b++] = sdi_addr;
data->batch[b++] = sdi_addr >> 32;
+ data->batch[b++] = MI_MEM_FENCE | MI_WRITE_FENCE;
data->batch[b++] = MI_CONDITIONAL_BATCH_BUFFER_END | MI_DO_COMPARE | 5 << 12 | 2;
data->batch[b++] = value;
data->batch[b++] = sdi_addr;
--
2.25.1
next reply other threads:[~2024-07-24 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 19:40 Pallavi Mishra [this message]
2024-07-24 20:17 ` ✓ CI.xeBAT: success for tests/intel/xe_exec_store: Modify test for Priority Mem Read feature Patchwork
2024-07-24 20:26 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-24 22:47 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-26 15:10 ` Mishra, Pallavi
2024-07-25 0:31 ` ✗ Fi.CI.IGT: " Patchwork
2024-07-26 15:06 ` Mishra, Pallavi
2024-07-26 21:29 ` [PATCH] " Matt Roper
2024-07-29 15:40 ` Mishra, Pallavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240724194006.1201429-1-pallavi.mishra@intel.com \
--to=pallavi.mishra@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox