From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Subject: [i-g-t V2 1/2] lib/drmtest: Ensure the XE driver is idle before starting a test
Date: Thu, 25 Jul 2024 09:48:03 +0530 [thread overview]
Message-ID: <20240725041803.1764959-1-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240724070544.1734040-1-bhanuprakash.modem@intel.com>
Re-use the existing i915's exit handler to make sure that the
XE driver is idle before starting the subtest.
V2:
- Add some delay after attempting the gt reset
- Cover drm render device path too
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/294
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
lib/drmtest.c | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index f8810da43..90885ec36 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -64,6 +64,7 @@
#include "intel_reg.h"
#include "ioctl_wrappers.h"
#include "igt_dummyload.h"
+#include "xe/xe_gt.h"
#include "xe/xe_query.h"
/**
@@ -663,12 +664,17 @@ static void __cancel_work_at_exit(int fd)
{
igt_terminate_spins(); /* for older kernels */
- igt_params_set(fd, "reset", "%u", -1u /* any method */);
- igt_drop_caches_set(fd,
- /* cancel everything */
- DROP_RESET_ACTIVE | DROP_RESET_SEQNO |
- /* cleanup */
- DROP_ACTIVE | DROP_RETIRE | DROP_IDLE | DROP_FREED);
+ if (is_xe_device(fd)) {
+ xe_force_gt_reset_all(fd);
+ sleep(1);
+ } else {
+ igt_params_set(fd, "reset", "%u", -1u /* any method */);
+ igt_drop_caches_set(fd,
+ /* cancel everything */
+ DROP_RESET_ACTIVE | DROP_RESET_SEQNO |
+ /* cleanup */
+ DROP_ACTIVE | DROP_RETIRE | DROP_IDLE | DROP_FREED);
+ }
}
static void cancel_work_at_exit(int sig)
@@ -716,11 +722,11 @@ int drm_open_driver(int chipset)
igt_skip_on_f(fd<0, "No known gpu found for chipset flags 0x%u (%s)\n",
chipset, chipset_to_str(chipset));
- /* For i915, at least, we ensure that the driver is idle before
+ /* For i915 & xe, at least, we ensure that the driver is idle before
* starting a test and we install an exit handler to wait until
* idle before quitting.
*/
- if (is_i915_device(fd)) {
+ if (is_intel_device(fd)) {
if (__sync_fetch_and_add(&open_count, 1) == 0) {
__cancel_work_at_exit(fd);
at_exit_drm_fd = drm_reopen_driver(fd);
@@ -836,7 +842,7 @@ int drm_open_driver_render(int chipset)
return fd;
at_exit_drm_render_fd = drm_reopen_driver(fd);
- if (chipset & DRIVER_INTEL) {
+ if (chipset & (DRIVER_INTEL | DRIVER_XE)) {
__cancel_work_at_exit(fd);
igt_install_exit_handler(cancel_work_at_exit_render);
}
--
2.43.2
next prev parent reply other threads:[~2024-07-25 4:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 7:05 [i-g-t 1/2] lib/drmtest: Ensure the XE driver is idle before starting a test Bhanuprakash Modem
2024-07-24 7:05 ` [i-g-t 2/2] HAX: Test rmfb tests in BAT Bhanuprakash Modem
2024-07-24 9:04 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/drmtest: Ensure the XE driver is idle before starting a test Patchwork
2024-07-24 9:10 ` ✗ CI.xeBAT: failure " Patchwork
2024-07-24 9:13 ` [i-g-t 1/2] " Kamil Konieczny
2024-07-24 10:21 ` ✗ CI.xeFULL: failure for series starting with [i-g-t,1/2] " Patchwork
2024-07-24 11:18 ` ✗ Fi.CI.IGT: " Patchwork
2024-07-25 4:18 ` Bhanuprakash Modem [this message]
2024-07-25 13:45 ` [i-g-t V2 1/2] " Bernatowicz, Marcin
2024-07-25 16:35 ` Matthew Brost
2024-07-25 15:57 ` Kamil Konieczny
2024-07-25 6:23 ` ✗ Fi.CI.BAT: failure for series starting with [i-g-t,V2,1/2] lib/drmtest: Ensure the XE driver is idle before starting a test (rev2) Patchwork
2024-07-25 6:36 ` ✗ CI.xeBAT: " Patchwork
2024-07-25 8:51 ` ✗ CI.xeBAT: failure for series starting with [i-g-t,V2,1/2] lib/drmtest: Ensure the XE driver is idle before starting a test (rev3) Patchwork
2024-07-25 8:52 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-25 9:07 ` ✗ CI.xeFULL: failure for series starting with [i-g-t,V2,1/2] lib/drmtest: Ensure the XE driver is idle before starting a test (rev2) Patchwork
2024-07-25 12:04 ` ✗ CI.xeFULL: failure for series starting with [i-g-t,V2,1/2] lib/drmtest: Ensure the XE driver is idle before starting a test (rev3) Patchwork
2024-07-25 23:15 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725041803.1764959-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox