From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22668C3DA5D for ; Thu, 25 Jul 2024 17:42:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D91EF10E1D2; Thu, 25 Jul 2024 17:42:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SeogShS4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E45E10E30E for ; Thu, 25 Jul 2024 17:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721929329; x=1753465329; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5mG1QB7fM/2raIPpUWSL3aWLl3+2Xv57g0Oa94wH4q4=; b=SeogShS4d1I9GXF66h8LxGj20PSlslR/DxTOEYaxmseOgLRmpQ4Y2hV6 boGN0Corfl3nH62+Alvz2Iu64KnTUYo/aDFFvKKbghzUbW11C3swVS7L6 RrfRdQDKin+gfsA88OsozTxKZVHtanD3syuvX9VTZjM2R+C8fXL/7udDX kzZRHV4vPLc72Jmw0saGLCZirI2wOiDDtVbxWeHBiXJZhT3+UBeausdSH L2B3dI3GlVVVlOpOsDP7ZTiBLis1/qiyWegjWBwrEmXZy1EGu277zcxnY zcRXiZWq6ko0JWSn4DIZtILVwQZ0jGiDlb0bdazJvVmb7rBozYfErkyz/ A==; X-CSE-ConnectionGUID: VecBzkOiTEqp4f4gF+TX+A== X-CSE-MsgGUID: Y09vfOcWSpeSBPrmhXxinw== X-IronPort-AV: E=McAfee;i="6700,10204,11144"; a="37149239" X-IronPort-AV: E=Sophos;i="6.09,236,1716274800"; d="scan'208";a="37149239" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2024 10:42:09 -0700 X-CSE-ConnectionGUID: HZkTwBTRRMOKb7dCXvnh6w== X-CSE-MsgGUID: xdquBGJkSuO+6paR4BfLzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,236,1716274800"; d="scan'208";a="52700345" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2024 10:42:09 -0700 From: Matthew Brost To: igt-dev@lists.freedesktop.org Cc: kamil.konieczny@linux.intel.com Subject: [PATCH v4 2/2] tests/intel/xe_exec_basic: Add test for zero number of BB Date: Thu, 25 Jul 2024 10:42:54 -0700 Message-Id: <20240725174254.1931701-2-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240725174254.1931701-1-matthew.brost@intel.com> References: <20240725174254.1931701-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Verify the exec queue ordering works wrt out-sync signaling when zero number of BB passed to exec IOCTL. v2; - Fix build error v3: - Add data check - Fix comment - Destroy all syncobjs - Reword subject (Kamal) Cc: Kamil Konieczny Signed-off-by: Matthew Brost --- tests/intel/xe_exec_basic.c | 112 ++++++++++++++++++++++++++++++++++++ 1 file changed, 112 insertions(+) diff --git a/tests/intel/xe_exec_basic.c b/tests/intel/xe_exec_basic.c index 0fd1ae062c..6708783e52 100644 --- a/tests/intel/xe_exec_basic.c +++ b/tests/intel/xe_exec_basic.c @@ -19,6 +19,7 @@ #include "xe/xe_ioctl.h" #include "xe/xe_query.h" +#include "xe/xe_spin.h" #include #define MAX_N_EXEC_QUEUES 16 @@ -314,6 +315,113 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci, } } +/** + * SUBTEST: zero-execs + * Description: Test zero execs in IOCTL + * Functionality: exec IOCTL + * Run type: BAT + */ + +static void test_zero_execs(int fd, struct drm_xe_engine_class_instance *eci, + int n_execs) +{ + uint32_t vm; + uint64_t addr = 0x1a0000; + struct drm_xe_sync sync[2] = { + { .flags = DRM_XE_SYNC_TYPE_SYNCOBJ | DRM_XE_SYNC_FLAG_SIGNAL, }, + { .flags = DRM_XE_SYNC_TYPE_SYNCOBJ | DRM_XE_SYNC_FLAG_SIGNAL, }, + }; + struct drm_xe_exec exec = { + .num_batch_buffer = 1, + .num_syncs = 1, + .syncs = to_user_pointer(sync), + }; + size_t bo_size; + uint32_t bo = 0; + uint32_t syncobj; + uint32_t exec_queue; + struct xe_cork cork; + struct { + uint32_t batch[16]; + uint64_t pad; + uint32_t data; + } *data; + int i, b; + + vm = xe_vm_create(fd, 0, 0); + bo_size = sizeof(*data) * n_execs; + bo_size = ALIGN(bo_size + xe_cs_prefetch_size(fd), + xe_get_default_alignment(fd)); + bo = xe_bo_create(fd, vm, bo_size, + vram_if_possible(fd, eci->gt_id), + DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM); + data = xe_bo_map(fd, bo, bo_size); + exec_queue = xe_exec_queue_create(fd, vm, eci, 0); + + xe_cork_init(fd, eci, &cork); + xe_cork_wait_started(&cork); + + /* Initial bind behind cork */ + sync[0].handle = syncobj = syncobj_create(fd, 0); + sync[0].flags |= DRM_XE_SYNC_FLAG_SIGNAL; + sync[1].handle = cork.syncobj; + sync[1].flags &= ~DRM_XE_SYNC_FLAG_SIGNAL; + xe_vm_bind_async(fd, vm, 0, bo, 0, addr, bo_size, sync, 2); + + /* Exec behind bind */ + for (i = 0; i < n_execs; i++) { + uint64_t batch_offset = (char *)&data[i].batch - (char *)data; + uint64_t batch_addr = addr + batch_offset; + uint64_t sdi_offset = (char *)&data[i].data - (char *)data; + uint64_t sdi_addr = addr + sdi_offset; + + b = 0; + data[i].batch[b++] = MI_STORE_DWORD_IMM_GEN4; + data[i].batch[b++] = sdi_addr; + data[i].batch[b++] = sdi_addr >> 32; + data[i].batch[b++] = 0xc0ffee; + data[i].batch[b++] = MI_BATCH_BUFFER_END; + igt_assert(b <= ARRAY_SIZE(data[i].batch)); + + sync[0].flags &= ~DRM_XE_SYNC_FLAG_SIGNAL; + + exec.exec_queue_id = exec_queue; + exec.address = batch_addr; + xe_exec(fd, &exec); + } + + /* Exec with no batch buffer */ + sync[0].handle = syncobj_create(fd, 0); + sync[0].flags |= DRM_XE_SYNC_FLAG_SIGNAL; + exec.num_batch_buffer = 0; + exec.address = 0; + xe_exec(fd, &exec); + + /* Let jobs runs for a bit */ + usleep(100000); + + /* both bind and execs are waiting */ + igt_assert(!syncobj_wait(fd, &syncobj, 1, 0, 0, NULL)); + igt_assert(!syncobj_wait(fd, &sync[0].handle, 1, 0, 0, NULL)); + + /* Release cork */ + xe_cork_end(&cork); + xe_cork_wait_done(&cork); + xe_cork_fini(&cork); + + /* both bind and exec are done */ + igt_assert(syncobj_wait(fd, &syncobj, 1, INT64_MAX, 0, NULL)); + igt_assert(syncobj_wait(fd, &sync[0].handle, 1, INT64_MAX, 0, NULL)); + + for (i = 0; i < n_execs; i++) + igt_assert_eq(data[i].data, 0xc0ffee); + + syncobj_destroy(fd, syncobj); + syncobj_destroy(fd, sync[0].handle); + gem_close(fd, bo); + xe_vm_destroy(fd, vm); +} + igt_main { struct drm_xe_engine_class_instance *hwe; @@ -383,6 +491,10 @@ igt_main test_exec(fd, hwe, 1, 0, 1, s->flags); } + igt_subtest("zero-execs") + xe_for_each_engine(fd, hwe) + test_zero_execs(fd, hwe, 1); + igt_fixture drm_close_driver(fd); -- 2.34.1