From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21F9AC3DA7E for ; Tue, 30 Jul 2024 11:49:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DAB9F10E50A; Tue, 30 Jul 2024 11:49:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LhW3tjld"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id C608A10E517 for ; Tue, 30 Jul 2024 11:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722340186; x=1753876186; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IT4oIEfQC3FvLfUWEqfKiL++a6Qo3uwN06T2g5Afq9g=; b=LhW3tjldaBwIGhPOlxXHAORRtcVi8UhJdbQMmBEXKNfLWSbmQcGcd720 hcn2yAS5EfGvKYpn2MAtJGprnAZax/aHmcxGX0/JCvvA1ZDeRk3t5U4v6 bBhzAruhUoaB9Lg/IF+eRttDqStjk9b5NBTSfJqDsA57zZUf0aOvzxyQ3 jqj6Sc9No6NsgOKYneG1JNyiiyHyeiNrjiYTaMBM4ffAeGnvfFCUIW/3F YjuBSnF6XrDsoui6DXqFOCSq8PTHEhXONX7tX2LDQpoVuih4FiLt0CASc JtTCStx4vyo5MgQee7nnXLinBHw8DiBExv9atfrxVdJaobcrmhKpHxLeP Q==; X-CSE-ConnectionGUID: Tw6FAUMHTN6Yaw5F+jYLhA== X-CSE-MsgGUID: kE8mgBLSQmCBV0yPe8xiYQ== X-IronPort-AV: E=McAfee;i="6700,10204,11148"; a="20286774" X-IronPort-AV: E=Sophos;i="6.09,248,1716274800"; d="scan'208";a="20286774" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2024 04:49:46 -0700 X-CSE-ConnectionGUID: XVtF6iKORgmb35O6dP/mDQ== X-CSE-MsgGUID: aOz+euE6RQC8jiuIEwDkxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,248,1716274800"; d="scan'208";a="54217723" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO localhost.localdomain) ([10.245.246.43]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2024 04:49:42 -0700 From: Christoph Manszewski To: igt-dev@lists.freedesktop.org Cc: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= , Kamil Konieczny , Dominik Grzegorzek , Maciej Patelczyk , =?UTF-8?q?Dominik=20Karol=20Pi=C4=85tkowski?= , Pawel Sikora , Andrzej Hajda , Kolanupaka Naveena , Mika Kuoppala , Gwan-gyeong Mun Subject: [PATCH i-g-t v2 61/66] tests/xe_eudebug_online: Adds debugger-reopen test Date: Tue, 30 Jul 2024 13:45:18 +0200 Message-Id: <20240730114523.334156-62-christoph.manszewski@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240730114523.334156-1-christoph.manszewski@intel.com> References: <20240730114523.334156-1-christoph.manszewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" From: Kolanupaka Naveena Introducing a test which will close and reopen the debugger after resume on each breakpoint to make sure that the debugger is able to capture the further events after reopening it. Signed-off-by: Kolanupaka Naveena Cc: Dominik Karol Piątkowski --- tests/intel/xe_eudebug_online.c | 68 +++++++++++++++++++++++++++++++-- 1 file changed, 64 insertions(+), 4 deletions(-) diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c index 8361b6db4..c3c82b061 100644 --- a/tests/intel/xe_eudebug_online.c +++ b/tests/intel/xe_eudebug_online.c @@ -25,6 +25,7 @@ #define SHADER_SINGLE_STEP (1 << 2) #define SIP_SINGLE_STEP (1 << 3) #define DISABLE_DEBUG_MODE (1 << 4) +#define SHADER_N_NOOP_BREAKPOINT (1 << 5) #define TRIGGER_RESUME_SINGLE_WALK (1 << 25) #define TRIGGER_RESUME_PARALLEL_WALK (1 << 26) #define TRIGGER_RECONNECT (1 << 27) @@ -35,6 +36,7 @@ #define DEBUGGER_REATTACHED 1 +#define SHADER_LOOP_N 3 #define SINGLE_STEP_COUNT 16 #define STEERING_SINGLE_STEP 0 #define STEERING_CONTINUE 0x00c0ffee @@ -128,6 +130,11 @@ static struct gpgpu_shader *get_shader(int fd, const unsigned int flags) gpgpu_shader__breakpoint(shader); for (int i = 0; i < SINGLE_STEP_COUNT; i++) gpgpu_shader__nop(shader); + } else if (flags & SHADER_N_NOOP_BREAKPOINT) { + for (int i = 0; i < SHADER_LOOP_N; i++) { + gpgpu_shader__nop(shader); + gpgpu_shader__breakpoint(shader); + } } gpgpu_shader__eot(shader); @@ -525,6 +532,7 @@ static int get_stepped_threads_count(struct online_debug_data *data, int threads } #define MAX_PREEMPT_TIMEOUT 10ull +static int is_client_resumed; static void eu_attention_resume_trigger(struct xe_eudebug_debugger *d, struct drm_xe_eudebug_event *e) { @@ -583,6 +591,7 @@ static void eu_attention_resume_trigger(struct xe_eudebug_debugger *d, att->exec_queue_handle, att->lrc_handle, bitmask, att->bitmask_size); + is_client_resumed = 1; free(bitmask); } @@ -881,8 +890,8 @@ static void run_online_client(struct xe_eudebug_client *c) data->threads_count = count_canaries_neq(ptr, w_dim, 0); igt_assert_f(data->threads_count, "No canaries found, nothing executed?\n"); - if ((c->flags & SHADER_BREAKPOINT || c->flags & TRIGGER_RESUME_SET_BP) && - !(c->flags & DISABLE_DEBUG_MODE)) { + if ((c->flags & SHADER_BREAKPOINT || c->flags & TRIGGER_RESUME_SET_BP || + c->flags & SHADER_N_NOOP_BREAKPOINT) && !(c->flags & DISABLE_DEBUG_MODE)) { uint32_t aip = ptr[0]; igt_assert_f(aip != SHADER_CANARY, "Workload executed but breakpoint not hit!\n"); @@ -1375,7 +1384,8 @@ static void eu_attention_debugger_detach_trigger(struct xe_eudebug_debugger *d, xe_eudebug_debugger_dettach(d); /* Let the KMD scan function notice unhandled EU attention */ - sleep(1); + if (!(d->flags & SHADER_N_NOOP_BREAKPOINT)) + sleep(1); /* * New session that is created by EU debugger on reconnect restarts @@ -1394,7 +1404,8 @@ static void eu_attention_debugger_detach_trigger(struct xe_eudebug_debugger *d, /* Let the discovery worker discover resources */ sleep(2); - xe_eudebug_debugger_signal_stage(d, DEBUGGER_REATTACHED); + if (!(d->flags & SHADER_N_NOOP_BREAKPOINT)) + xe_eudebug_debugger_signal_stage(d, DEBUGGER_REATTACHED); } /** @@ -1510,6 +1521,52 @@ static void test_single_step(int fd, struct drm_xe_engine_class_instance *hwe, i online_debug_data_destroy(data); } +static int debugger_detach_count; +static void eu_attention_debugger_ndetach_trigger(struct xe_eudebug_debugger *d, + struct drm_xe_eudebug_event *event) +{ + if (debugger_detach_count < (SHADER_LOOP_N - 1)) { + /* Make sure the resume command has issued before detaching the debugger */ + if (!is_client_resumed) + return; + eu_attention_debugger_detach_trigger(d, event); + debugger_detach_count++; + } else { + igt_debug("Reached Nth breakpoint hence preventing the debugger detach\n"); + } + is_client_resumed = 0; +} + +/** + * SUBTEST: debugger-reopen + * Description: + * Check whether the debugger is able to reopen the connection and + * capture the events of already running client. + */ +static void test_debugger_reopen(int fd, struct drm_xe_engine_class_instance *hwe, int flags) +{ + struct xe_eudebug_session *s; + struct online_debug_data *data; + + data = online_debug_data_create(hwe); + + s = xe_eudebug_session_create(fd, run_online_client, flags, data); + + xe_eudebug_debugger_add_trigger(s->d, DRM_XE_EUDEBUG_EVENT_EU_ATTENTION, + eu_attention_debug_trigger); + xe_eudebug_debugger_add_trigger(s->d, DRM_XE_EUDEBUG_EVENT_EU_ATTENTION, + eu_attention_resume_trigger); + xe_eudebug_debugger_add_trigger(s->d, DRM_XE_EUDEBUG_EVENT_EU_ATTENTION, + eu_attention_debugger_ndetach_trigger); + xe_eudebug_debugger_add_trigger(s->d, DRM_XE_EUDEBUG_EVENT_VM_BIND_UFENCE, + ufence_ack_trigger); + + xe_eudebug_session_run(s); + + xe_eudebug_session_destroy(s); + online_debug_data_destroy(data); +} + static struct drm_xe_engine_class_instance *pick_compute(int fd, int gt) { struct drm_xe_engine_class_instance *hwe; @@ -1586,6 +1643,9 @@ igt_main test_single_step(fd, hwe, SHADER_SINGLE_STEP | SIP_SINGLE_STEP | TRIGGER_RESUME_SINGLE_WALK); + test_gt_render_or_compute("debugger-reopen", fd, hwe) + test_debugger_reopen(fd, hwe, SHADER_N_NOOP_BREAKPOINT); + igt_fixture { xe_eudebug_enable(fd, was_enabled); -- 2.34.1