From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t 1/3] lib/igt_drm_fdinfo: Improve fdinfo parse documentation
Date: Tue, 30 Jul 2024 20:35:02 -0700 [thread overview]
Message-ID: <20240731033504.1426640-2-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240731033504.1426640-1-lucas.demarchi@intel.com>
Be explicit on what we are parsing: key-values for the current process,
likely to be used by the same process causing workloads, or by
key-values for a random process, likely to be used when analyzing all
the clients.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_drm_fdinfo.h | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/igt_drm_fdinfo.h b/lib/igt_drm_fdinfo.h
index 35f43305b..168b3c44c 100644
--- a/lib/igt_drm_fdinfo.h
+++ b/lib/igt_drm_fdinfo.h
@@ -74,7 +74,9 @@ struct drm_client_fdinfo {
};
/**
- * igt_parse_drm_fdinfo: Parses the drm fdinfo file
+ * igt_parse_drm_fdinfo: Parse the drm fdinfo file for this process
+ *
+ * Parse /proc/self/fdinfo/<drm_fd> collecting all key-values
*
* @drm_fd: DRM file descriptor
* @info: Structure to populate with read data. Must be zeroed.
@@ -92,10 +94,12 @@ igt_parse_drm_fdinfo(int drm_fd, struct drm_client_fdinfo *info,
const char **region_map, unsigned int region_entries);
/**
- * __igt_parse_drm_fdinfo: Parses the drm fdinfo file
+ * __igt_parse_drm_fdinfo: Parse the drm fdinfo file for a process
+ *
+ * Parse /proc/<pid>/fdinfo/<fd> collecting all key-values.
*
- * @dir: File descriptor pointing to /proc/pid/fdinfo directory
- * @fd: String representation of the file descriptor number to parse.
+ * @dir: File descriptor pointing to /proc/<pid>/fdinfo directory
+ * @fd: String representation of the file descriptor number (<fd>) to parse.
* @info: Structure to populate with read data. Must be zeroed.
* @name_map: Optional array of strings representing engine names
* @map_entries: Number of strings in the names array
--
2.43.0
next prev parent reply other threads:[~2024-07-31 3:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 3:35 [PATCH i-g-t 0/3] fdinfo doc and xe_spin fix Lucas De Marchi
2024-07-31 3:35 ` Lucas De Marchi [this message]
2024-07-31 21:19 ` [PATCH i-g-t 1/3] lib/igt_drm_fdinfo: Improve fdinfo parse documentation Cavitt, Jonathan
2024-07-31 3:35 ` [PATCH i-g-t 2/3] lib/xe_spin: Fix xe_spin_wait_started() Lucas De Marchi
2024-07-31 6:06 ` Zbigniew Kempczyński
2024-08-01 5:42 ` Zbigniew Kempczyński
2024-08-08 6:00 ` Lucas De Marchi
2024-07-31 21:37 ` Cavitt, Jonathan
2024-07-31 3:35 ` [PATCH i-g-t 3/3] lib/xe_spin: Fix ending the loop Lucas De Marchi
2024-07-31 6:09 ` Zbigniew Kempczyński
2024-07-31 21:39 ` Cavitt, Jonathan
2024-07-31 4:38 ` ✓ CI.xeBAT: success for fdinfo doc and xe_spin fix Patchwork
2024-07-31 4:51 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-07-31 5:44 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731033504.1426640-2-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox