From: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
Emil Velikov <emil.l.velikov@gmail.com>,
Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Subject: [PATCH i-g-t v3] tests/core_setmaster: Adjust loop control in tweak_perm
Date: Wed, 31 Jul 2024 13:50:37 +0530 [thread overview]
Message-ID: <20240731082037.1069-1-krishnaiah.bommu@intel.com> (raw)
The `tweak_perm` function now uses `continue` instead of `break` when
encountering non-existent card paths. This change addresses the assumption
in existing userspace that card paths are contiguous, which may not be true
if cards are dynamically removed.
Problem Description:
The test fails after running the `core_hotunplug@hot*` subtest, where card0 is missing.
This leads to a failure in the subsequent `master-drop-set-user` test.
Command sequence for reproducing the issue:
- Check available cards: `ls /dev/dri/`
- Output: by-path card0 renderD128
- Run the test: `# ./core_hotunplug --r hotrebind-lateclose`
- Check again: ‘ls /dev/dri/’
- Output after failure: by-path card1 renderD129
- Run the test: `# ./core_setmaster --r master-drop-set-user`
This failures on both XE and i915 for above sequence.
Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
tests/core_setmaster.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/core_setmaster.c b/tests/core_setmaster.c
index 9c2083f66..a2758e2f2 100644
--- a/tests/core_setmaster.c
+++ b/tests/core_setmaster.c
@@ -116,9 +116,10 @@ static unsigned tweak_perm(uint8_t *saved_perm, unsigned max_perm, bool save)
for (i = 0; i < max_perm; i++) {
snprintf(path, sizeof(path), "/dev/dri/card%u", i);
- /* Existing userspace assumes there's no gaps, do the same. */
+ /* Userspace cannot always have continuous card0...N due to
+ * dynamic unloading or removal of cards */
if (stat(path, &st) != 0)
- break;
+ continue;
if (save) {
/* Save and toggle */
--
2.25.1
next reply other threads:[~2024-07-31 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 8:20 Bommu Krishnaiah [this message]
2024-07-31 9:06 ` ✓ CI.xeBAT: success for tests/core_setmaster: Adjust loop control in tweak_perm Patchwork
2024-07-31 9:20 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-31 9:53 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-31 17:56 ` [PATCH i-g-t v3] " Emil Velikov
2024-08-05 5:29 ` Bommu, Krishnaiah
2024-07-31 23:31 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731082037.1069-1-krishnaiah.bommu@intel.com \
--to=krishnaiah.bommu@intel.com \
--cc=emil.l.velikov@gmail.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox