From: Prike Liang <Prike.Liang@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <Vitaly.Prosyak@amd.com>, <Alexander.Deucher@amd.com>,
Prike Liang <Prike.Liang@amd.com>
Subject: [PATCH] tests/amdgpu: update bad length case
Date: Thu, 1 Aug 2024 16:25:48 +0800 [thread overview]
Message-ID: <20240801082548.2496123-1-Prike.Liang@amd.com> (raw)
In the bad length case, when the header length is bigger than packet
stream length then CPFW will pending on the stream data and raise a
CP halt error which requires do the pipe reset. As to the orignal case
of header length is smaller than PM4 stream length then the PM4 stream
data may will create a bad opcode error which only requires the queue
reset. So for testing the pipe reset need to update the header length
bigger than the PM4 stream data length.
Signed-off-by: Prike Liang <Prike.Liang@amd.com>
---
lib/amdgpu/amd_ip_blocks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/amdgpu/amd_ip_blocks.c b/lib/amdgpu/amd_ip_blocks.c
index f675b97dd..edfd16e76 100644
--- a/lib/amdgpu/amd_ip_blocks.c
+++ b/lib/amdgpu/amd_ip_blocks.c
@@ -201,7 +201,7 @@ gfx_ring_bad_write_linear(const struct amdgpu_ip_funcs *func,
if (cmd_error == CMD_STREAM_EXEC_INVALID_OPCODE)
ring_context->pm4[i++] = PACKET3(0xf2, 2 + ring_context->write_length);
else if (cmd_error == CMD_STREAM_EXEC_INVALID_PACKET_LENGTH)
- ring_context->pm4[i++] = PACKET3(PACKET3_WRITE_DATA, (ring_context->write_length - 2));
+ ring_context->pm4[i++] = PACKET3(PACKET3_WRITE_DATA, (ring_context->write_length + 4));
else
ring_context->pm4[i++] = PACKET3(PACKET3_WRITE_DATA, 2 + ring_context->write_length);
--
2.34.1
next reply other threads:[~2024-08-01 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 8:25 Prike Liang [this message]
2024-08-01 8:29 ` [PATCH] tests/amdgpu: update bad length case Zhang, Jesse(Jie)
2024-08-01 9:51 ` Liang, Prike
-- strict thread matches above, loose matches on Subject: below --
2024-08-01 9:55 Prike Liang
2024-08-01 10:33 ` Zhang, Jesse(Jie)
2024-08-01 10:47 ` Zhang, Jesse(Jie)
2024-08-01 10:56 ` Liang, Prike
2024-08-01 10:59 ` Zhang, Jesse(Jie)
2024-08-01 10:59 Prike Liang
2024-08-07 1:06 ` Liang, Prike
2024-08-07 1:16 ` vitaly prosyak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801082548.2496123-1-Prike.Liang@amd.com \
--to=prike.liang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Vitaly.Prosyak@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox