From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, bhanuprakash.modem@intel.com,
sameer.lattannavar@intel.com, pranay.samala@intel.com
Subject: [PATCH i-g-t] tests/kms_3d: Add more logs to skips/failure
Date: Mon, 5 Aug 2024 12:17:12 +0530 [thread overview]
Message-ID: <20240805064712.970488-1-pranay.samala@intel.com> (raw)
Having some logs for test failures and skips would
make debugging much easier.
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
tests/kms_3d.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index ad6c45e9b..f79fa62da 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -53,9 +53,10 @@ igt_simple_main
drm_fd = drm_open_driver_master(DRIVER_ANY);
res = drmModeGetResources(drm_fd);
- igt_require(res);
+ igt_require_f(res, "Failed to get list of a DRM device's major resources\n");
- igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0);
+ igt_assert_f(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0,
+ "Failed to enable STEREO_3D capability\n");
/* find an hdmi connector */
for (int i = 0; i < res->count_connectors; i++) {
@@ -65,7 +66,7 @@ igt_simple_main
drmModeFreeConnector(connector);
connector = NULL;
}
- igt_require(connector);
+ igt_require_f(connector, "Unable to get HDMI Connector\n");
kmstest_unset_all_crtcs(drm_fd, res);
@@ -85,7 +86,7 @@ igt_simple_main
mode_count++;
}
- igt_assert(mode_count);
+ igt_assert_f(mode_count, "3D modes not detected\n");
/* set 3D modes */
igt_info("Testing:\n");
@@ -95,8 +96,10 @@ igt_simple_main
int crtc_mask = -1;
int ret;
- if (!(connector->modes[i].flags & DRM_MODE_FLAG_3D_MASK))
+ if (!(connector->modes[i].flags & DRM_MODE_FLAG_3D_MASK)) {
+ igt_info("%i: Doesn't support 3D MASK\n", res->connectors[i]);
continue;
+ }
/* create a configuration */
ret = kmstest_get_connector_config(drm_fd, connector_id,
@@ -120,7 +123,7 @@ igt_simple_main
&connector->connector_id, 1,
&connector->modes[i]);
- igt_assert(ret == 0);
+ igt_assert_f(ret == 0, "Unable to set CRTC\n");
}
kmstest_force_connector(drm_fd, connector, FORCE_CONNECTOR_UNSPECIFIED);
--
2.34.1
next reply other threads:[~2024-08-05 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 6:47 Pranay Samala [this message]
2024-08-05 8:24 ` ✓ CI.xeBAT: success for tests/kms_3d: Add more logs to skips/failure Patchwork
2024-08-05 8:31 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-08-05 10:20 ` ✗ CI.xeFULL: " Patchwork
2024-08-20 4:54 ` [PATCH i-g-t] " B, Jeevan
-- strict thread matches above, loose matches on Subject: below --
2024-11-06 10:36 Pranay Samala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805064712.970488-1-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox