Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [PATCH i-g-t v2 5/8] tests/core_hotunplug: Fix device close
Date: Mon,  5 Aug 2024 16:37:08 +0200	[thread overview]
Message-ID: <20240805143713.76034-6-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20240805143713.76034-1-kamil.konieczny@linux.intel.com>

Use __drm_close_driver() for closing a drm device, as it was
opened with __drm_open_driver() function.

v2: update description

Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 tests/core_hotunplug.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index cc715a234..b66d5e4cf 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -142,7 +142,11 @@ static int close_device(int fd_drm, const char *when, const char *which)
 		return fd_drm;
 
 	local_debug("%sclosing %sdevice instance\n", when, which);
-	return local_close(fd_drm, "Device close failed");
+	errno = 0;
+	if (igt_warn_on_f(__drm_close_driver(fd_drm), "Device close failed\n"))
+		return -errno;	/* (never -1) */
+
+	return -1;	/* success */
 }
 
 static int close_sysfs(int fd_sysfs_dev)
-- 
2.43.0


  parent reply	other threads:[~2024-08-05 14:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05 14:37 [PATCH i-g-t v2 0/8] tests/core_hotunplug: Make it fail only once Kamil Konieczny
2024-08-05 14:37 ` [PATCH i-g-t v2 1/8] lib/drmtest: add function for retriving chipset Kamil Konieczny
2024-08-05 14:37 ` [PATCH i-g-t v2 2/8] tests/core_hotunplug: set known chipset before tests Kamil Konieczny
2024-08-05 14:37 ` [PATCH i-g-t v2 3/8] lib/drmtest: Allow to get drm device name Kamil Konieczny
2024-08-05 14:37 ` [PATCH i-g-t v2 4/8] tests/core_hotunplug: Open the same driver Kamil Konieczny
2024-08-05 14:37 ` Kamil Konieczny [this message]
2024-08-05 14:37 ` [PATCH i-g-t v2 6/8] tests/core_hotunplug: Skip if no render available Kamil Konieczny
2024-08-05 14:37 ` [PATCH i-g-t v2 7/8] tests/core_hotunplug: Check health once after subtest Kamil Konieczny
2024-08-07 12:26   ` Andrzej Hajda
2024-08-05 14:37 ` [PATCH i-g-t v2 8/8] tests/core_hotunplug: Print info between steps Kamil Konieczny
2024-08-07 12:58   ` Andrzej Hajda
2024-08-05 15:20 ` ✓ CI.xeBAT: success for tests/core_hotunplug: Make it fail only once Patchwork
2024-08-05 15:31 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-05 16:25 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-05 18:45   ` Kamil Konieczny
2024-08-05 23:51 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-06 12:51   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240805143713.76034-6-kamil.konieczny@linux.intel.com \
    --to=kamil.konieczny@linux.intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox