From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
Katarzyna Piecielska <katarzyna.piecielska@intel.com>,
Petri Latvala <adrinael@adrinael.net>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Karol Krol <karol.krol@intel.com>,
Ewelina Musial <ewelina.musial@intel.com>
Subject: [PATCH i-g-t v5 0/4] runner: Allow dynamically ignore dmesg errors or warnings
Date: Mon, 19 Aug 2024 12:32:38 +0200 [thread overview]
Message-ID: <20240819103242.26527-1-kamil.konieczny@linux.intel.com> (raw)
Allow igt tests to dynamically inform igt_runner about expected
kernel warn or error and allow to ignore it and generate correct
results.
For example, xe_wedged forces wedged state and after checks test
succeeds but runner interprets kernel error message and treat
that as a fail. In dmesg there was:
<6> [259.656065] [IGT] xe_wedged: executing
<6> [259.659888] [IGT] xe_wedged: starting subtest wedged-at-any-timeout
<3> [259.661285] xe 0000:03:00.0: [drm] *ERROR* CRITICAL: Xe has declared device 0000:03:00.0 as wedged.
IOCTLs and executions are blocked. Only a rebind may clear the failure
Please file a _new_ bug report at https://gitlab.freedesktop.org/drm/xe/kernel/issues/new
<5> [259.661375] xe 0000:03:00.0: [drm] GT0: Timedout job: seqno=4294967169, lrc_seqno=4294967169, guc_id=2, flags=0x0 in xe_wedged [1825]
In output on stdout there was:
[381.820788] Starting subtest: wedged-at-any-timeout
[385.137763] Subtest wedged-at-any-timeout: SUCCESS (3.317s)
but in results.json the test is marked as a fail with dmesg-warn:
"igt@xe_wedged@wedged-at-any-timeout":{
"out":"Starting subtest: wedged-at-any-timeout\nSubtest wedged-at-any-timeout: SUCCESS (3.317s)\n",
"err":"Starting subtest: wedged-at-any-timeout\nSubtest wedged-at-any-timeout: SUCCESS (3.317s)\n",
"igt-version":"IGT-Version: 1.28-g9fa156438 (x86_64) (Linux: 6.10.0-rc7-xe x86_64)\n",
"result":"dmesg-warn",
To overcome this test could emit a message, in this case:
add ignored dmesg regex: CRITICAL: Xe has declared device [0-9A-Fa-f:.]* as wedged
Such regex will be cleared after resultsgen proceeds to a next
(dynamic) subtest, so if that happens outside such scenarios
it would be treated in old way.
v2: addressed review comments: removed strdup(), added check for regex
creation in igt_core (Zbigniew)
free regex before creating new (Kamil)
v3: added printing error message from glib (Zbigniew)
v4: restore trimming regex line at '\n' in resultgen (Kamil)
v5: rebase
Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
Cc: Petri Latvala <adrinael@adrinael.net>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Karol Krol <karol.krol@intel.com>
Cc: Ewelina Musial <ewelina.musial@intel.com>
Kamil Konieczny (4):
runner/resultgen: Added dynamically ignored dmesg messages
lib/igt_core: Added message to runner about ignoring kernel warns
tests/intel/xe_wedged: Inform runner about expected error
HAX/DO_NOT_MERGE: xe-fast-feedback: test xe_wedged
lib/igt_core.c | 24 +++++++++
lib/igt_core.h | 2 +
runner/output_strings.h | 8 +++
runner/resultgen.c | 68 +++++++++++++++++++++---
tests/intel-ci/xe-fast-feedback.testlist | 4 ++
tests/intel/xe_wedged.c | 10 ++++
6 files changed, 108 insertions(+), 8 deletions(-)
--
2.43.0
next reply other threads:[~2024-08-19 10:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 10:32 Kamil Konieczny [this message]
2024-08-19 10:32 ` [PATCH i-g-t v5 1/4] runner/resultgen: Added dynamically ignored dmesg messages Kamil Konieczny
2024-08-26 17:03 ` Rodrigo Vivi
2024-08-19 10:32 ` [PATCH i-g-t v5 2/4] lib/igt_core: Added message to runner about ignoring kernel warns Kamil Konieczny
2024-08-26 17:04 ` Rodrigo Vivi
2024-08-19 10:32 ` [PATCH i-g-t v5 3/4] tests/intel/xe_wedged: Inform runner about expected error Kamil Konieczny
2024-08-19 10:32 ` [PATCH i-g-t v5 4/4] HAX/DO_NOT_MERGE: xe-fast-feedback: test xe_wedged Kamil Konieczny
2024-08-19 11:34 ` ✗ CI.xeBAT: failure for runner: Allow dynamically ignore dmesg errors or warnings (rev6) Patchwork
2024-08-19 11:41 ` ✗ Fi.CI.BAT: " Patchwork
2024-08-23 10:24 ` Kamil Konieczny
2024-08-19 14:29 ` ✗ CI.xeFULL: " Patchwork
2024-08-23 11:59 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819103242.26527-1-kamil.konieczny@linux.intel.com \
--to=kamil.konieczny@linux.intel.com \
--cc=adrinael@adrinael.net \
--cc=ewelina.musial@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=janusz.krzysztofik@linux.intel.com \
--cc=karol.krol@intel.com \
--cc=katarzyna.piecielska@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox