From: Harry Wentland <harry.wentland@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Harry Wentland <harry.wentland@amd.com>
Subject: [PATCH v5 00/37] IGT tests for the KMS Color Pipeline API
Date: Mon, 19 Aug 2024 16:57:46 -0400 [thread overview]
Message-ID: <20240819205823.316656-1-harry.wentland@amd.com> (raw)
This series introduces support for
* drm_colorop DRM objects
* COLOR_PIPELINE plane property
Kernel changes can be found at [1] and on dri-devel.
It also adds a new kms_colorop test case that tests the color pipeline
API. The tests are designed to be easily extensible with a "transform"
and "compare" function pointer for each test. The "transform" function
performs the transformations under test via SW routines. The "compare"
function compares the DRM/KMS result (via a writeback connector) with
the result derived via the SW "transform".
This series introduces a number of tests for pre-defined transfer
functions, custom LUTs, 3x4 CTMs, a multiplier, 3D LUT, and a bypass
test.
It tests 8-bit and 10-bit RGB surface formats, depending on driver support
on the drm_plane as well as the writeback drm_connector end.
Bhanuprakash sent an Intel series as a v4. This v5 does not incorporate
his patches as rebasing them wasn't straight-forward.
[1] https://gitlab.freedesktop.org/hwentland/linux/-/tree/amd-color-pipeline-v5
v5:
- Bypass test
- 10 bpc support
- Proper setup and cleanup
- PQ/BT2020 TFs
- 1D LUT tests
- Multiplier tests
- 3D LUT test
v4:
- Intel color pipeline work, to possibly be combined with v5 in a future iteration.
v3:
- Remove need for IOCTLs and libdrm changes
- Test colorop properties with both atomic and legacy code paths
- move enum drm_colorop_type to drm_mode.h
- Add descriptions for public functions in lib (Kamil)
- Use SPDX style license identifier (Kamil)
- Replace Skia license comment with copyright note in file header
- Fix kms_colorop subtests if applicable color pipeline not found
Alex Hung (9):
lib/igt_kms: increase MAX_NUM_COLOROPS to 128
tests/kms_colorop: Add a sRGB test for EOTF -> Inverse EOTF -> EOTF
lib/igt_color: Add 1D LUT color transformation support
test/kms_colorop: Add tests that exercise the 1D LUT colorops
tests/kms_colorop: Add multiplier tests
scripts/convert_3dlut.py Convert a 3D LUT to igt_3dlut_t array for 3D
LUT API
tests/kms_colorop: Add 3D LUT subtests
drm-uapi: Update kernel doc for drm_colorop_type
drm-uapi: Sync up definition with kernel colorop implementation
Harry Wentland (28):
lib/drmtest: Add is_vkms_device()
tests/kms_writeback: Fix kms_writeback for VKMS
lib/igt_kms: Move get_writeback_formats_blob to lib
lib/igt_kms: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE
include/drm-uapi: Add COLOROP object
drm-uapi: Add 3x4 CTM
drm-uapi: Add 1D LUT drm_colorop_type
lib/igt_kms: Introduce drm_colorop and COLOR_PIPELINE
tests/kms_properties: Add colorop properties test
igt/color: Add SW color transform functionality
lib/igt_fb: Add copy_fb function
tests/kms_colorop: Add kms_colorop tests
lib/igt_kms: Add support for DATA colorop property
lib/igt_color: Add support for 3x4 matrices
tests/kms_colorop: Add 3x4 CTM tests
tests/kms_colorop: Add bypass test
tests/kms_colorop: Parametrize the buffer format
tests/kms_colorop: Add 10bpc test and skip if format not supported
tests/kms_colorop: Skip if writeback does not support fourcc
lib/igt_fb: Allow any non-planar format for igt_copy_fb
kms/colorop: Do proper setup and cleanup
lib/igt_color: Support color transform for XRGB2101010
tests/kms_colorop: Set wide [13, 13] bracket for comparison on amdgpu
lib/igt_color: Add PQ variants for 0-1 and 0-125 range
tests/kms_colorop: Add tests for PQ variants
lib/igt_color: add BT2020/BT709 transfer functions
tests/kms_colorop: Add tests for BT2020/BT709 TFs
lib/igt_color: Point license header at skia license
include/drm-uapi/drm.h | 15 +
include/drm-uapi/drm_mode.h | 131 +
lib/drmtest.c | 5 +
lib/drmtest.h | 1 +
lib/igt_color.c | 653 +++
lib/igt_color.h | 162 +
lib/igt_color_lut.h | 9866 +++++++++++++++++++++++++++++++++++
lib/igt_fb.c | 36 +-
lib/igt_fb.h | 3 +
lib/igt_kms.c | 329 +-
lib/igt_kms.h | 100 +
lib/meson.build | 1 +
scripts/convert_3dlut.py | 94 +
tests/kms_colorop.c | 714 +++
tests/kms_colorop.h | 275 +
tests/kms_properties.c | 69 +
tests/kms_writeback.c | 38 +-
tests/meson.build | 1 +
18 files changed, 12458 insertions(+), 35 deletions(-)
create mode 100644 lib/igt_color.c
create mode 100644 lib/igt_color.h
create mode 100644 lib/igt_color_lut.h
create mode 100755 scripts/convert_3dlut.py
create mode 100644 tests/kms_colorop.c
create mode 100644 tests/kms_colorop.h
--
2.46.0
next reply other threads:[~2024-08-19 20:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 20:57 Harry Wentland [this message]
2024-08-19 20:57 ` [PATCH v5 01/37] lib/drmtest: Add is_vkms_device() Harry Wentland
2024-08-19 20:57 ` [PATCH v5 02/37] tests/kms_writeback: Fix kms_writeback for VKMS Harry Wentland
2024-08-19 20:57 ` [PATCH v5 03/37] lib/igt_kms: Move get_writeback_formats_blob to lib Harry Wentland
2024-08-19 20:57 ` [PATCH v5 04/37] lib/igt_kms: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE Harry Wentland
2024-08-19 20:57 ` [PATCH v5 05/37] include/drm-uapi: Add COLOROP object Harry Wentland
2024-08-19 20:57 ` [PATCH v5 06/37] drm-uapi: Add 3x4 CTM Harry Wentland
2024-08-19 20:57 ` [PATCH v5 07/37] drm-uapi: Add 1D LUT drm_colorop_type Harry Wentland
2024-08-19 20:57 ` [PATCH v5 08/37] lib/igt_kms: Introduce drm_colorop and COLOR_PIPELINE Harry Wentland
2024-08-19 20:57 ` [PATCH v5 09/37] tests/kms_properties: Add colorop properties test Harry Wentland
2024-08-19 20:57 ` [PATCH v5 10/37] igt/color: Add SW color transform functionality Harry Wentland
2024-08-19 20:57 ` [PATCH v5 11/37] lib/igt_fb: Add copy_fb function Harry Wentland
2024-08-19 20:57 ` [PATCH v5 12/37] tests/kms_colorop: Add kms_colorop tests Harry Wentland
2024-08-19 20:57 ` [PATCH v5 13/37] lib/igt_kms: Add support for DATA colorop property Harry Wentland
2024-08-19 20:58 ` [PATCH v5 14/37] lib/igt_color: Add support for 3x4 matrices Harry Wentland
2024-08-19 20:58 ` [PATCH v5 15/37] tests/kms_colorop: Add 3x4 CTM tests Harry Wentland
2024-08-19 20:58 ` [PATCH v5 16/37] tests/kms_colorop: Add bypass test Harry Wentland
2024-08-19 20:58 ` [PATCH v5 17/37] tests/kms_colorop: Parametrize the buffer format Harry Wentland
2024-08-19 20:58 ` [PATCH v5 18/37] tests/kms_colorop: Add 10bpc test and skip if format not supported Harry Wentland
2024-08-19 20:58 ` [PATCH v5 19/37] tests/kms_colorop: Skip if writeback does not support fourcc Harry Wentland
2024-08-19 20:58 ` [PATCH v5 20/37] lib/igt_fb: Allow any non-planar format for igt_copy_fb Harry Wentland
2024-08-19 20:58 ` [PATCH v5 21/37] kms/colorop: Do proper setup and cleanup Harry Wentland
2024-08-19 20:58 ` [PATCH v5 22/37] lib/igt_color: Support color transform for XRGB2101010 Harry Wentland
2024-08-19 20:58 ` [PATCH v5 23/37] tests/kms_colorop: Set wide [13, 13] bracket for comparison on amdgpu Harry Wentland
2024-08-19 20:58 ` [PATCH v5 24/37] lib/igt_color: Add PQ variants for 0-1 and 0-125 range Harry Wentland
2024-08-19 20:58 ` [PATCH v5 25/37] tests/kms_colorop: Add tests for PQ variants Harry Wentland
2024-08-19 20:58 ` [PATCH v5 26/37] lib/igt_kms: increase MAX_NUM_COLOROPS to 128 Harry Wentland
2024-08-19 20:58 ` [PATCH v5 27/37] tests/kms_colorop: Add a sRGB test for EOTF -> Inverse EOTF -> EOTF Harry Wentland
2024-08-19 20:58 ` [PATCH v5 28/37] lib/igt_color: add BT2020/BT709 transfer functions Harry Wentland
2024-08-19 20:58 ` [PATCH v5 29/37] tests/kms_colorop: Add tests for BT2020/BT709 TFs Harry Wentland
2024-08-19 20:58 ` [PATCH v5 30/37] lib/igt_color: Add 1D LUT color transformation support Harry Wentland
2024-08-19 20:58 ` [PATCH v5 31/37] test/kms_colorop: Add tests that exercise the 1D LUT colorops Harry Wentland
2024-08-19 20:58 ` [PATCH v5 32/37] tests/kms_colorop: Add multiplier tests Harry Wentland
2024-08-19 20:58 ` [PATCH v5 33/37] lib/igt_color: Point license header at skia license Harry Wentland
2024-08-19 20:58 ` [PATCH v5 34/37] scripts/convert_3dlut.py Convert a 3D LUT to igt_3dlut_t array for 3D LUT API Harry Wentland
2024-08-19 20:58 ` [PATCH v5 35/37] tests/kms_colorop: Add 3D LUT subtests Harry Wentland
2024-08-19 20:58 ` [PATCH v5 36/37] drm-uapi: Update kernel doc for drm_colorop_type Harry Wentland
2024-08-19 20:58 ` [PATCH v5 37/37] drm-uapi: Sync up definition with kernel colorop implementation Harry Wentland
2024-08-19 23:30 ` ✓ CI.xeBAT: success for IGT tests for the KMS Color Pipeline API (rev6) Patchwork
2024-08-19 23:46 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-08-20 7:49 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819205823.316656-1-harry.wentland@amd.com \
--to=harry.wentland@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox