From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Gustavo Sousa <gustavo.sousa@intel.com>,
Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t v2 2/6] tools/intel-gfx-fw-info: Annotate abstract method
Date: Tue, 20 Aug 2024 16:29:24 -0700 [thread overview]
Message-ID: <20240820232928.458248-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240820232928.458248-1-lucas.demarchi@intel.com>
Make the FW an abstract class and annotate the decode() method.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
tools/intel-gfx-fw-info | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/intel-gfx-fw-info b/tools/intel-gfx-fw-info
index 35555aab5..3105144b7 100755
--- a/tools/intel-gfx-fw-info
+++ b/tools/intel-gfx-fw-info
@@ -4,6 +4,7 @@
#
# Copyright (C) 2023 Intel Corporation
+import abc
import argparse
import logging
import hashlib
@@ -103,10 +104,14 @@ def FIELD_GET(mask: int, value: int) -> int:
return (value & mask) >> ffs(mask)
-class Fw:
+class Fw(abc.ABC):
def __init__(self, fw):
self.fw = fw
+ @abc.abstractmethod
+ def decode(self):
+ raise NotImplementedError()
+
class FwCss(Fw):
def decode(self):
--
2.43.0
next prev parent reply other threads:[~2024-08-20 23:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 23:29 [PATCH i-g-t v2 0/6] Parse GSC-based HuC firmware layout Lucas De Marchi
2024-08-20 23:29 ` [PATCH i-g-t v2 1/6] tools/intel-gfx-fw-info: Re-format with black Lucas De Marchi
2024-08-21 11:29 ` Kamil Konieczny
2024-08-21 12:35 ` Lucas De Marchi
2024-08-21 17:11 ` Kamil Konieczny
2024-08-21 16:46 ` Gustavo Sousa
2024-08-20 23:29 ` Lucas De Marchi [this message]
2024-08-21 16:47 ` [PATCH i-g-t v2 2/6] tools/intel-gfx-fw-info: Annotate abstract method Gustavo Sousa
2024-08-20 23:29 ` [PATCH i-g-t v2 3/6] tools/intel-gfx-fw-info: Embed fw decoding Lucas De Marchi
2024-08-21 17:06 ` Gustavo Sousa
2024-08-21 18:17 ` Lucas De Marchi
2024-08-20 23:29 ` [PATCH i-g-t v2 4/6] tools/intel-gfx-fw-info: Override kernel types Lucas De Marchi
2024-08-21 17:18 ` Gustavo Sousa
2024-08-21 18:37 ` Lucas De Marchi
2024-08-20 23:29 ` [PATCH i-g-t v2 5/6] tools/intel-gfx-fw-info: Add proper HuC parser Lucas De Marchi
2024-08-20 23:29 ` [PATCH i-g-t v2 6/6] tools/intel-gfx-fw-info: do not use bare 'except' Lucas De Marchi
2024-08-21 17:19 ` Gustavo Sousa
2024-08-20 23:54 ` ✓ CI.xeBAT: success for Parse GSC-based HuC firmware layout (rev2) Patchwork
2024-08-21 0:11 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-21 3:24 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-21 7:57 ` ✓ CI.xeFULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820232928.458248-3-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox