Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: pranay.samala@intel.com, ankit.k.nautiyal@intel.com,
	jeevan.b@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH i-g-t 2/5] tests/kms_content_protection: Move try commit call
Date: Thu, 22 Aug 2024 11:41:47 +0530	[thread overview]
Message-ID: <20240822061150.4127413-3-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20240822061150.4127413-1-suraj.kandpal@intel.com>

Currently we are calling try commit twice once in if condition and
again right after that. The correct sequence should be we call try
commit again only if the first one fails.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
 tests/kms_content_protection.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
index 6bd744351..db6dc17b1 100644
--- a/tests/kms_content_protection.c
+++ b/tests/kms_content_protection.c
@@ -679,10 +679,10 @@ test_content_protection_mst(int content_type)
 
 		for (count = 0; count < valid_outputs; count++)
 			prepare_modeset_on_mst_output(hdcp_mst_output[count]);
-	}
 
-	ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
-	igt_require_f(ret == 0, "Commit failure during MST modeset\n");
+		ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
+		igt_require_f(ret == 0, "Commit failure during MST modeset\n");
+	}
 
 	for (count = 0; count < valid_outputs; count++) {
 		igt_output_set_prop_value(hdcp_mst_output[count], IGT_CONNECTOR_CONTENT_PROTECTION, CP_DESIRED);
-- 
2.43.2


  parent reply	other threads:[~2024-08-22  6:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  6:11 [PATCH i-g-t 0/5] Improve MST HDCP tests Suraj Kandpal
2024-08-22  6:11 ` [PATCH i-g-t 1/5] tests/kms_content_protection: Move HDCP output checks earlier Suraj Kandpal
2024-08-22  6:11 ` Suraj Kandpal [this message]
2024-08-22  6:11 ` [PATCH i-g-t 3/5] tests/kms_content_protection: Rename igt_commit_style variable Suraj Kandpal
2024-08-22  6:11 ` [PATCH i-g-t 4/5] tests/kms_content_protection: Add retry logic for mst usecase Suraj Kandpal
2024-08-23  4:32   ` B, Jeevan
2024-08-22  6:11 ` [PATCH i-g-t 5/5] tests/kms_content_protection: Set screen red/green based on CP Status Suraj Kandpal
2024-08-22  7:25 ` ✓ CI.xeBAT: success for Improve MST HDCP tests (rev3) Patchwork
2024-08-22  7:25 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-22 10:57 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-23  5:08 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-27  5:21 ` [PATCH i-g-t 0/5] Improve MST HDCP tests B, Jeevan
  -- strict thread matches above, loose matches on Subject: below --
2024-08-27  6:18 Suraj Kandpal
2024-08-27  6:19 ` [PATCH i-g-t 2/5] tests/kms_content_protection: Move try commit call Suraj Kandpal
2024-08-20  8:12 [PATCH i-g-t 0/5] Improve MST HDCP tests Suraj Kandpal
2024-08-20  8:12 ` [PATCH i-g-t 2/5] tests/kms_content_protection: Move try commit call Suraj Kandpal
2024-08-21 14:37   ` B, Jeevan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240822061150.4127413-3-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=pranay.samala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox