Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Manszewski <christoph.manszewski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Dominik Grzegorzek" <dominik.grzegorzek@intel.com>,
	"Maciej Patelczyk" <maciej.patelczyk@intel.com>,
	"Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>,
	"Pawel Sikora" <pawel.sikora@intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Kolanupaka Naveena" <kolanupaka.naveena@intel.com>,
	"Mika Kuoppala" <mika.kuoppala@intel.com>,
	"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>
Subject: [PATCH i-g-t v4 08/17] lib/gpgpu_shader: Allow enabling illegal opcode exceptions in shader
Date: Fri, 23 Aug 2024 20:22:13 +0200	[thread overview]
Message-ID: <20240823182222.305965-9-christoph.manszewski@intel.com> (raw)
In-Reply-To: <20240823182222.305965-1-christoph.manszewski@intel.com>

From: Andrzej Hajda <andrzej.hajda@intel.com>

Illegal opcode exceptions can be enabled in interface descriptor data
passed to COMPUTE_WALKER instruction.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Acked-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
---
 lib/gpgpu_shader.c | 4 ++++
 lib/gpgpu_shader.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/lib/gpgpu_shader.c b/lib/gpgpu_shader.c
index 1616c1942..4e61a548f 100644
--- a/lib/gpgpu_shader.c
+++ b/lib/gpgpu_shader.c
@@ -103,6 +103,7 @@ __xelp_gpgpu_execfunc(struct intel_bb *ibb,
 		      struct gpgpu_shader *sip,
 		      uint64_t ring, bool explicit_engine)
 {
+	struct gen8_interface_descriptor_data *idd;
 	uint32_t interface_descriptor, sip_offset;
 	uint64_t engine;
 
@@ -113,6 +114,8 @@ __xelp_gpgpu_execfunc(struct intel_bb *ibb,
 	interface_descriptor = gen8_fill_interface_descriptor(ibb, target,
 							      shdr->instr,
 							      4 * shdr->size);
+	idd = intel_bb_ptr_get(ibb, interface_descriptor);
+	idd->desc2.illegal_opcode_exception_enable = shdr->illegal_opcode_exception_enable;
 
 	if (sip && sip->size)
 		sip_offset = fill_sip(ibb, sip->instr, 4 * sip->size);
@@ -163,6 +166,7 @@ __xehp_gpgpu_execfunc(struct intel_bb *ibb,
 
 	xehp_fill_interface_descriptor(ibb, target, shdr->instr,
 				       4 * shdr->size, &idd);
+	idd.desc2.illegal_opcode_exception_enable = shdr->illegal_opcode_exception_enable;
 
 	if (sip && sip->size)
 		sip_offset = fill_sip(ibb, sip->instr, 4 * sip->size);
diff --git a/lib/gpgpu_shader.h b/lib/gpgpu_shader.h
index 0bbeae66f..26a117a0b 100644
--- a/lib/gpgpu_shader.h
+++ b/lib/gpgpu_shader.h
@@ -22,6 +22,7 @@ struct gpgpu_shader {
 		uint32_t (*instr)[4];
 	};
 	struct igt_map *labels;
+	bool illegal_opcode_exception_enable;
 };
 
 struct iga64_template {
-- 
2.34.1


  parent reply	other threads:[~2024-08-23 18:23 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23 18:22 [PATCH i-g-t v4 00/17] Test coverage for GPU debug support Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 01/17] drm-uapi/xe: Sync with oa uapi fix Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 02/17] drm-uapi/xe: Sync with eudebug uapi Christoph Manszewski
2024-08-26  9:32   ` Zbigniew Kempczyński
2024-08-26 15:08     ` Manszewski, Christoph
2024-08-23 18:22 ` [PATCH i-g-t v4 03/17] lib/xe_ioctl: Add wrapper with vm_bind_op extension parameter Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 04/17] lib/gpgpu_shader: Extend shader building library Christoph Manszewski
2024-08-26  9:44   ` Zbigniew Kempczyński
2024-08-26 10:02     ` Manszewski, Christoph
2024-08-29 10:11   ` Zbigniew Kempczyński
2024-08-29 12:57     ` Grzegorzek, Dominik
2024-08-30  8:57       ` Zbigniew Kempczyński
2024-08-23 18:22 ` [PATCH i-g-t v4 05/17] lib/gpgpu_shader: Add write_on_exception template Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 06/17] lib/gpgpu_shader: Add set/clear exception register (cr0.1) helpers Christoph Manszewski
2024-08-26 10:05   ` Zbigniew Kempczyński
2024-08-23 18:22 ` [PATCH i-g-t v4 07/17] lib/intel_batchbuffer: Add helper to get pointer at specified offset Christoph Manszewski
2024-08-26 10:08   ` Zbigniew Kempczyński
2024-08-23 18:22 ` Christoph Manszewski [this message]
2024-08-26 11:13   ` [PATCH i-g-t v4 08/17] lib/gpgpu_shader: Allow enabling illegal opcode exceptions in shader Zbigniew Kempczyński
2024-08-23 18:22 ` [PATCH i-g-t v4 09/17] tests/xe_exec_sip: Add sanity-after-timeout test Christoph Manszewski
2024-08-27  8:19   ` Zbigniew Kempczyński
2024-08-27  8:26     ` Manszewski, Christoph
2024-08-27  9:06     ` Manszewski, Christoph
2024-08-23 18:22 ` [PATCH i-g-t v4 10/17] tests/xe_exec_sip: Introduce invalid instruction tests Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 11/17] lib/xe_eudebug: Introduce eu debug testing framework Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 12/17] scripts/igt_doc: Add '--exclude-files' parameter Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 13/17] tests/xe_eudebug: Test eudebug resource tracking and manipulation Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 14/17] lib/intel_batchbuffer: Add support for long-running mode execution Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 15/17] tests/xe_exec_sip_eudebug: Add SIP tests for eudebug Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 16/17] tests/xe_eudebug_online: Debug client which runs workloads on EU Christoph Manszewski
2024-08-23 18:22 ` [PATCH i-g-t v4 17/17] tests/xe_live_ktest: Add xe_eudebug live test Christoph Manszewski
2024-08-23 21:30 ` ✗ GitLab.Pipeline: warning for Test coverage for GPU debug support (rev4) Patchwork
2024-08-26 15:10   ` Manszewski, Christoph
2024-08-23 21:45 ` ✓ CI.xeBAT: success " Patchwork
2024-08-23 21:58 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-24  4:38 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-26 15:14   ` Manszewski, Christoph
2024-08-26  2:31 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-26 15:13   ` Manszewski, Christoph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240823182222.305965-9-christoph.manszewski@intel.com \
    --to=christoph.manszewski@intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dominik.grzegorzek@intel.com \
    --cc=dominik.karol.piatkowski@intel.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=kolanupaka.naveena@intel.com \
    --cc=maciej.patelczyk@intel.com \
    --cc=mika.kuoppala@intel.com \
    --cc=pawel.sikora@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox