From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [PATCH i-g-t 12/14] lib/igt_kms: allow set and reset value to be same
Date: Sun, 25 Aug 2024 23:44:22 +0530 [thread overview]
Message-ID: <20240825181424.4034541-13-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20240825181424.4034541-1-kunal1.joshi@intel.com>
allow set and reset value to be same, let the caller handle
this scenario instead.
example scenario where this is required.
i915_dp_force_link_rate should be auto before starting test
should be auto at exit
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
lib/igt_kms.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index b7511ccfc..5427a849e 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1572,9 +1572,6 @@ static bool connector_attr_set(int idx, drmModeConnector *connector,
return false;
}
- if (!strcmp(c->value, c->reset_value))
- connector_attr_free(c);
-
return true;
}
--
2.43.0
next prev parent reply other threads:[~2024-08-25 18:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 18:14 [PATCH i-g-t 00/14] add test to validate fallback Kunal Joshi
2024-08-25 18:14 ` [PATCH i-g-t 01/14] lib/igt_kms: add enum for link rate and lane count Kunal Joshi
2024-08-27 5:30 ` B, Jeevan
2024-08-25 18:14 ` [PATCH i-g-t 02/14] lib/igt_kms: add helper to get current link rate/ lane count for connector Kunal Joshi
2024-08-25 18:14 ` [PATCH i-g-t 03/14] lib/igt_kms: add function to get max link rate/lane count Kunal Joshi
2024-09-04 3:59 ` Samala, Pranay
2024-08-25 18:14 ` [PATCH i-g-t 04/14] lib/igt_kms: add function to force link retrain Kunal Joshi
2024-08-25 18:14 ` [PATCH i-g-t 05/14] lib/igt_kms: add function to force link training failure Kunal Joshi
2024-08-25 18:14 ` [PATCH i-g-t 06/14] lib/igt_kms: add function to check if retrain disabled Kunal Joshi
2024-09-04 5:13 ` Samala, Pranay
2024-08-25 18:14 ` [PATCH i-g-t 07/14] lib/igt_kms: add function to check force link training failure support Kunal Joshi
2024-09-03 8:08 ` Samala, Pranay
2024-08-25 18:14 ` [PATCH i-g-t 08/14] lib/igt_kms: add helper to get pending lt failures Kunal Joshi
2024-08-25 18:14 ` [PATCH i-g-t 09/14] lib/igt_kms: add helper to get pending retrain count Kunal Joshi
2024-08-25 18:14 ` [PATCH i-g-t 10/14] lib/igt_kms: add helper to set connector link status Kunal Joshi
2024-08-25 18:14 ` [PATCH i-g-t 11/14] lib/igt_kms: add function to reset link params Kunal Joshi
2024-08-25 18:14 ` Kunal Joshi [this message]
2024-08-25 18:14 ` [PATCH i-g-t 13/14] tests/intel/kms_dp_fallback: add test for validating fallback Kunal Joshi
2024-09-03 8:07 ` Samala, Pranay
2024-08-25 18:14 ` [PATCH i-g-t 14/14] HAX: Do not merge Kunal Joshi
2024-08-25 18:32 ` ✗ CI.xeBAT: failure for add test to validate fallback (rev4) Patchwork
2024-08-25 18:45 ` ✗ Fi.CI.BAT: " Patchwork
2024-08-25 19:32 ` ✗ CI.xeFULL: " Patchwork
[not found] <20240825200612.4036178-1-kunal1.joshi@intel.com>
2024-08-25 20:06 ` [PATCH i-g-t 12/14] lib/igt_kms: allow set and reset value to be same Kunal Joshi
2024-09-03 14:29 ` Imre Deak
2024-09-12 6:03 ` Joshi, Kunal1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240825181424.4034541-13-kunal1.joshi@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox