From: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>
Subject: [PATCH i-g-t 2/2] lib/intel_batchbuffer: Fix igt_require in intel_bb_create_no_relocs
Date: Wed, 4 Sep 2024 09:38:03 +0200 [thread overview]
Message-ID: <20240904073803.3239-3-dominik.karol.piatkowski@intel.com> (raw)
In-Reply-To: <20240904073803.3239-1-dominik.karol.piatkowski@intel.com>
gem_uses_full_ppgtt() calls gem_gtt_type(), that expects i915 drm
file descriptor. Wrap the igt_require in is_i915_device() check
to fix the issue.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@intel.com>
---
lib/intel_batchbuffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 72e2a5d38..93477661b 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1234,7 +1234,8 @@ intel_bb_create_with_relocs_and_context(int fd, uint32_t ctx,
*/
struct intel_bb *intel_bb_create_no_relocs(int fd, uint32_t size)
{
- igt_require(gem_uses_full_ppgtt(fd));
+ if (is_i915_device(fd))
+ igt_require(gem_uses_full_ppgtt(fd));
return __intel_bb_create(fd, 0, 0, NULL, size, false, 0, 0, 0,
INTEL_ALLOCATOR_SIMPLE,
--
2.34.1
next prev parent reply other threads:[~2024-09-04 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 7:38 [PATCH i-g-t 0/2] lib/intel_batchbuffer: Introduce intel_bb_create_with_context_in_region Dominik Karol Piątkowski
2024-09-04 7:38 ` [PATCH i-g-t 1/2] " Dominik Karol Piątkowski
2024-09-04 8:03 ` Zbigniew Kempczyński
2024-09-04 7:38 ` Dominik Karol Piątkowski [this message]
2024-09-04 17:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-09-04 17:37 ` ✓ CI.xeBAT: " Patchwork
2024-09-05 14:56 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-06 18:53 ` ✗ CI.xeFULL: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-09-02 11:46 [PATCH i-g-t 0/1] lib/intel_batchbuffer: Introduce intel_bb_create_with_context_in_memory Dominik Karol Piątkowski
2024-09-03 9:34 ` [PATCH v2 i-g-t 0/2] lib/intel_batchbuffer: Introduce intel_bb_create_with_context_in_region Dominik Karol Piątkowski
2024-09-03 9:34 ` [PATCH i-g-t 2/2] lib/intel_batchbuffer: Fix igt_require in intel_bb_create_no_relocs Dominik Karol Piątkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904073803.3239-3-dominik.karol.piatkowski@intel.com \
--to=dominik.karol.piatkowski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox