From: Christoph Manszewski <christoph.manszewski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
"Dominik Grzegorzek" <dominik.grzegorzek@intel.com>,
"Maciej Patelczyk" <maciej.patelczyk@intel.com>,
"Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>,
"Pawel Sikora" <pawel.sikora@intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Kolanupaka Naveena" <kolanupaka.naveena@intel.com>,
"Mika Kuoppala" <mika.kuoppala@intel.com>,
"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
"Christoph Manszewski" <christoph.manszewski@intel.com>
Subject: [PATCH i-g-t v6 07/17] lib/gpgpu_shader: Allow enabling illegal opcode exceptions in shader
Date: Thu, 5 Sep 2024 11:28:02 +0200 [thread overview]
Message-ID: <20240905092812.94553-8-christoph.manszewski@intel.com> (raw)
In-Reply-To: <20240905092812.94553-1-christoph.manszewski@intel.com>
From: Andrzej Hajda <andrzej.hajda@intel.com>
Illegal opcode exceptions can be enabled in interface descriptor data
passed to COMPUTE_WALKER instruction.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/gpgpu_shader.c | 4 ++++
lib/gpgpu_shader.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/lib/gpgpu_shader.c b/lib/gpgpu_shader.c
index 9284ad5ea..d4dd118d6 100644
--- a/lib/gpgpu_shader.c
+++ b/lib/gpgpu_shader.c
@@ -103,6 +103,7 @@ __xelp_gpgpu_execfunc(struct intel_bb *ibb,
struct gpgpu_shader *sip,
uint64_t ring, bool explicit_engine)
{
+ struct gen8_interface_descriptor_data *idd;
uint32_t interface_descriptor, sip_offset;
uint64_t engine;
@@ -113,6 +114,8 @@ __xelp_gpgpu_execfunc(struct intel_bb *ibb,
interface_descriptor = gen8_fill_interface_descriptor(ibb, target,
shdr->instr,
4 * shdr->size);
+ idd = intel_bb_ptr_get(ibb, interface_descriptor);
+ idd->desc2.illegal_opcode_exception_enable = shdr->illegal_opcode_exception_enable;
if (sip && sip->size)
sip_offset = fill_sip(ibb, sip->instr, 4 * sip->size);
@@ -163,6 +166,7 @@ __xehp_gpgpu_execfunc(struct intel_bb *ibb,
xehp_fill_interface_descriptor(ibb, target, shdr->instr,
4 * shdr->size, &idd);
+ idd.desc2.illegal_opcode_exception_enable = shdr->illegal_opcode_exception_enable;
if (sip && sip->size)
sip_offset = fill_sip(ibb, sip->instr, 4 * sip->size);
diff --git a/lib/gpgpu_shader.h b/lib/gpgpu_shader.h
index b722b9e50..53fe2869e 100644
--- a/lib/gpgpu_shader.h
+++ b/lib/gpgpu_shader.h
@@ -22,6 +22,7 @@ struct gpgpu_shader {
uint32_t (*instr)[4];
};
struct igt_map *labels;
+ bool illegal_opcode_exception_enable;
};
struct iga64_template {
--
2.34.1
next prev parent reply other threads:[~2024-09-05 9:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 9:27 [PATCH i-g-t v6 00/17] Test coverage for GPU debug support Christoph Manszewski
2024-09-05 9:27 ` [PATCH i-g-t v6 01/17] drm-uapi/xe: Sync with oa uapi fix Christoph Manszewski
2024-09-06 14:41 ` Kamil Konieczny
2024-09-05 9:27 ` [PATCH i-g-t v6 02/17] lib/xe_ioctl: Add wrapper with vm_bind_op extension parameter Christoph Manszewski
2024-09-05 9:27 ` [PATCH i-g-t v6 03/17] lib/gpgpu_shader: Extend shader building library Christoph Manszewski
2024-09-05 11:56 ` Zbigniew Kempczyński
2024-09-09 6:54 ` Zbigniew Kempczyński
2024-09-05 9:27 ` [PATCH i-g-t v6 04/17] lib/gpgpu_shader: Add write_on_exception template Christoph Manszewski
2024-09-05 10:51 ` Zbigniew Kempczyński
2024-09-06 5:58 ` Andrzej Hajda
2024-09-06 6:54 ` Zbigniew Kempczyński
2024-09-05 9:28 ` [PATCH i-g-t v6 05/17] lib/gpgpu_shader: Add set/clear exception register (cr0.1) helpers Christoph Manszewski
2024-09-05 9:28 ` [PATCH i-g-t v6 06/17] lib/intel_batchbuffer: Add helper to get pointer at specified offset Christoph Manszewski
2024-09-06 7:46 ` Zbigniew Kempczyński
2024-09-05 9:28 ` Christoph Manszewski [this message]
2024-09-05 9:28 ` [PATCH i-g-t v6 08/17] tests/xe_exec_sip: Add sanity-after-timeout test Christoph Manszewski
2024-09-05 9:28 ` [PATCH i-g-t v6 09/17] tests/xe_exec_sip: Introduce invalid instruction tests Christoph Manszewski
2024-09-05 18:39 ` Zbigniew Kempczyński
2024-09-09 7:21 ` Zbigniew Kempczyński
2024-09-13 11:50 ` Manszewski, Christoph
2024-09-05 9:28 ` [PATCH i-g-t v6 10/17] drm-uapi/xe: Sync with eudebug uapi Christoph Manszewski
2024-09-05 9:28 ` [PATCH i-g-t v6 11/17] lib/xe_eudebug: Introduce eu debug testing framework Christoph Manszewski
2024-09-09 8:46 ` Zbigniew Kempczyński
2024-09-13 15:14 ` Manszewski, Christoph
2024-09-16 6:48 ` Zbigniew Kempczyński
2024-09-10 5:32 ` Zbigniew Kempczyński
2024-09-05 9:28 ` [PATCH i-g-t v6 12/17] scripts/igt_doc: Add '--exclude-files' parameter Christoph Manszewski
2024-09-09 11:31 ` Kamil Konieczny
2024-09-09 13:57 ` Zbigniew Kempczyński
2024-09-13 13:24 ` Manszewski, Christoph
2024-09-13 16:40 ` Kamil Konieczny
2024-09-05 9:28 ` [PATCH i-g-t v6 13/17] tests/xe_eudebug: Test eudebug resource tracking and manipulation Christoph Manszewski
2024-09-06 14:46 ` Kamil Konieczny
2024-09-09 10:34 ` Zbigniew Kempczyński
2024-09-12 8:04 ` Zbigniew Kempczyński
2024-09-17 14:44 ` Manszewski, Christoph
2024-09-17 16:00 ` Manszewski, Christoph
2024-09-18 4:47 ` Zbigniew Kempczyński
2024-09-05 9:28 ` [PATCH i-g-t v6 14/17] lib/intel_batchbuffer: Add support for long-running mode execution Christoph Manszewski
2024-09-05 9:28 ` [PATCH i-g-t v6 15/17] tests/xe_exec_sip_eudebug: Port tests for shaders and sip Christoph Manszewski
2024-09-05 9:28 ` [PATCH i-g-t v6 16/17] tests/xe_eudebug_online: Debug client which runs workloads on EU Christoph Manszewski
2024-09-13 11:39 ` Zbigniew Kempczyński
2024-09-17 19:34 ` Grzegorzek, Dominik
2024-09-18 5:08 ` Zbigniew Kempczyński
2024-09-18 6:44 ` Grzegorzek, Dominik
2024-09-18 5:21 ` Zbigniew Kempczyński
2024-09-05 9:28 ` [PATCH i-g-t v6 17/17] tests/xe_live_ktest: Add xe_eudebug live test Christoph Manszewski
2024-09-05 21:04 ` ✗ GitLab.Pipeline: warning for Test coverage for GPU debug support (rev6) Patchwork
2024-09-05 21:33 ` ✓ CI.xeBAT: success " Patchwork
2024-09-05 21:40 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905092812.94553-8-christoph.manszewski@intel.com \
--to=christoph.manszewski@intel.com \
--cc=andrzej.hajda@intel.com \
--cc=dominik.grzegorzek@intel.com \
--cc=dominik.karol.piatkowski@intel.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=kolanupaka.naveena@intel.com \
--cc=maciej.patelczyk@intel.com \
--cc=mika.kuoppala@intel.com \
--cc=pawel.sikora@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox