From: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
Subject: [PATCH i-g-t] RFC tests/intel/kms_frontbuffer_tracking: Introduce plane-fbc-dr test
Date: Mon, 9 Sep 2024 09:44:41 +0530 [thread overview]
Message-ID: <20240909041441.528638-1-santhosh.reddy.guddati@intel.com> (raw)
In-Reply-To: <20240904161221.494423-1-santhosh.reddy.guddati@intel.com>
Use the FP_DAMAGE_CLIPS property of the plane for non psr modes
and fill the damaged rectangles on the plane with framebuffer
coordinates and verify that fbc dirty ctl is enabled.
v2: Fix typo , add version check for feature support,
extend support for all pipes (Rama Naidu)
Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
---
tests/intel/kms_frontbuffer_tracking.c | 78 ++++++++++++++++++++++++++
1 file changed, 78 insertions(+)
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index e45d17dd6..b15527209 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -57,6 +57,10 @@
* Description: Sanity test to enable FBC on a plane.
* Functionality: fbc
*
+ * SUBTEST: plane-fbc-dr
+ * Description: Sanity test to verify FBC DR by sending multiple damaged areas with non psr modes
+ * Functionality: fbc
+ *
* SUBTEST: pipe-fbc-rte
* Description: Sanity test to enable FBC on each pipe.
* Functionality: fbc
@@ -1168,6 +1172,7 @@
*/
#define TIME SLOW_QUICK(1000, 10000)
+#define MAX_DIRTY_RECT 3
IGT_TEST_DESCRIPTION("Test the Kernel's frontbuffer tracking mechanism and "
"its related features: FBC, PSR and DRRS");
@@ -4288,6 +4293,73 @@ static int opt_handler(int option, int option_index, void *data)
return IGT_OPT_HANDLER_SUCCESS;
}
+static void fbc_dr_subtest(const struct test_mode *t) {
+ struct drm_mode_rect rect_data[MAX_DIRTY_RECT];
+ uint32_t color;
+ drmModeModeInfo *mode;
+
+ igt_require_f(drm.display_ver > 20, "FBC with dirty region is not supported\n");
+
+ prepare_subtest_data(t, NULL);
+
+ igt_output_override_mode(prim_mode_params.output, &prim_mode_params.mode);
+ igt_output_set_pipe(prim_mode_params.output, prim_mode_params.pipe);
+
+ mode = igt_output_get_mode(prim_mode_params.output);
+
+ for (int i = 0; i < MAX_DIRTY_RECT; i++) {
+ // Full Frame update
+ rect_data[0].x1 = 0;
+ rect_data[0].y1 = 0;
+ rect_data[0].x2 = mode->hdisplay;
+ rect_data[0].y2 = mode->vdisplay;
+
+ // Half Frame update till last-1 scanline
+ rect_data[1].x1 = mode->hdisplay / 2;
+ rect_data[1].y1 = mode->vdisplay / 2;
+ rect_data[1].x2 = mode->hdisplay - 1;
+ rect_data[1].y2 = mode->vdisplay - 1;
+
+ // last 10 scanlines update
+ rect_data[2].x1 = mode->hdisplay - 10;
+ rect_data[2].y1 = mode->vdisplay - 10;
+ rect_data[2].x2 = mode->hdisplay - 1;
+ rect_data[2].y2 = mode->vdisplay - 1;
+
+ igt_debug("Dirty Rectangle data = {%d, %d, %d, %d}, {%d, %d, %d, %d}, {%d, %d, %d, %d}\n",
+ rect_data[0].x1, rect_data[0].y1, rect_data[0].x2, rect_data[0].y2,
+ rect_data[1].x1, rect_data[1].y1, rect_data[1].x2, rect_data[1].y2,
+ rect_data[2].x1, rect_data[2].y1, rect_data[2].x2, rect_data[2].y2);
+ }
+
+ for(int i = 0; i < MAX_DIRTY_RECT; i++) {
+ igt_plane_t *primary = igt_output_get_plane_type(prim_mode_params.output, DRM_PLANE_TYPE_PRIMARY);
+ igt_fb_t fb[MAX_DIRTY_RECT];
+
+ create_fb(t->format, prim_mode_params.mode.hdisplay, prim_mode_params.mode.vdisplay, t->tiling, t->plane, &fb[i]);
+ color = pick_color(&fb[i], COLOR_PRIM_BG);
+ igt_draw_rect_fb(drm.fd, drm.bops, 0, &fb[i], t->method,
+ rect_data[i].x1, rect_data[i].y1, rect_data[i].x2 - rect_data[i].x1, rect_data[i].y2 - rect_data[i].y1,
+ color);
+
+ igt_plane_set_fb(primary, &fb[i]);
+ igt_plane_set_position(primary, rect_data[i].x1, rect_data[i].y1);
+ igt_plane_set_size(primary, rect_data[i].x2 - rect_data[i].x1, rect_data[i].y2 - rect_data[i].y1);
+ igt_fb_set_size(&fb[i], primary, rect_data[i].x2 - rect_data[i].x1, rect_data[i].y2 - rect_data[i].y1);
+ igt_plane_replace_prop_blob(primary, IGT_PLANE_FB_DAMAGE_CLIPS, &rect_data[i], sizeof(rect_data[i]));
+
+ igt_display_commit_atomic(&drm.display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+ fbc_update_last_action();
+ do_assertions(ASSERT_FBC_ENABLED | ASSERT_NO_ACTION_CHANGE);
+ igt_assert_f(fbc_enable_per_plane(primary->index + 1, prim_mode_params.pipe), "FBC disabled\n");
+
+ igt_remove_fb(drm.fd, &fb[i]);
+ igt_plane_set_fb(primary, NULL);
+ igt_display_commit2(&drm.display, COMMIT_ATOMIC);
+ }
+}
+
const char *help_str =
" --no-status-check Don't check for enable/disable status\n"
" --no-crc-check Don't check for CRC values\n"
@@ -4513,6 +4585,12 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
plane_fbc_rte_subtest(&t);
}
+ igt_subtest_f("plane-fbc-dr") {
+ t.feature = FEATURE_FBC;
+ igt_dynamic_f("pipe-%s", kmstest_pipe_name(prim_mode_params.pipe))
+ fbc_dr_subtest(&t);
+ }
+
igt_subtest_group {
igt_subtest_with_dynamic("pipe-fbc-rte") {
--
2.34.1
next prev parent reply other threads:[~2024-09-09 4:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 16:12 [PATCH i-g-t] RFC tests/intel/kms_frontbuffer_tracking: Introduce plane-fbc-dr test Santhosh Reddy Guddati
2024-09-04 21:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-09-04 21:11 ` ✓ CI.xeBAT: " Patchwork
2024-09-06 15:16 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-06 18:47 ` [PATCH i-g-t] " Naladala, Ramanaidu
2024-09-07 2:20 ` ✗ CI.xeFULL: failure for " Patchwork
2024-09-09 4:14 ` Santhosh Reddy Guddati [this message]
2024-11-04 18:14 ` [PATCH i-g-t] " Naladala, Ramanaidu
2024-09-09 5:28 ` ✓ Fi.CI.BAT: success for RFC tests/intel/kms_frontbuffer_tracking: Introduce plane-fbc-dr test (rev2) Patchwork
2024-09-09 5:38 ` ✓ CI.xeBAT: " Patchwork
2024-09-09 18:27 ` ✓ CI.xeFULL: " Patchwork
2024-09-10 17:02 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909041441.528638-1-santhosh.reddy.guddati@intel.com \
--to=santhosh.reddy.guddati@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox