Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Christoph Manszewski" <christoph.manszewski@intel.com>,
	"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Jari Tahvanainen" <jari.tahvanainen@intel.com>,
	"Katarzyna Piecielska" <katarzyna.piecielska@intel.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>
Subject: [PATCH i-g-t 1/1] scripts/test_list: relax treatment of non-compiled tests
Date: Thu, 12 Sep 2024 16:04:01 +0200	[thread overview]
Message-ID: <20240912140401.137060-2-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20240912140401.137060-1-kamil.konieczny@linux.intel.com>

Some tests could be added and compiled only when non-default
meson option is given. It will result in no testlist generated
for such tests but they could appear in our documentation.
Currently we report an error in such case.

Create a way to detect and report that and treat this as feature
and do not report it as an error.  This should allow to relax
processing of chamelium and other new tests.

Also while at this, print error information before actually
exiting with an error code, as previous prints were only
warnings.

Cc: Christoph Manszewski <christoph.manszewski@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Jari Tahvanainen <jari.tahvanainen@intel.com>
Cc: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 scripts/test_list.py | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/scripts/test_list.py b/scripts/test_list.py
index 69c830ca1..322933c26 100644
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -1141,6 +1141,20 @@ class TestList:
 
         return sorted(tests)
 
+    def get_notcompiled(self):
+
+        """ Return a list of tests which were not compiled """
+        no_binaries = []
+        for name in self.filenames:
+            test_basename = re.sub(r"\.c$", "", name.split('/')[-1])
+            fname = os.path.join(self.igt_build_path, "tests", test_basename)
+
+            if not os.path.isfile(fname):
+                print(f"{test_basename}: No binary found, test was not compiled.")
+                no_binaries.append(test_basename)
+
+        return sorted(no_binaries)
+
     #
     # Validation methods
     #
@@ -1177,21 +1191,34 @@ class TestList:
         # Get a list of tests from
         run_subtests = set(self.get_testlist())
 
+        # Get a list of not compiled tests
+        no_binary = set(self.get_notcompiled())
+
         # Compare sets
 
         run_missing = list(sorted(run_subtests - doc_subtests))
         doc_uneeded = list(sorted(doc_subtests - run_subtests))
 
+        """Check if there are (possibly unneeded) documented subtests"""
         if doc_uneeded:
+            un_reported = []
             for test_name in doc_uneeded:
-                print(f"Warning: Documented {test_name} doesn't exist on source files")
+                test_basename = test_name.split('@')[1]
+                if test_basename in no_binary:
+                    if test_basename not in un_reported:
+                        print(f"Info: Documented {test_name} don't have a binary {test_basename}")
+                        un_reported.append(test_basename)
+                else:
+                    print(f"Info: Documented {test_name} doesn't exist on source files")
 
+        """Check for missing documentation"""
         if run_missing:
             for test_name in run_missing:
                 print(f'Warning: Missing documentation for {test_name}')
             print('Please refer: docs/test_documentation.md for more details')
 
-        if doc_uneeded or run_missing:
+        if run_missing:
+            print('Error: Missing tests documentation')
             sys.exit(1)
 
     #
-- 
2.43.0


  reply	other threads:[~2024-09-12 14:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 14:04 [PATCH i-g-t 0/1] relax doc generation for non-compiled tests Kamil Konieczny
2024-09-12 14:04 ` Kamil Konieczny [this message]
2024-09-13 11:03   ` [PATCH i-g-t 1/1] scripts/test_list: relax treatment of " Manszewski, Christoph
2024-09-12 16:47 ` ✓ Fi.CI.BAT: success for relax doc generation for " Patchwork
2024-09-12 17:06 ` ✓ CI.xeBAT: " Patchwork
2024-09-13  5:11 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-13  6:02 ` ✗ Fi.CI.IGT: " Patchwork
2024-09-13 10:58 ` [PATCH i-g-t 0/1] " Manszewski, Christoph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240912140401.137060-2-kamil.konieczny@linux.intel.com \
    --to=kamil.konieczny@linux.intel.com \
    --cc=christoph.manszewski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jari.tahvanainen@intel.com \
    --cc=katarzyna.piecielska@intel.com \
    --cc=mchehab@kernel.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox