Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Bhanuprakash Modem" <bhanuprakash.modem@intel.com>
Subject: [i-g-t] tests/kms_display_modes: Fix the plane setup in extended-mode-basic
Date: Fri, 13 Sep 2024 13:54:33 +0530	[thread overview]
Message-ID: <20240913082433.738422-1-bhanuprakash.modem@intel.com> (raw)

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The test forgets to set the output size of the planes. The
default plane output size will be taken from the fb dimensions
which means we end up upscaling the planes, which may not work
on all hardware.

Set the planes' output size to match the input size to avoid this.
The frambuffer was specifically created wide enough to cover both
outputs with 1:1 scaling.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9841
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> (Re-float)
---
 tests/kms_display_modes.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index 1f0f811c8..f1d8ab03d 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -180,10 +180,12 @@ static void run_extendedmode_basic(data_t *data,
 	igt_plane_set_fb(plane[0], &fb);
 	igt_fb_set_position(&fb, plane[0], 0, 0);
 	igt_fb_set_size(&fb, plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
+	igt_plane_set_size(plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
 
 	igt_plane_set_fb(plane[1], &fb);
 	igt_fb_set_position(&fb, plane[1], mode[0]->hdisplay, 0);
 	igt_fb_set_size(&fb, plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
+	igt_plane_set_size(plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
 
 	igt_display_commit2(display, COMMIT_ATOMIC);
 
-- 
2.43.0


             reply	other threads:[~2024-09-13  8:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13  8:24 Bhanuprakash Modem [this message]
2024-09-13 11:20 ` ✗ CI.xeBAT: failure for tests/kms_display_modes: Fix the plane setup in extended-mode-basic Patchwork
2024-09-13 11:29 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-13 23:28 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-14 21:21 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913082433.738422-1-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox