Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: bhanuprakash.modem@intel.com, karthik.b.s@intel.com,
	jeevan.b@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH i-g-t] tests/kms_universal_plane: Use COMMIT_ATOMIC flag when doing commit
Date: Wed, 18 Sep 2024 13:59:17 +0530	[thread overview]
Message-ID: <20240918082918.792033-1-suraj.kandpal@intel.com> (raw)

Use COMMIT_ATOMIC flag when doing a display commit so that we make
sure to wait for all the cleanup work to be done before going and
reading the i915_gem_framebuffer entry otherwise it may end up
showing an incorrect count sporadically if the cleanup takes
place after the count is read.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 tests/kms_universal_plane.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index 8c1ce8143..081847f87 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -702,7 +702,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	/* Release our framebuffer handles before we take a second count */
 	igt_plane_set_fb(primary, NULL);
 	igt_plane_set_fb(cursor, NULL);
-	igt_display_commit2(display, COMMIT_LEGACY);
+	igt_display_commit2(display, COMMIT_ATOMIC);
 	cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
 
 	/* We should be back to the same framebuffer count as when we started */
-- 
2.43.2


             reply	other threads:[~2024-09-18  8:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18  8:29 Suraj Kandpal [this message]
2024-09-18  9:35 ` ✗ Fi.CI.BAT: failure for tests/kms_universal_plane: Use COMMIT_ATOMIC flag when doing commit Patchwork
2024-09-18 10:18 ` [PATCH i-g-t] " Modem, Bhanuprakash
2024-09-18 10:33 ` Suraj Kandpal
2024-09-19  5:28   ` Modem, Bhanuprakash
2024-09-18 10:44 ` ✗ CI.xeBAT: failure for " Patchwork
2024-09-18 11:29 ` ✓ Fi.CI.BAT: success for tests/kms_universal_plane: Use COMMIT_ATOMIC flag when doing commit (rev2) Patchwork
2024-09-18 11:36 ` ✗ CI.xeBAT: failure " Patchwork
2024-09-18 13:38 ` ✗ CI.xeFULL: failure for tests/kms_universal_plane: Use COMMIT_ATOMIC flag when doing commit Patchwork
2024-09-18 15:15 ` ✓ CI.xeFULL: success for tests/kms_universal_plane: Use COMMIT_ATOMIC flag when doing commit (rev2) Patchwork
2024-09-19  2:25 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240918082918.792033-1-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox