Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: imre.deak@intel.com, Kunal Joshi <kunal1.joshi@intel.com>
Subject: [PATCH i-g-t 5/7] lib/igt_kms.c: refactor parse_path_connector
Date: Mon, 23 Sep 2024 02:55:47 +0530	[thread overview]
Message-ID: <20240922212549.1361889-6-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20240922212549.1361889-1-kunal1.joshi@intel.com>

Use strdup() to make a copy of connector_path
before passing it to strtok(), so the original
string remains unmodified

Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 lib/igt_kms.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 96da33a48..3d2a88b76 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6670,10 +6670,10 @@ static int parse_path_connector(char *connector_path)
 {
 	int connector_id;
 	char *encoder;
+	char *connector_path_copy = strdup(connector_path);
 
-	encoder = strtok(connector_path, ":");
+	encoder = strtok(connector_path_copy, ":");
 	igt_assert_f(!strcmp(encoder, "mst"), "PATH connector property expected to have 'mst'\n");
-
 	connector_id = atoi(strtok(NULL, "-"));
 
 	return connector_id;
@@ -6688,13 +6688,11 @@ static int parse_path_connector(char *connector_path)
 int igt_get_dp_mst_connector_id(igt_output_t *output)
 {
 	int connector_id;
-	char *connector_path;
 
 	if (!igt_check_output_is_dp_mst(output))
 		return -EINVAL;
 
-	connector_path = output->config.connector_path;
-	connector_id = parse_path_connector(connector_path);
+	connector_id = parse_path_connector(output->config.connector_path);
 
 	return connector_id;
 }
-- 
2.43.0


  parent reply	other threads:[~2024-09-22 21:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-22 21:25 [PATCH i-g-t 0/7] add test to validate fallback Kunal Joshi
2024-09-22 21:25 ` [PATCH i-g-t 1/7] lib/igt_kms: add DP link management helper functions Kunal Joshi
2024-09-23 11:47   ` Imre Deak
2024-09-22 21:25 ` [PATCH i-g-t 2/7] lib/igt_kms: add helper to set connector link status Kunal Joshi
2024-09-22 21:25 ` [PATCH i-g-t 3/7] lib/igt_kms: allow set and reset value to be same Kunal Joshi
2024-09-23 11:49   ` Imre Deak
2024-09-22 21:25 ` [PATCH i-g-t 4/7] lib/igt_kms: add function to reset link params Kunal Joshi
2024-09-23 11:50   ` Imre Deak
2024-09-22 21:25 ` Kunal Joshi [this message]
2024-09-23 11:54   ` [PATCH i-g-t 5/7] lib/igt_kms.c: refactor parse_path_connector Imre Deak
2024-09-22 21:25 ` [PATCH i-g-t 6/7] tests/intel/kms_dp_linktrain_fallback: add test for validating fallback Kunal Joshi
2024-09-23 12:21   ` Imre Deak
2024-09-23 13:43     ` Imre Deak
2024-09-22 21:25 ` [PATCH i-g-t 7/7] HAX: Do not merge Kunal Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240922212549.1361889-6-kunal1.joshi@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox