Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
	Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Subject: [PATCH i-g-t 4/4] lib/xe_eudebug: Increase default pipe timeout value
Date: Fri, 27 Sep 2024 16:53:35 +0300	[thread overview]
Message-ID: <20240927135335.1107326-4-mika.kuoppala@linux.intel.com> (raw)
In-Reply-To: <20240927135335.1107326-1-mika.kuoppala@linux.intel.com>

Our discovery tests are quite heavy, there can be tens of
threads of clients and debuggers racing against eachothers.

If there are lots of debugs enabled in kernel config, it is
in real of possibility to end up in a situation where one
client or one debugger really was starved more than 25 seconds.

This timeout is used in communication between test framework,
debuggers and debuggees and thus if we timeout on it,
it will lead to confusing errors in middle tests.

The tradeoff is that for really failing tests where the
other endpoint ceases to respond, we will detect that now
slower.

Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
---
 lib/xe/xe_eudebug.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/xe/xe_eudebug.h b/lib/xe/xe_eudebug.h
index 29ab68fee..6e4666333 100644
--- a/lib/xe/xe_eudebug.h
+++ b/lib/xe/xe_eudebug.h
@@ -112,7 +112,7 @@ typedef void (*xe_eudebug_trigger_fn)(struct xe_eudebug_debugger *,
  * Default abort timeout to use across xe_eudebug lib and tests if no specific
  * timeout value is required.
  */
-#define XE_EUDEBUG_DEFAULT_TIMEOUT_SEC		25ULL
+#define XE_EUDEBUG_DEFAULT_TIMEOUT_SEC		60ULL
 
 #define XE_EUDEBUG_FILTER_EVENT_NONE		BIT(DRM_XE_EUDEBUG_EVENT_NONE)
 #define XE_EUDEBUG_FILTER_EVENT_READ		BIT(DRM_XE_EUDEBUG_EVENT_READ)
-- 
2.34.1


  parent reply	other threads:[~2024-09-27 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 13:53 [PATCH i-g-t 1/4] tests/xe_eudebug: Keep engine for each client Mika Kuoppala
2024-09-27 13:53 ` [PATCH i-g-t 2/4] tests/xe_eudebug: Detect thread starvation on discovery Mika Kuoppala
2024-09-27 13:53 ` [PATCH i-g-t 3/4] lib/xe_eudebug: Warn on pipe timeouts Mika Kuoppala
2024-09-27 13:53 ` Mika Kuoppala [this message]
2024-09-27 16:12 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/xe_eudebug: Keep engine for each client Patchwork
2024-09-27 16:48 ` ✓ CI.xeBAT: " Patchwork
2024-09-28 13:36 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-28 18:48 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927135335.1107326-4-mika.kuoppala@linux.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=dominik.grzegorzek@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox