From: Francois Dugast <francois.dugast@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH i-g-t, v4 2/2] tests/intel/xe_fault_injection: Add new test for fault injection
Date: Mon, 30 Sep 2024 16:08:24 +0200 [thread overview]
Message-ID: <20240930141248.810483-3-francois.dugast@intel.com> (raw)
In-Reply-To: <20240930141248.810483-1-francois.dugast@intel.com>
Use the kernel fault injection infrastructure to test error handling
of xe at probe time.
Add the following test:
* "function-fault-injection"
v2: Fix mismatch between test name and documentation
v3: Use promoted function for bind, rework structure
v4: Use igt_dynamic_f to have one subtest per tested function instead
of a single test for all (Rodrigo Vivi)
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
tests/intel/xe_fault_injection.c | 191 +++++++++++++++++++++++++++++++
tests/meson.build | 1 +
2 files changed, 192 insertions(+)
create mode 100644 tests/intel/xe_fault_injection.c
diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
new file mode 100644
index 000000000..d1c8b2530
--- /dev/null
+++ b/tests/intel/xe_fault_injection.c
@@ -0,0 +1,191 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+/**
+ * TEST: Check fault injection
+ * Category: Core
+ * Mega feature: General Core features
+ * Sub-category: driver
+ * Test category: fault injection
+ */
+
+#include <regex.h>
+
+#include "igt.h"
+#include "igt_device.h"
+#include "igt_kmod.h"
+#include "igt_sysfs.h"
+
+#define MAX_LINE_SIZE 1024
+#define PATH_FUNCTIONS_INJECTABLE "/sys/kernel/debug/fail_function/injectable"
+#define PATH_FUNCTIONS_INJECT "/sys/kernel/debug/fail_function/inject"
+#define PATH_FUNCTIONS_RETVAL "/sys/kernel/debug/fail_function/%s/retval"
+#define REGEX_XE_FUNCTIONS "^(.+)\\[xe\\]"
+#define INJECT_ERRNO -ENOMEM
+
+enum injection_list_action {
+ INJECTION_LIST_ADD,
+ INJECTION_LIST_REMOVE,
+};
+
+/*
+ * The injectable file requires CONFIG_FUNCTION_ERROR_INJECTION in kernel.
+ */
+static bool function_error_injection_enabled(void)
+{
+ FILE *file = fopen(PATH_FUNCTIONS_INJECTABLE, "rw");
+
+ if (file) {
+ fclose(file);
+ return true;
+ }
+
+ return false;
+}
+
+static void injection_list_do(enum injection_list_action action, char function_name[])
+{
+ FILE *file_inject;
+
+ file_inject = fopen(PATH_FUNCTIONS_INJECT, "w");
+ igt_assert(file_inject);
+
+ switch(action) {
+ case INJECTION_LIST_ADD:
+ fprintf(file_inject, "%s", function_name);
+ break;
+ case INJECTION_LIST_REMOVE:
+ fprintf(file_inject, "!%s", function_name);
+ break;
+ default:
+ igt_assert(!"missing");
+ }
+
+ fclose(file_inject);
+}
+
+/*
+ * See https://docs.kernel.org/fault-injection/fault-injection.html#application-examples
+ */
+static void setup_injection_fault(void)
+{
+ FILE *file;
+
+ file = fopen("/sys/kernel/debug/fail_function/task-filter", "w");
+ igt_assert(file);
+ fprintf(file, "N");
+ fclose(file);
+
+ file = fopen("/sys/kernel/debug/fail_function/probability", "w");
+ igt_assert(file);
+ fprintf(file, "100");
+ fclose(file);
+
+ file = fopen("/sys/kernel/debug/fail_function/interval", "w");
+ igt_assert(file);
+ fprintf(file, "0");
+ fclose(file);
+
+ file = fopen("/sys/kernel/debug/fail_function/times", "w");
+ igt_assert(file);
+ fprintf(file, "-1");
+ fclose(file);
+
+ file = fopen("/sys/kernel/debug/fail_function/space", "w");
+ igt_assert(file);
+ fprintf(file, "0");
+ fclose(file);
+
+ file = fopen("/sys/kernel/debug/fail_function/verbose", "w");
+ igt_assert(file);
+ fprintf(file, "1");
+ fclose(file);
+}
+
+static void cleanup_injection_fault(void)
+{
+ FILE *file;
+
+ file = fopen(PATH_FUNCTIONS_INJECT, "w");
+ igt_assert(file);
+ fprintf(file, "\n");
+ fclose(file);
+}
+
+static void set_retval(char function_name[], long long retval)
+{
+ FILE *file_retval;
+ char file_path[MAX_LINE_SIZE];
+
+ sprintf(file_path, PATH_FUNCTIONS_RETVAL, function_name);
+
+ file_retval = fopen(file_path, "w");
+ igt_assert(file_retval);
+
+ fprintf(file_retval, "%#016llx", retval);
+ fclose(file_retval);
+}
+
+/**
+ * SUBTEST: inject-fault-probe
+ * Description: inject an error in the injectable function then reprobe driver
+ * Functionality: fault
+ */
+static void
+inject_fault_try_bind(int fd, char pci_slot[], char function_name[])
+{
+ igt_info("Injecting error \"%s\" (%d) in function \"%s\"\n",
+ strerror(-INJECT_ERRNO), INJECT_ERRNO, function_name);
+
+ injection_list_do(INJECTION_LIST_ADD, function_name);
+ set_retval(function_name, INJECT_ERRNO);
+ xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_TRY_BIND);
+ igt_assert_eq(-errno, INJECT_ERRNO);
+ injection_list_do(INJECTION_LIST_REMOVE, function_name);
+}
+
+igt_main
+{
+ int fd;
+ FILE *file_injectable;
+ char line[MAX_LINE_SIZE];
+ char function_name[64];
+ char pci_slot[MAX_LINE_SIZE];
+ regex_t regex;
+ regmatch_t pmatch[2];
+
+ igt_fixture {
+ igt_require(function_error_injection_enabled());
+ fd = drm_open_driver(DRIVER_XE);
+ igt_device_get_pci_slot_name(fd, pci_slot);
+ setup_injection_fault();
+ file_injectable = fopen(PATH_FUNCTIONS_INJECTABLE, "r");
+ igt_assert(file_injectable);
+ xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_UNBIND);
+ igt_assert_eq(regcomp(®ex, REGEX_XE_FUNCTIONS, REG_EXTENDED), 0);
+ }
+
+ /*
+ * Iterate over each error injectable function of the xe module
+ */
+ igt_subtest_with_dynamic("inject-fault-probe") {
+ while ((fgets(line, MAX_LINE_SIZE, file_injectable)) != NULL) {
+ if (regexec(®ex, line, 2, pmatch, 0) == 0) {
+ strcpy(function_name, line);
+ function_name[pmatch[1].rm_eo - 1] = '\0';
+ igt_dynamic_f("function-%s", function_name)
+ inject_fault_try_bind(fd, pci_slot, function_name);
+ }
+ }
+ }
+
+ igt_fixture {
+ regfree(®ex);
+ fclose(file_injectable);
+ cleanup_injection_fault();
+ drm_close_driver(fd);
+ xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_BIND);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index 62bde353b..3ca62ff9b 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -293,6 +293,7 @@ intel_xe_progs = [
'xe_exec_store',
'xe_exec_threads',
'xe_exercise_blt',
+ 'xe_fault_injection',
'xe_gpgpu_fill',
'xe_gt_freq',
'xe_huc_copy',
--
2.43.0
next prev parent reply other threads:[~2024-09-30 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 14:08 [PATCH i-g-t,v4 0/2] Add test for fault injection Francois Dugast
2024-09-30 14:08 ` [PATCH i-g-t,v4 1/2] lib/igt_sysfs: Promote driver rebind function Francois Dugast
2024-09-30 14:08 ` Francois Dugast [this message]
2024-09-30 15:12 ` [PATCH i-g-t, v4 2/2] tests/intel/xe_fault_injection: Add new test for fault injection Rodrigo Vivi
2024-09-30 20:23 ` ✓ CI.xeBAT: success for Add test for fault injection (rev2) Patchwork
2024-09-30 20:28 ` ✓ Fi.CI.BAT: " Patchwork
2024-10-01 4:01 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-01 7:12 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930141248.810483-3-francois.dugast@intel.com \
--to=francois.dugast@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox