From: Karthik B S <karthik.b.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, santhosh.reddy.guddati@intel.com,
Karthik B S <karthik.b.s@intel.com>
Subject: [PATCH i-g-t] tests/kms_joiner: Reset the force_joiner_supported variable
Date: Tue, 1 Oct 2024 15:15:06 +0530 [thread overview]
Message-ID: <20241001094506.25037-1-karthik.b.s@intel.com> (raw)
With the current logic the test will fail on configs where the first
display supports force joiner and the second display doesn't supoprt it.
Reset the force_joiner_supported variable at the start of the loop to
avoid this failure.
With this remove the redundant check in all the force joiner subtests
for force_joiner_supported as the following output check is inherently
checking this as well.
Signed-off-by: Karthik B S <karthik.b.s@intel.com>
---
tests/intel/kms_joiner.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/tests/intel/kms_joiner.c b/tests/intel/kms_joiner.c
index 508e82ce3..198de9e43 100644
--- a/tests/intel/kms_joiner.c
+++ b/tests/intel/kms_joiner.c
@@ -418,7 +418,6 @@ igt_main
data_t data;
igt_fixture {
- force_joiner_supported = false;
ultra_joiner_supported = false;
data.big_joiner_output_count = 0;
data.ultra_joiner_output_count = 0;
@@ -443,6 +442,7 @@ igt_main
for_each_connected_output(&data.display, output) {
bool ultrajoiner_found = false, bigjoiner_found = false;
drmModeConnector *connector = output->config.connector;
+ force_joiner_supported = false;
/*
* Bigjoiner will come in to the picture when the
@@ -539,8 +539,6 @@ igt_main
igt_describe("Verify the basic modeset on big joiner mode on all pipes");
igt_subtest_with_dynamic("basic-force-big-joiner") {
- igt_require_f(force_joiner_supported,
- "force joiner not supported on this platform or none of the connected output supports it\n");
igt_require_f(data.non_big_joiner_output_count > 0,
"No non big joiner output found\n");
igt_require_f(data.n_pipes > 1,
@@ -560,8 +558,6 @@ igt_main
}
igt_subtest_with_dynamic("invalid-modeset-force-big-joiner") {
- igt_require_f(force_joiner_supported,
- "force joiner not supported on this platform or none of the connected output supports it\n");
igt_require_f(data.non_big_joiner_output_count > 0,
"Non big joiner output not found\n");
igt_require_f(data.n_pipes > 1,
@@ -584,8 +580,6 @@ igt_main
igt_describe("Verify the basic modeset on ultra joiner mode on all pipes");
igt_subtest_with_dynamic("basic-force-ultra-joiner") {
- igt_require_f(force_joiner_supported,
- "force joiner not supported on this platform or none of the connected output supports it\n");
igt_require_f(ultra_joiner_supported,
"Ultra joiner not supported on this platform\n");
igt_require_f(data.non_ultra_joiner_output_count > 0,
@@ -600,8 +594,6 @@ igt_main
}
igt_subtest_with_dynamic("invalid-modeset-force-ultra-joiner") {
- igt_require_f(force_joiner_supported,
- "force joiner not supported on this platform or none of the connected output supports it\n");
igt_require_f(ultra_joiner_supported,
"Ultra joiner not supported on this platform\n");
igt_require_f(data.non_ultra_joiner_output_count > 0,
--
2.39.1
next reply other threads:[~2024-10-01 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 9:45 Karthik B S [this message]
2024-10-01 10:59 ` [PATCH i-g-t] tests/kms_joiner: Reset the force_joiner_supported variable Nautiyal, Ankit K
2024-10-02 0:18 ` Karthik B S
2024-10-01 11:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-10-01 19:45 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-02 7:33 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001094506.25037-1-karthik.b.s@intel.com \
--to=karthik.b.s@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=santhosh.reddy.guddati@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox