Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH v2 i-g-t] tests/intel/oa: Check exec_queue is usable after closing OA stream
Date: Thu,  3 Oct 2024 11:40:58 -0700	[thread overview]
Message-ID: <20241003184058.4054373-1-ashutosh.dixit@intel.com> (raw)

Add a test case to verify that batch buffers submitted on an exec_queue,
after closing the OA stream, do indeed complete. This test is in related to
https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2821 where this was
first noticed.

v2: Submit batch buffers a few times rather than just once

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/intel/xe_oa.c | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 9be4fd6334..5a604ea38e 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -3017,13 +3017,36 @@ test_mi_rpc(struct drm_xe_engine_class_instance *hwe)
 	igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
 	igt_assert_eq(report32[format_size_32], 0x80808080);
 
+	intel_buf_unmap(buf);
+	__perf_close(stream_fd);
+
+	/*
+	 * Re-do MI_RPC a few times after closing perf stream, and check
+	 * batch buffers submitted on exec_queue still complete
+	 */
+	buf_map(drm_fd, buf, true);
+	memset(buf->ptr, 0x80, 4096);
+	intel_buf_unmap(buf);
+
+	for (int i = 0; i < 16; i++) {
+		intel_bb_flush_render(ibb);
+		intel_bb_sync(ibb);
+	}
+
+	buf_map(drm_fd, buf, false);
+	report32 = buf->ptr;
+	format_size_32 = format.size >> 2;
+	dump_report(report32, format_size_32, "mi-rpc");
+
+	igt_assert_eq(report32[0], 0x80808080);
+	igt_assert_eq(oa_timestamp(report32, test_set->perf_oa_format), 0x80808080);
+
 	intel_buf_unmap(buf);
 	intel_buf_destroy(buf);
 	intel_bb_destroy(ibb);
 	xe_exec_queue_destroy(drm_fd, ctx_id);
 	xe_vm_destroy(drm_fd, vm);
 	buf_ops_destroy(bops);
-	__perf_close(stream_fd);
 }
 
 static void
-- 
2.41.0


             reply	other threads:[~2024-10-03 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03 18:40 Ashutosh Dixit [this message]
2024-10-03 19:45 ` ✓ CI.xeBAT: success for tests/intel/oa: Check exec_queue is usable after closing OA stream (rev2) Patchwork
2024-10-03 19:55 ` ✓ Fi.CI.BAT: " Patchwork
2024-10-03 22:37 ` ✗ CI.xeFULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241003184058.4054373-1-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox