From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: mitulkumar.ajitkumar.golani@intel.com,
bhanuprakash.modem@intel.com, ankit.k.nautiyal@intel.com
Subject: [PATCH v1] tests/kms_flip: Assert with twice of frame time while waiting fro vblank
Date: Fri, 11 Oct 2024 11:51:46 +0530 [thread overview]
Message-ID: <20241011062147.1956995-1-mitulkumar.ajitkumar.golani@intel.com> (raw)
Instead of hardcoding to 500us, wait for twice of mode frame time while
waiting for vblank. Motivation of this change is to remove hard coding
of 500us, which comes out to be more stringent and ambiguous vs changing
modeline.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
tests/kms_flip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index cbabbe74f..decffa961 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -921,7 +921,7 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
0, &reply));
end = gettime_us();
igt_debug("Vblank took %luus\n", end - start);
- igt_assert(end - start < 500);
+ igt_assert(end - start < 2 * mode_frame_time(o));
if (reply.sequence != exp_seq) {
igt_debug("unexpected vblank seq %u, should be %u\n",
reply.sequence, exp_seq);
--
2.46.0
next reply other threads:[~2024-10-11 6:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 6:21 Mitul Golani [this message]
2024-10-11 9:56 ` [PATCH v1] tests/kms_flip: Assert with twice of frame time while waiting fro vblank Ville Syrjälä
2024-10-14 5:41 ` Golani, Mitulkumar Ajitkumar
2024-10-11 15:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-10-11 15:44 ` ✓ CI.xeBAT: " Patchwork
2024-10-11 19:14 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-12 8:18 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011062147.1956995-1-mitulkumar.ajitkumar.golani@intel.com \
--to=mitulkumar.ajitkumar.golani@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox