From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH i-g-t] lib/xe/oa: Don't skip if freq sysfs are not present
Date: Mon, 21 Oct 2024 14:42:25 -0700 [thread overview]
Message-ID: <20241021214225.1101453-1-ashutosh.dixit@intel.com> (raw)
Freq sysfs are not created in certain environments. In most of these cases
OA IGT's will work just fine, even when GT min/max freq's are not
known. Therefore, just print a warning if freq sysfs are not present but
don't cause tests to skip.
v2: Change igt_warn to igt_info in case CI doesn't like warn (Umesh)
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
lib/xe/xe_oa.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/lib/xe/xe_oa.c b/lib/xe/xe_oa.c
index 86264230c9..4fdd0b8c95 100644
--- a/lib/xe/xe_oa.c
+++ b/lib/xe/xe_oa.c
@@ -571,11 +571,9 @@ xe_perf_for_fd(int drm_fd, int gt)
}
if (!read_sysfs(sysfs_dir_fd, path_min, >_min_freq) ||
- !read_sysfs(sysfs_dir_fd, path_max, >_max_freq)) {
- igt_warn("Unable to read freqs from sysfs\n");
- close(sysfs_dir_fd);
- return NULL;
- }
+ !read_sysfs(sysfs_dir_fd, path_max, >_max_freq))
+ igt_info("Unable to read freqs from sysfs\n");
+
close(sysfs_dir_fd);
device_id = intel_get_drm_devid(drm_fd);
--
2.41.0
next reply other threads:[~2024-10-21 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 21:42 Ashutosh Dixit [this message]
2024-10-21 23:11 ` ✓ Fi.CI.BAT: success for lib/xe/oa: Don't skip if freq sysfs are not present (rev2) Patchwork
2024-10-21 23:22 ` ✓ CI.xeBAT: " Patchwork
2024-10-22 5:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-22 9:19 ` Kamil Konieczny
2024-10-22 6:28 ` ✓ CI.xeFULL: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-10-21 18:12 [PATCH i-g-t] lib/xe/oa: Don't skip if freq sysfs are not present Ashutosh Dixit
2024-10-21 20:55 ` Umesh Nerlige Ramappa
2024-10-21 21:03 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021214225.1101453-1-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox