From: Jan Sokolowski <jan.sokolowski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Jan Sokolowski <jan.sokolowski@intel.com>,
Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Subject: [PATCH i-g-t v2 2/2] /tests/intel/xe_eudebug_online: Remove vm_open_trigger on debugger reattachment.
Date: Thu, 24 Oct 2024 12:08:51 +0000 [thread overview]
Message-ID: <20241024120851.328536-2-jan.sokolowski@intel.com> (raw)
In-Reply-To: <20241024120851.328536-1-jan.sokolowski@intel.com>
On debugger detach-and-reattach, discovery worker will replay events
that have occurred, which leads to a vm event being sent and
vm_open_trigger being re-run, which would lead to us trying
to open a removed vm.
On debugger reattach trigger, remove vm open trigger from list of
triggers.
Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Signed-off-by: Dominik Grzegorzk <dominik.grzegorzek@intel.com>
---
tests/intel/xe_eudebug_online.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index 01ccf45eb..0ef0d8093 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -1785,6 +1785,12 @@ static void eu_attention_debugger_detach_trigger(struct xe_eudebug_debugger *d,
d->fd = ret;
d->target_pid = c_pid;
+ /* Discovery worker will replay events that have occurred, which leads to
+ * a vm event being sent and vm_open_trigger being re-run, which would lead
+ * to us trying to open a removed vm. Thus, remove this trigger from list.
+ */
+ xe_eudebug_debugger_remove_trigger(d, DRM_XE_EUDEBUG_EVENT_VM, vm_open_trigger);
+
/* Let the discovery worker discover resources */
sleep(2);
--
2.34.1
next prev parent reply other threads:[~2024-10-24 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 12:08 [PATCH i-g-t v2 1/2] /lib/xe/xe_eudebug: Add trigger removal method Jan Sokolowski
2024-10-24 12:08 ` Jan Sokolowski [this message]
2024-10-24 13:18 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] " Patchwork
2024-10-24 14:41 ` ✓ CI.xeBAT: " Patchwork
2024-10-24 16:27 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-25 9:55 ` [PATCH i-g-t v2 1/2] " Grzegorzek, Dominik
2024-10-25 17:56 ` Kamil Konieczny
2024-10-25 15:49 ` ✗ CI.xeFULL: failure for series starting with [i-g-t,v2,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024120851.328536-2-jan.sokolowski@intel.com \
--to=jan.sokolowski@intel.com \
--cc=dominik.grzegorzek@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox