From: <george.zhang@amd.com>
To: <kamil.konieczny@linux.intel.com>
Cc: <igt-dev@lists.freedesktop.org>,
George Zhang <george.zhang@amd.com>,
"Leo Li" <sunpeng.li@amd.com>, Alex Hung <alex.hung@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Nicholas Choi <nicholas.choi@amd.com>
Subject: [Patch v3] scripts/run-test: Keep original prune behaviour
Date: Fri, 25 Oct 2024 14:29:44 -0400 [thread overview]
Message-ID: <20241025182944.866-1-george.zhang@amd.com> (raw)
From: George Zhang <george.zhang@amd.com>
The default prune behaviour of the runner settings was changed.
This change is to maintain the original behaviour of this script
while also enabling the prune mode to be overriden.
v2: added m to getopts
v3: fixed bm: -> b:m: in getopts
Fixes: 997bac8 ("runner/settings: set PRUNE_KEEP_ALL as default")
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Nicholas Choi <nicholas.choi@amd.com>
Signed-off-by: George Zhang <george.zhang@amd.com>
---
scripts/run-tests.sh | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
index cd03682b4..082ebaa5a 100755
--- a/scripts/run-tests.sh
+++ b/scripts/run-tests.sh
@@ -37,6 +37,7 @@ KERNEL_TREE=
USE_PIGLIT=0
RUNNER=
RESUME=
+PRUNE_MODE="keep-dynamic"
find_file() # basename <possible paths>
{
@@ -154,11 +155,12 @@ print_help() {
echo " test run with -R"
echo " (only valid for Piglit)"
echo " -p use Piglit instead of igt_runner"
+ echo " -m run test runner with prune mode(default: $PRUNE_MODE)"
echo ""
echo "Useful patterns for test filtering are described in the API documentation."
}
-while getopts ":c:dhk:lPr:st:T:vx:Rnpb:" opt; do
+while getopts ":c:dhk:lPr:st:T:vx:Rnpb:m:" opt; do
case $opt in
c) COV_ARGS="$COV_ARGS --collect-code-cov --collect-script $OPTARG " ;;
d) download_piglit; exit ;;
@@ -176,6 +178,7 @@ while getopts ":c:dhk:lPr:st:T:vx:Rnpb:" opt; do
n) NORETRY="--no-retry" ;;
p) USE_PIGLIT=1 ;;
b) FILTER="$FILTER -b $OPTARG" ;;
+ m) PRUNE_MODE="$OPTARG" ;;
:)
echo "Option -$OPTARG requires an argument."
exit 1
@@ -253,7 +256,7 @@ if [ "x$RESUME_RUN" != "x" ]; then
execute_runner 1 $RESUME $RESUME_ARGS $COV_ARGS "$RESULTS"
else
mkdir -p "$RESULTS"
- execute_runner 1 $RUNNER $RUN_ARGS -o -s "$RESULTS" $COV_ARGS $VERBOSE $FILTER
+ execute_runner 1 $RUNNER $RUN_ARGS -o -s "$RESULTS" $COV_ARGS $VERBOSE $FILTER --prune-mode $PRUNE_MODE
fi
if [ "$SUMMARY" = "html" ]; then
--
2.34.1
next reply other threads:[~2024-10-25 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 18:29 george.zhang [this message]
2024-10-25 18:50 ` [Patch v3] scripts/run-test: Keep original prune behaviour Kamil Konieczny
2024-10-25 20:26 ` ✓ Fi.CI.BAT: success for scripts/run-test: Keep original prune behaviour (rev3) Patchwork
2024-10-25 20:36 ` ✓ CI.xeBAT: " Patchwork
2024-10-26 3:44 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-28 13:59 ` Zhang, George
2024-10-28 15:18 ` Kamil Konieczny
2024-10-27 11:00 ` ✗ CI.xeFULL: " Patchwork
2024-10-28 15:19 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025182944.866-1-george.zhang@amd.com \
--to=george.zhang@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=alex.hung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=nicholas.choi@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox