From: <george.zhang@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <sunpeng.li@amd.com>, <chiahsuan.chung@amd.com>,
<alex.hung@amd.com>, George Zhang <george.zhang@amd.com>
Subject: [Patch v2] tests/amdgpu/amd_abm: Fixed tests to only run on one output per pipe
Date: Wed, 6 Nov 2024 11:50:58 -0500 [thread overview]
Message-ID: <20241106165058.35171-1-george.zhang@amd.com> (raw)
From: George Zhang <george.zhang@amd.com>
The abm tests only need to run on one output per pipe, instead of all
pipes. Additionally, fixed the monotonic_abm not changing the abm level.
v2: Made change for more tests
Signed-off-by: George Zhang <george.zhang@amd.com>
---
tests/amdgpu/amd_abm.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
index a85f444c4..e196b6ebc 100644
--- a/tests/amdgpu/amd_abm.c
+++ b/tests/amdgpu/amd_abm.c
@@ -225,7 +225,7 @@ static void backlight_dpms_cycle(data_t *data)
igt_output_t *output;
enum pipe pipe;
- for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
@@ -257,7 +257,7 @@ static void backlight_monotonic_basic(data_t *data)
enum pipe pipe;
igt_output_t *output;
- for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
ret = backlight_read_max_brightness(&max_brightness);
@@ -291,7 +291,7 @@ static void backlight_monotonic_abm(data_t *data)
enum pipe pipe;
igt_output_t *output;
- for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
ret = backlight_read_max_brightness(&max_brightness);
@@ -299,7 +299,7 @@ static void backlight_monotonic_abm(data_t *data)
brightness_step = max_brightness / 10;
for (i = 1; i < 5; i++) {
- set_abm_level(data, output, 0);
+ set_abm_level(data, output, i);
backlight_write_brightness(max_brightness);
usleep(100000);
prev_pwm = read_target_backlight_pwm(data->drm_fd, output->name);
@@ -324,7 +324,7 @@ static void abm_enabled(data_t *data)
enum pipe pipe;
igt_output_t *output;
- for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
@@ -357,7 +357,7 @@ static void abm_gradual(data_t *data)
enum pipe pipe;
igt_output_t *output;
- for_each_pipe_with_valid_output(&data->display, pipe, output) {
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
--
2.34.1
next reply other threads:[~2024-11-06 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 16:50 george.zhang [this message]
2024-11-06 18:56 ` ✓ Fi.CI.BAT: success for tests/amdgpu/amd_abm: Fixed tests to only run on one output per pipe Patchwork
2024-11-06 18:56 ` ✓ CI.xeBAT: " Patchwork
2024-11-06 22:13 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-07 3:15 ` [Patch v2] " Chung, ChiaHsuan (Tom)
2024-11-08 0:39 ` ✗ CI.xeFULL: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106165058.35171-1-george.zhang@amd.com \
--to=george.zhang@amd.com \
--cc=alex.hung@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox