Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t v3 2/6] lib/igt_kmod: Fix leaking subtest name
Date: Wed,  6 Nov 2024 21:52:50 -0800	[thread overview]
Message-ID: <20241107055254.3129207-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20241107055254.3129207-1-lucas.demarchi@intel.com>

Keep it simple, checking by !suite and then assigning subtest
accordingly. Since this is done only once, always call strdup()
and free().

Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_kmod.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 5224d36a4..3729a053c 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -1197,8 +1197,8 @@ void igt_kunit(const char *module_name, const char *suite, const char *opts)
 	char debugfs_path[PATH_MAX] = { '\0', };
 	struct igt_ktest tst = { .kmsg = -1, };
 	struct igt_ktap_results *ktap = NULL;
-	const char *subtest = suite;
 	DIR *debugfs_dir = NULL;
+	char *subtest;
 	IGT_LIST_HEAD(tests);
 
 	/*
@@ -1206,7 +1206,9 @@ void igt_kunit(const char *module_name, const char *suite, const char *opts)
 	 * we take the module name, drop the trailing "_test" or "_kunit"
 	 * suffix, if any, and use the result as our IGT subtest name.
 	 */
-	if (!subtest) {
+	if (suite) {
+		subtest = strdup(suite);
+	} else {
 		subtest = strdup(module_name);
 		if (!igt_debug_on(!subtest)) {
 			char *suffix = strstr(subtest, "_test");
@@ -1259,6 +1261,7 @@ void igt_kunit(const char *module_name, const char *suite, const char *opts)
 		igt_ktest_end(&tst);
 	}
 
+	free(subtest);
 	igt_ktest_fini(&tst);
 }
 
-- 
2.47.0


  parent reply	other threads:[~2024-11-07  5:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07  5:52 [PATCH i-g-t v3 0/6] lib/igt_kmod: Drop legacy kunit integration Lucas De Marchi
2024-11-07  5:52 ` [PATCH i-g-t v3 1/6] lib/igt_kmod: Drop legacy kunit fallback Lucas De Marchi
2024-11-07  5:52 ` Lucas De Marchi [this message]
2024-11-07  5:52 ` [PATCH i-g-t v3 3/6] lib/igt_kmod: Stop passing debugfs_dir around Lucas De Marchi
2024-11-14 14:24   ` Janusz Krzysztofik
2024-11-14 20:58     ` Lucas De Marchi
2024-11-14 21:45       ` Lucas De Marchi
2024-11-15 14:24         ` Janusz Krzysztofik
2024-11-07  5:52 ` [PATCH i-g-t v3 4/6] lib/igt_kmod: Stop passing ktap around Lucas De Marchi
2024-11-14 15:00   ` Janusz Krzysztofik
2024-11-07  5:52 ` [PATCH i-g-t v3 5/6] lib/igt_ktap: Just free ktap Lucas De Marchi
2024-11-14 15:02   ` Janusz Krzysztofik
2024-11-07  5:52 ` [PATCH i-g-t v3 6/6] lib/igt_kmod: Do not leak kmod ctx Lucas De Marchi
2024-11-14 17:06   ` Janusz Krzysztofik
2024-11-07  6:22 ` ✓ CI.xeBAT: success for lib/igt_kmod: Drop legacy kunit integration (rev3) Patchwork
2024-11-07  6:27 ` ✓ Fi.CI.BAT: " Patchwork
2024-11-07  7:29 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-08 11:25 ` ✗ CI.xeFULL: " Patchwork
2024-11-14 22:00 ` ✗ Fi.CI.BUILD: failure for lib/igt_kmod: Drop legacy kunit integration (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107055254.3129207-3-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=janusz.krzysztofik@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox