Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com,
	alex.zuo@intel.com, kamil.konieczny@linux.intel.com,
	vinay.belgaumkar@intel.com
Subject: [PATCH v5 0/3] test/intel/xe_sysfs: Restore sysfs params correctly
Date: Thu,  7 Nov 2024 22:52:51 +0000	[thread overview]
Message-ID: <20241107225254.302010-1-jonathan.cavitt@intel.com> (raw)

The xe_sysfs_timeslice_duration and xe_sysfs_preempt_timeout tests do
not correctly restore modified sysfs params on test failure.
Additionally, xe_sysfs_timeslice_duration modifies but does not restore
preempt_timeout_us.  Repair these issues.

v3: Fix several formatting issues (Kamil)

v4: Do not compare possibly unassigned variable (Kamil)
    Whitespace and commit name fixes (Kamil)

v5: Add new helper funciton, igt_sysfs_get_next_engine
    Fix igt_sysfs_scanf/printf usage in tests (Kamil)

Jonathan Cavitt (3):
  lib/igt_sysfs: Add igt_sysfs_get_next_engine
  tests/intel/xe_sysfs*: Restore values on test failure
  tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout

 lib/igt_sysfs.c                           | 36 +++++++++++
 lib/igt_sysfs.h                           |  1 +
 tests/intel/xe_sysfs_preempt_timeout.c    | 55 +++++++++++++----
 tests/intel/xe_sysfs_timeslice_duration.c | 73 +++++++++++++++++++----
 4 files changed, 145 insertions(+), 20 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-11-07 22:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 22:52 Jonathan Cavitt [this message]
2024-11-07 22:52 ` [PATCH v5 1/3] lib/igt_sysfs: Add igt_sysfs_get_next_engine Jonathan Cavitt
2024-11-15 14:36   ` Kamil Konieczny
2024-11-15 16:23     ` Cavitt, Jonathan
2024-11-07 22:52 ` [PATCH v5 2/3] tests/intel/xe_sysfs*: Restore values on test failure Jonathan Cavitt
2024-11-07 22:52 ` [PATCH v5 3/3] tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout Jonathan Cavitt
2024-11-07 23:14 ` ✗ GitLab.Pipeline: warning for test/intel/xe_sysfs: Restore sysfs params correctly Patchwork
2024-11-07 23:40 ` ✓ CI.xeBAT: success " Patchwork
2024-11-08  0:03 ` ✓ Fi.CI.BAT: " Patchwork
2024-11-08  3:10 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-09  6:11 ` ✗ CI.xeFULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107225254.302010-1-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox