From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t 2/2] Fix bigjoiner compatibility checks for connector modes
Date: Tue, 12 Nov 2024 22:04:35 +0530 [thread overview]
Message-ID: <20241112163435.1351560-3-jeevan.b@intel.com> (raw)
In-Reply-To: <20241112163435.1351560-1-jeevan.b@intel.com>
fix bigjoiner compatibility checks by adding drm_fd argument.
added unsupported config checks for bigjoiner modes in display tests.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/intel/kms_pm_lpsp.c | 4 ++--
tests/kms_display_modes.c | 6 ++++++
tests/kms_flip.c | 4 ++--
tests/kms_setmode.c | 4 ++--
4 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests/intel/kms_pm_lpsp.c b/tests/intel/kms_pm_lpsp.c
index 889da42de..74e9d799a 100644
--- a/tests/intel/kms_pm_lpsp.c
+++ b/tests/intel/kms_pm_lpsp.c
@@ -166,11 +166,11 @@ static bool test_constraint(data_t *data)
if (igt_check_force_joiner_status(data->drm_fd, data->output->name))
return false;
- if (igt_bigjoiner_possible(mode, max_dotclock)) {
+ if (igt_bigjoiner_possible(data->drm_fd, mode, max_dotclock)) {
for_each_connector_mode(data->output) {
mode = &data->output->config.connector->modes[j__];
- if (igt_bigjoiner_possible(mode, max_dotclock))
+ if (igt_bigjoiner_possible(data->drm_fd, mode, max_dotclock))
continue;
igt_output_override_mode(data->output, mode);
diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index f1d8ab03d..0950cc483 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -318,6 +318,12 @@ igt_main
igt_display_require_output(&data.display);
for_each_connected_output(&data.display, output) {
+ drmModeConnector *connector = output->config.connector;
+ drmModeModeInfo mode;
+ int max_dotclock = igt_get_max_dotclock(data.drm_fd);
+
+ igt_require_f(!bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode),
+ "Big Joiner Connector Found Unsupported Config\n");
data.mst_output[count++] = output;
if (output_is_dp_mst(&data, output, dp_mst_outputs))
dp_mst_outputs++;
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index cbabbe74f..17da10e2e 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1756,11 +1756,11 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
o->kconnector[i - 1]->connector_type_id);
if (((igt_check_force_joiner_status(drm_fd, conn_name) ||
- igt_bigjoiner_possible(&o->kmode[i], max_dotclock)) &&
+ igt_bigjoiner_possible(drm_fd, &o->kmode[i], max_dotclock)) &&
((crtc_idxs[i] >= (total_crtcs - 1)) ||
((i < (crtc_count - 1)) && (abs(crtc_idxs[i + 1] - crtc_idxs[i]) <= 1)))) ||
((i > 0) && (igt_check_force_joiner_status(drm_fd, prev_conn_name) ||
- igt_bigjoiner_possible(&o->kmode[i - 1], max_dotclock)) &&
+ igt_bigjoiner_possible(drm_fd, &o->kmode[i - 1], max_dotclock)) &&
(abs(crtc_idxs[i] - crtc_idxs[i - 1]) <= 1))) {
igt_debug("Combo: %s is not possible with selected mode(s).\n", test_name);
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index bc7b8fabb..d61cfeb9a 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -736,11 +736,11 @@ static void test_one_combination(const struct test_config *tconf,
* - current & previous crtcs are consecutive
*/
if (((igt_check_force_joiner_status(drm_fd, conn_name) ||
- igt_bigjoiner_possible(&crtc->mode, max_dotclock)) &&
+ igt_bigjoiner_possible(drm_fd, &crtc->mode, max_dotclock)) &&
((crtc->crtc_idx >= (tconf->resources->count_crtcs - 1)) ||
((i < (crtc_count - 1)) && (abs(crtcs[i + 1].crtc_idx - crtc->crtc_idx) <= 1)))) ||
((i > 0) && (igt_check_force_joiner_status(drm_fd, prev_conn_name) ||
- igt_bigjoiner_possible(&crtc[i - 1].mode, max_dotclock)) &&
+ igt_bigjoiner_possible(drm_fd, &crtc[i - 1].mode, max_dotclock)) &&
(abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
igt_info("Combo: %s is not possible with selected mode(s).\n", test_name);
goto out;
--
2.25.1
next prev parent reply other threads:[~2024-11-12 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 16:34 [PATCH i-g-t 0/2] lib/igt_kms: Add 6k resolution support for a single CRTC Jeevan B
2024-11-12 16:34 ` [PATCH i-g-t 1/2] " Jeevan B
2024-11-14 20:17 ` Sharma, Swati2
2024-11-21 10:15 ` B, Jeevan
2024-11-12 16:34 ` Jeevan B [this message]
2024-11-14 20:30 ` [PATCH i-g-t 2/2] Fix bigjoiner compatibility checks for connector modes Sharma, Swati2
2024-11-12 17:29 ` ✓ CI.xeBAT: success for lib/igt_kms: Add 6k resolution support for a single CRTC (rev2) Patchwork
2024-11-12 17:35 ` ✓ Fi.CI.BAT: " Patchwork
2024-11-12 19:23 ` ✗ CI.xeFULL: failure " Patchwork
2024-11-12 23:15 ` ✗ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-11-21 10:45 [PATCH i-g-t 0/2] lib/igt_kms: Add 6k resolution support for a single CRTC Jeevan B
2024-11-21 10:45 ` [PATCH i-g-t 2/2] Fix bigjoiner compatibility checks for connector modes Jeevan B
2024-11-21 17:21 ` Sharma, Swati2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112163435.1351560-3-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox