From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, bhanuprakash.modem@intel.com,
swati2.sharma@intel.com, sameer.lattannavar@intel.com,
pranay.samala@intel.com
Subject: [PATCH i-g-t v7] tests/kms_3d: Add more logs to skips/failure
Date: Thu, 14 Nov 2024 08:47:53 +0530 [thread overview]
Message-ID: <20241114031753.1859302-1-pranay.samala@intel.com> (raw)
Having some logs for test failures and skips would
make debugging much easier.
v2: Remove CRTC log for fail/skip (Bhanu)
v3: Add check for connector connection
v4: Remove check for connector connection (Bhanu)
v5: Rebasing and sending other version
v6: Remove igt_info for connector support (Bhanu)
v7: Add Reviewed by statement in commit message (Swati)
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_3d.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index ad6c45e9b..8e9e9929c 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -55,7 +55,8 @@ igt_simple_main
res = drmModeGetResources(drm_fd);
igt_require(res);
- igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0);
+ igt_assert_f(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0,
+ "Failed to enable STEREO_3D capability.\n");
/* find an hdmi connector */
for (int i = 0; i < res->count_connectors; i++) {
@@ -65,7 +66,7 @@ igt_simple_main
drmModeFreeConnector(connector);
connector = NULL;
}
- igt_require(connector);
+ igt_require_f(connector, "No HDMI connector found.\n");
kmstest_unset_all_crtcs(drm_fd, res);
@@ -85,7 +86,7 @@ igt_simple_main
mode_count++;
}
- igt_assert(mode_count);
+ igt_assert_f(mode_count, "3D modes not detected.\n");
/* set 3D modes */
igt_info("Testing:\n");
--
2.34.1
next reply other threads:[~2024-11-14 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 3:17 Pranay Samala [this message]
2024-11-14 3:53 ` ✓ CI.xeBAT: success for tests/kms_3d: Add more logs to skips/failure (rev7) Patchwork
2024-11-14 4:35 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-14 13:42 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114031753.1859302-1-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox