From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com,
alex.zuo@intel.com, kamil.konieczny@linux.intel.com,
vinay.belgaumkar@intel.com
Subject: [PATCH v6 0/3] test/intel/xe_sysfs: Restore sysfs params correctly
Date: Fri, 15 Nov 2024 17:03:49 +0000 [thread overview]
Message-ID: <20241115170352.102039-1-jonathan.cavitt@intel.com> (raw)
The xe_sysfs_timeslice_duration and xe_sysfs_preempt_timeout tests do
not correctly restore modified sysfs params on test failure.
Additionally, xe_sysfs_timeslice_duration modifies but does not restore
preempt_timeout_us. Repair these issues.
v3: Fix several formatting issues (Kamil)
v4: Do not compare possibly unassigned variable (Kamil)
Whitespace and commit name fixes (Kamil)
v5: Add new helper funciton, igt_sysfs_get_next_engine
Fix igt_sysfs_scanf/printf usage in tests (Kamil)
v6: Replace helper function igt_sysfs_get_next_engine with new helper
functions that return and destroy engine lists (Kamil)
Jonathan Cavitt (3):
lib/igt_sysfs: Add engine list helpers
tests/intel/xe_sysfs*: Restore values on test failure
tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout
lib/igt_sysfs.c | 54 +++++++++++++++++
lib/igt_sysfs.h | 3 +
tests/intel/xe_sysfs_preempt_timeout.c | 58 +++++++++++++++---
tests/intel/xe_sysfs_timeslice_duration.c | 74 ++++++++++++++++++++---
4 files changed, 169 insertions(+), 20 deletions(-)
--
2.43.0
next reply other threads:[~2024-11-15 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 17:03 Jonathan Cavitt [this message]
2024-11-15 17:03 ` [PATCH v6 1/3] lib/igt_sysfs: Add engine list helpers Jonathan Cavitt
2024-11-15 17:03 ` [PATCH v6 2/3] tests/intel/xe_sysfs*: Restore values on test failure Jonathan Cavitt
2024-11-15 17:03 ` [PATCH v6 3/3] tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout Jonathan Cavitt
2024-11-15 17:45 ` ✓ CI.xeBAT: success for test/intel/xe_sysfs: Restore sysfs params correctly Patchwork
2024-11-15 17:53 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-16 1:42 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115170352.102039-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=saurabhg.gupta@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox