Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com,
	alex.zuo@intel.com, kamil.konieczny@linux.intel.com,
	vinay.belgaumkar@intel.com
Subject: [PATCH v7 1/4] lib/igt_sysfs: Add engine list helpers
Date: Mon, 18 Nov 2024 18:05:08 +0000	[thread overview]
Message-ID: <20241118180511.64212-2-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20241118180511.64212-1-jonathan.cavitt@intel.com>

Create two new helper functions, igt_sysfs_get_engine_list and
igt_sysfs_free_engine_list, that create and destroy lists of open
engines, respectively.  The list created by igt_sysfs_get_engine_list
can be used to iterate over the set of engines in sysfs/engines and must
be freed by igt_sysfs_free_engine_list after use.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 lib/igt_sysfs.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_sysfs.h |  3 +++
 2 files changed, 57 insertions(+)

diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
index 00d5822fd3..3d2dd364cf 100644
--- a/lib/igt_sysfs.c
+++ b/lib/igt_sysfs.c
@@ -1307,6 +1307,60 @@ static uint16_t xe_get_engine_class(char *name)
 	return class;
 }
 
+/**
+ * igt_sysfs_get_engine_list:
+ * @engines: fd of the directory engine
+ * @size: pointer to store the size of the returned char pointer
+ *
+ * Iterates over sysfs/engines and returns an array of
+ * opened engines.  The user will be in charge of closing
+ * the opened engines.
+ *
+ * The number of opened engines will be saved to size.
+ */
+int *igt_sysfs_get_engine_list(int engines, int *size)
+{
+	struct dirent *de;
+	DIR *dir;
+	int* ret = calloc(1, sizeof(int));
+
+	lseek(engines, 0, SEEK_SET);
+
+	dir = fdopendir(engines);
+	if (!dir)
+		close(engines);
+
+	*size = 0;
+	while ((de = readdir(dir))) {
+		if (*de->d_name == '.')
+			continue;
+		ret[*size] = openat(engines, de->d_name, O_RDONLY);
+		if (ret[*size] < 0) {
+			ret[*size] = 0;
+			continue;
+		}
+		*size += 1;
+		reallocarray(ret, *size + 1, sizeof(int));
+	}
+	return ret;
+}
+
+/**
+ * igt_sysfs_free_engine_list:
+ * @list: list of opened engines
+ * @size: number of engines in list
+ *
+ * Helper for cleaning up after igt_sysfs_get_engine_list.
+ * Closes all engines in list before freeing the list.
+ */
+void igt_sysfs_free_engine_list(int *list, int size)
+{
+	int i;
+	for (i = 0; i < size; i++)
+		close(list[i]);
+	free(list);
+}
+
 /**
  * igt_sysfs_engines:
  * @xe: fd of the device
diff --git a/lib/igt_sysfs.h b/lib/igt_sysfs.h
index 54a4087918..ba0a74755c 100644
--- a/lib/igt_sysfs.h
+++ b/lib/igt_sysfs.h
@@ -168,6 +168,9 @@ typedef struct igt_sysfs_rw_attr {
 
 void igt_sysfs_rw_attr_verify(igt_sysfs_rw_attr_t *rw);
 
+int *igt_sysfs_get_engine_list(int engines, int *size);
+void igt_sysfs_free_engine_list(int *list, int size);
+
 void igt_sysfs_engines(int xe, int engines, int gt, bool all, const char **property,
 		       void (*test)(int, int, const char **, uint16_t, int));
 
-- 
2.43.0


  reply	other threads:[~2024-11-18 18:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 18:05 [PATCH v7 0/4] test/intel/xe_sysfs: Restore sysfs params correctly Jonathan Cavitt
2024-11-18 18:05 ` Jonathan Cavitt [this message]
2024-11-26 17:06   ` [PATCH v7 1/4] lib/igt_sysfs: Add engine list helpers Kamil Konieczny
2024-12-02 16:32     ` Cavitt, Jonathan
2024-11-18 18:05 ` [PATCH v7 2/4] tests/intel/xe_sysfs*: Restore values on test failure Jonathan Cavitt
2024-11-26 16:55   ` Kamil Konieczny
2024-12-02 15:13     ` Cavitt, Jonathan
2024-11-18 18:05 ` [PATCH v7 3/4] tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout Jonathan Cavitt
2024-11-18 18:05 ` [PATCH v7 4/4] tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored Jonathan Cavitt
2024-11-26 17:15   ` Kamil Konieczny
2024-11-19  3:20 ` ✓ CI.xeBAT: success for test/intel/xe_sysfs: Restore sysfs params correctly Patchwork
2024-11-19  3:34 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-19 16:34 ` ✗ CI.xeFULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241118180511.64212-2-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox