Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Gmeiner <christian.gmeiner@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: kernel-dev@igalia.com, tursulin@igalia.com,
	Christian Gmeiner <cgmeiner@igalia.com>
Subject: [PATCH i-g-t] gputop: Add memory only utilization type
Date: Thu, 21 Nov 2024 10:38:21 +0100	[thread overview]
Message-ID: <20241121093822.3863544-1-christian.gmeiner@gmail.com> (raw)

From: Christian Gmeiner <cgmeiner@igalia.com>

Add special handling for drivers that only provide memory utilization
fdinfo.

Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
---
 tools/gputop.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tools/gputop.c b/tools/gputop.c
index 43b01f566..4135d84c1 100644
--- a/tools/gputop.c
+++ b/tools/gputop.c
@@ -35,6 +35,7 @@
 enum utilization_type {
 	UTILIZATION_TYPE_ENGINE_TIME,
 	UTILIZATION_TYPE_TOTAL_CYCLES,
+	UTILIZATION_TYPE_MEMORY_ONLY,
 };
 
 static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" };
@@ -141,6 +142,9 @@ engines_identical(const struct igt_drm_client *c,
 	    c->engines->max_engine_id != pc->engines->max_engine_id)
 		return false;
 
+	if (!c->engines->num_engines && !pc->engines->num_engines)
+		return true;
+
 	for (i = 0; i <= c->engines->max_engine_id; i++)
 		if (c->engines->capacity[i] != pc->engines->capacity[i] ||
 		    !!c->engines->names[i] != !!pc->engines->names[i] ||
@@ -193,6 +197,8 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
 		utilization_type = UTILIZATION_TYPE_TOTAL_CYCLES;
 	else if (c->utilization_mask & IGT_DRM_CLIENT_UTILIZATION_ENGINE_TIME)
 		utilization_type = UTILIZATION_TYPE_ENGINE_TIME;
+	else if (c->regions->num_regions)
+		utilization_type = UTILIZATION_TYPE_MEMORY_ONLY;
 	else
 		return 0;
 
@@ -209,6 +215,13 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
 	       if (!c->total_total_cycles)
 		       return 0;
 	       break;
+	case UTILIZATION_TYPE_MEMORY_ONLY:
+		for (sz = 0, i = 0; i <= c->regions->max_region_id; i++)
+			sz += c->memory[i].total;
+
+		if (sz == 0)
+			return 0;
+		break;
 	}
 
 	/* Print header when moving to a different DRM card. */
@@ -234,6 +247,9 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
 
 	lines++;
 
+	if (utilization_type == UTILIZATION_TYPE_MEMORY_ONLY)
+		goto print_name;
+
 	for (i = 0; c->samples > 1 && i <= c->engines->max_engine_id; i++) {
 		double pct;
 
@@ -249,6 +265,9 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
 			pct = (double)c->utilization[i].delta_cycles / c->utilization[i].delta_total_cycles * 100 /
 				c->engines->capacity[i];
 			break;
+		case UTILIZATION_TYPE_MEMORY_ONLY:
+			/* Nothing to do. */
+			break;
 		}
 
 		/*
@@ -262,6 +281,7 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc,
 		len += *engine_w;
 	}
 
+print_name:
 	printf(" %-*s\n", con_w - len - 1, c->print_name);
 
 	return lines;
-- 
2.47.0


             reply	other threads:[~2024-11-22  8:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21  9:38 Christian Gmeiner [this message]
2024-11-21 10:03 ` [PATCH i-g-t] gputop: Add memory only utilization type Tvrtko Ursulin
2024-11-21 18:35   ` Christian Gmeiner
2024-11-22  8:54     ` Tvrtko Ursulin
2024-11-22 20:19       ` Christian Gmeiner
2024-11-25  9:03         ` Tvrtko Ursulin
2024-11-22 11:20 ` ✗ GitLab.Pipeline: warning for " Patchwork
2024-11-22 11:35 ` ✓ Xe.CI.BAT: success " Patchwork
2024-11-22 12:01 ` ✗ i915.CI.BAT: failure " Patchwork
2024-11-22 21:24 ` ✗ Fi.CI.BUILD: failure for gputop: Add memory only utilization type (rev2) Patchwork
2024-11-23  9:03 ` ✗ Xe.CI.Full: failure for gputop: Add memory only utilization type Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241121093822.3863544-1-christian.gmeiner@gmail.com \
    --to=christian.gmeiner@gmail.com \
    --cc=cgmeiner@igalia.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=tursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox